From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Date: Thu, 15 Mar 2018 15:30:26 +0200 Message-ID: <20180315133026.GR5453@intel.com> References: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joe Perches Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXIgMTMsIDIwMTggYXQgMDM6MDI6MTVQTSAtMDcwMCwgSm9lIFBlcmNoZXMgd3Jv dGU6Cj4gZHJtX3ByaW50ayBpcyB1c2VkIGZvciBib3RoIERSTV9FUlJPUiBhbmQgRFJNX0RFQlVH IHdpdGggdW5uZWNlc3NhcnkKPiBhcmd1bWVudHMgdGhhdCBjYW4gYmUgcmVtb3ZlZCBieSBjcmVh dGluZyBzZXBhcmF0ZSBmdW5jdGlucy4KPiAKPiBDcmVhdGUgc3BlY2lmaWMgZnVuY3Rpb25zIGZv ciB0aGVzZSBjYWxscyB0byByZWR1Y2UgeDg2LzY0IGRlZmNvbmZpZwo+IHNpemUgYnkgfjIway4K PiAKPiBNb2RpZnkgdGhlIGV4aXN0aW5nIG1hY3JvcyB0byB1c2UgdGhlIHNwZWNpZmljIGNhbGxz Lgo+IAo+IG5ldzoKPiAkIHNpemUgLXQgZHJpdmVycy9ncHUvZHJtL2J1aWx0LWluLmEgfCB0YWls IC0xCj4gMTg3NjU2MgkgIDQ0NTQyCSAgICA5OTUJMTkyMjA5OQkgMWQ1NDMzCShUT1RBTFMpCj4g Cj4gb2xkOgo+ICQgc2l6ZSAtdCBkcml2ZXJzL2dwdS9kcm0vYnVpbHQtaW4uYSB8IHRhaWwgLTEK PiAxODk3NTY1CSAgNDQ1NDIJICAgIDk5NQkxOTQzMTAyCSAxZGE2M2UJKFRPVEFMUykKPiAKPiBN aXNjZWxsYW5lYToKPiAKPiBvIGludGVsX2Rpc3BsYXkgcmVxdWlyZXMgYSBjaGFuZ2UgdG8gdXNl IHRoZSBzcGVjaWZpYyBjYWxscy4KCkhvdyBtdWNoIHdvdWxkIHdlIGxvc2UgaWYgd2UgbW92ZSB0 aGUgKGRybV9kZWJ1ZyZGT08pIG91dHNpZGUgdGhlCmZ1bmN0aW9ucyBhZ2Fpbj8gSSdtIHNvbWV3 aGF0IGNvbmNlcm5lZCBhYm91dCBhbGwgdGhlIGZ1bmN0aW9uIGNhbGwKb3ZlcmhlYWQgd2hlbiBk ZWJ1Z3MgYXJlbid0IGV2ZW4gZW5hYmxlZC4KCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9lIFBlcmNo ZXMgPGpvZUBwZXJjaGVzLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wcmludC5j ICAgICAgICAgIHwgMjggKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxNSArKysrLS0tLS0tLS0tLS0KPiAgaW5jbHVk ZS9kcm0vZHJtX3ByaW50LmggICAgICAgICAgICAgIHwgMjcgKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbnQuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fcHJpbnQuYwo+IGluZGV4IDc4MTUxOGZkODhlMy4uNzlhYmY2ZDViNGRi IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbnQuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fcHJpbnQuYwo+IEBAIC04OSwyMyArODksMzcgQEAgdm9pZCBkcm1fZGV2 X3ByaW50ayhjb25zdCBzdHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0IGNoYXIgKmxldmVsLAo+ICB9 Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2Rldl9wcmludGspOwo+ICAKPiAtdm9pZCBkcm1fcHJpbnRr KGNvbnN0IGNoYXIgKmxldmVsLCB1bnNpZ25lZCBpbnQgY2F0ZWdvcnksCj4gLQkJY29uc3QgY2hh ciAqZm9ybWF0LCAuLi4pCj4gK3ZvaWQgZHJtX2RiZyh1bnNpZ25lZCBpbnQgY2F0ZWdvcnksIGNv bnN0IGNoYXIgKmZvcm1hdCwgLi4uKQo+ICB7Cj4gIAlzdHJ1Y3QgdmFfZm9ybWF0IHZhZjsKPiAg CXZhX2xpc3QgYXJnczsKPiAgCj4gLQlpZiAoY2F0ZWdvcnkgIT0gRFJNX1VUX05PTkUgJiYgIShk cm1fZGVidWcgJiBjYXRlZ29yeSkpCj4gKwlpZiAoIShkcm1fZGVidWcgJiBjYXRlZ29yeSkpCj4g IAkJcmV0dXJuOwo+ICAKPiAgCXZhX3N0YXJ0KGFyZ3MsIGZvcm1hdCk7Cj4gIAl2YWYuZm10ID0g Zm9ybWF0Owo+ICAJdmFmLnZhID0gJmFyZ3M7Cj4gIAo+IC0JcHJpbnRrKCIlcyIgIlsiIERSTV9O QU1FICI6JXBzXSVzICVwViIsCj4gLQkgICAgICAgbGV2ZWwsIF9fYnVpbHRpbl9yZXR1cm5fYWRk cmVzcygwKSwKPiAtCSAgICAgICBzdHJjbXAobGV2ZWwsIEtFUk5fRVJSKSA9PSAwID8gIiAqRVJS T1IqIiA6ICIiLCAmdmFmKTsKPiArCXByaW50ayhLRVJOX0RFQlVHICJbIiBEUk1fTkFNRSAiOiVw c10gJXBWIiwKPiArCSAgICAgICBfX2J1aWx0aW5fcmV0dXJuX2FkZHJlc3MoMCksICZ2YWYpOwo+ ICsKPiArCXZhX2VuZChhcmdzKTsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKGRybV9kYmcpOwo+ICsK PiArdm9pZCBkcm1fZXJyKGNvbnN0IGNoYXIgKmZvcm1hdCwgLi4uKQo+ICt7Cj4gKwlzdHJ1Y3Qg dmFfZm9ybWF0IHZhZjsKPiArCXZhX2xpc3QgYXJnczsKPiArCj4gKwl2YV9zdGFydChhcmdzLCBm b3JtYXQpOwo+ICsJdmFmLmZtdCA9IGZvcm1hdDsKPiArCXZhZi52YSA9ICZhcmdzOwo+ICsKPiAr CXByaW50ayhLRVJOX0VSUiAiWyIgRFJNX05BTUUgIjolcHNdICpFUlJPUiogJXBWIiwKPiArCSAg ICAgICBfX2J1aWx0aW5fcmV0dXJuX2FkZHJlc3MoMCksICZ2YWYpOwo+ICAKPiAgCXZhX2VuZChh cmdzKTsKPiAgfQo+IC1FWFBPUlRfU1lNQk9MKGRybV9wcmludGspOwo+ICtFWFBPUlRfU1lNQk9M KGRybV9lcnIpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAyOTMz YWQzODA5NGYuLmQ4ZTUyMmUzY2QzOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiBAQCAtMTEwNTksMjQgKzExMDU5LDE3IEBAIGludGVsX2NvbXBhcmVfbGlua19tX24o Y29uc3Qgc3RydWN0IGludGVsX2xpbmtfbV9uICptX24sCj4gIHN0YXRpYyB2b2lkIF9fcHJpbnRm KDMsIDQpCj4gIHBpcGVfY29uZmlnX2Vycihib29sIGFkanVzdCwgY29uc3QgY2hhciAqbmFtZSwg Y29uc3QgY2hhciAqZm9ybWF0LCAuLi4pCj4gIHsKPiAtCWNoYXIgKmxldmVsOwo+IC0JdW5zaWdu ZWQgaW50IGNhdGVnb3J5Owo+ICAJc3RydWN0IHZhX2Zvcm1hdCB2YWY7Cj4gIAl2YV9saXN0IGFy Z3M7Cj4gIAo+IC0JaWYgKGFkanVzdCkgewo+IC0JCWxldmVsID0gS0VSTl9ERUJVRzsKPiAtCQlj YXRlZ29yeSA9IERSTV9VVF9LTVM7Cj4gLQl9IGVsc2Ugewo+IC0JCWxldmVsID0gS0VSTl9FUlI7 Cj4gLQkJY2F0ZWdvcnkgPSBEUk1fVVRfTk9ORTsKPiAtCX0KPiAtCj4gIAl2YV9zdGFydChhcmdz LCBmb3JtYXQpOwo+ICAJdmFmLmZtdCA9IGZvcm1hdDsKPiAgCXZhZi52YSA9ICZhcmdzOwo+ICAK PiAtCWRybV9wcmludGsobGV2ZWwsIGNhdGVnb3J5LCAibWlzbWF0Y2ggaW4gJXMgJXBWIiwgbmFt ZSwgJnZhZik7Cj4gKwlpZiAoYWRqdXN0KQo+ICsJCWRybV9kYmcoRFJNX1VUX0tNUywgIm1pc21h dGNoIGluICVzICVwViIsIG5hbWUsICZ2YWYpOwo+ICsJZWxzZQo+ICsJCWRybV9lcnIoIm1pc21h dGNoIGluICVzICVwViIsIG5hbWUsICZ2YWYpOwo+ICAKPiAgCXZhX2VuZChhcmdzKTsKPiAgfQo+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fcHJpbnQuaCBiL2luY2x1ZGUvZHJtL2RybV9w cmludC5oCj4gaW5kZXggMmE0YTQyZTU5YTQ3Li4zYTQwYzVhM2E1ZmEgMTAwNjQ0Cj4gLS0tIGEv aW5jbHVkZS9kcm0vZHJtX3ByaW50LmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fcHJpbnQuaAo+ IEBAIC0yMDAsOSArMjAwLDEwIEBAIF9fcHJpbnRmKDYsIDcpCj4gIHZvaWQgZHJtX2Rldl9wcmlu dGsoY29uc3Qgc3RydWN0IGRldmljZSAqZGV2LCBjb25zdCBjaGFyICpsZXZlbCwKPiAgCQkgICAg dW5zaWduZWQgaW50IGNhdGVnb3J5LCBjb25zdCBjaGFyICpmdW5jdGlvbl9uYW1lLAo+ICAJCSAg ICBjb25zdCBjaGFyICpwcmVmaXgsIGNvbnN0IGNoYXIgKmZvcm1hdCwgLi4uKTsKPiAtX19wcmlu dGYoMywgNCkKPiAtdm9pZCBkcm1fcHJpbnRrKGNvbnN0IGNoYXIgKmxldmVsLCB1bnNpZ25lZCBp bnQgY2F0ZWdvcnksCj4gLQkJY29uc3QgY2hhciAqZm9ybWF0LCAuLi4pOwo+ICtfX3ByaW50Zigy LCAzKQo+ICt2b2lkIGRybV9kYmcodW5zaWduZWQgaW50IGNhdGVnb3J5LCBjb25zdCBjaGFyICpm b3JtYXQsIC4uLik7Cj4gK19fcHJpbnRmKDEsIDIpCj4gK3ZvaWQgZHJtX2Vycihjb25zdCBjaGFy ICpmb3JtYXQsIC4uLik7Cj4gIAo+ICAvKiBNYWNyb3MgdG8gbWFrZSBwcmludGsgZWFzaWVyICov Cj4gIAo+IEBAIC0yMzYsNyArMjM3LDcgQEAgdm9pZCBkcm1fcHJpbnRrKGNvbnN0IGNoYXIgKmxl dmVsLCB1bnNpZ25lZCBpbnQgY2F0ZWdvcnksCj4gIAlkcm1fZGV2X3ByaW50ayhkZXYsIEtFUk5f RVJSLCBEUk1fVVRfTk9ORSwgX19mdW5jX18sICIgKkVSUk9SKiIsXAo+ICAJCSAgICAgICBmbXQs ICMjX19WQV9BUkdTX18pCj4gICNkZWZpbmUgRFJNX0VSUk9SKGZtdCwgLi4uKQkJCQkJCVwKPiAt CWRybV9wcmludGsoS0VSTl9FUlIsIERSTV9VVF9OT05FLCBmbXQsCSMjX19WQV9BUkdTX18pCj4g Kwlkcm1fZXJyKGZtdCwgIyNfX1ZBX0FSR1NfXykKPiAgCj4gIC8qKgo+ICAgKiBSYXRlIGxpbWl0 ZWQgZXJyb3Igb3V0cHV0LiAgTGlrZSBEUk1fRVJST1IoKSBidXQgd29uJ3QgZmxvb2QgdGhlIGxv Zy4KPiBAQCAtMjc5LDQwICsyODAsNDAgQEAgdm9pZCBkcm1fcHJpbnRrKGNvbnN0IGNoYXIgKmxl dmVsLCB1bnNpZ25lZCBpbnQgY2F0ZWdvcnksCj4gIAlkcm1fZGV2X3ByaW50ayhkZXYsIEtFUk5f REVCVUcsIERSTV9VVF9DT1JFLCBfX2Z1bmNfXywgIiIsIGZtdCwJXAo+ICAJCSAgICAgICAjI2Fy Z3MpCj4gICNkZWZpbmUgRFJNX0RFQlVHKGZtdCwgLi4uKQkJCQkJCVwKPiAtCWRybV9wcmludGso S0VSTl9ERUJVRywgRFJNX1VUX0NPUkUsIGZtdCwgIyNfX1ZBX0FSR1NfXykKPiArCWRybV9kYmco RFJNX1VUX0NPUkUsIGZtdCwgIyNfX1ZBX0FSR1NfXykKPiAgCj4gICNkZWZpbmUgRFJNX0RFVl9E RUJVR19EUklWRVIoZGV2LCBmbXQsIGFyZ3MuLi4pCQkJCVwKPiAgCWRybV9kZXZfcHJpbnRrKGRl diwgS0VSTl9ERUJVRywgRFJNX1VUX0RSSVZFUiwgX19mdW5jX18sICIiLAlcCj4gIAkJICAgICAg IGZtdCwgIyNhcmdzKQo+ICAjZGVmaW5lIERSTV9ERUJVR19EUklWRVIoZm10LCAuLi4pCQkJCQlc Cj4gLQlkcm1fcHJpbnRrKEtFUk5fREVCVUcsIERSTV9VVF9EUklWRVIsIGZtdCwgIyNfX1ZBX0FS R1NfXykKPiArCWRybV9kYmcoRFJNX1VUX0RSSVZFUiwgZm10LCAjI19fVkFfQVJHU19fKQo+ICAK PiAgI2RlZmluZSBEUk1fREVWX0RFQlVHX0tNUyhkZXYsIGZtdCwgYXJncy4uLikJCQkJXAo+ICAJ ZHJtX2Rldl9wcmludGsoZGV2LCBLRVJOX0RFQlVHLCBEUk1fVVRfS01TLCBfX2Z1bmNfXywgIiIs IGZtdCwJXAo+ICAJCSAgICAgICAjI2FyZ3MpCj4gLSNkZWZpbmUgRFJNX0RFQlVHX0tNUyhmbXQs IC4uLikJCQkJCVwKPiAtCWRybV9wcmludGsoS0VSTl9ERUJVRywgRFJNX1VUX0tNUywgZm10LCAj I19fVkFfQVJHU19fKQo+ICsjZGVmaW5lIERSTV9ERUJVR19LTVMoZm10LCAuLi4pCQkJCQkJXAo+ ICsJZHJtX2RiZyhEUk1fVVRfS01TLCBmbXQsICMjX19WQV9BUkdTX18pCj4gIAo+ICAjZGVmaW5l IERSTV9ERVZfREVCVUdfUFJJTUUoZGV2LCBmbXQsIGFyZ3MuLi4pCQkJCVwKPiAgCWRybV9kZXZf cHJpbnRrKGRldiwgS0VSTl9ERUJVRywgRFJNX1VUX1BSSU1FLCBfX2Z1bmNfXywgIiIsCVwKPiAg CQkgICAgICAgZm10LCAjI2FyZ3MpCj4gICNkZWZpbmUgRFJNX0RFQlVHX1BSSU1FKGZtdCwgLi4u KQkJCQkJXAo+IC0JZHJtX3ByaW50ayhLRVJOX0RFQlVHLCBEUk1fVVRfUFJJTUUsIGZtdCwgIyNf X1ZBX0FSR1NfXykKPiArCWRybV9kYmcoRFJNX1VUX1BSSU1FLCBmbXQsICMjX19WQV9BUkdTX18p Cj4gIAo+ICAjZGVmaW5lIERSTV9ERVZfREVCVUdfQVRPTUlDKGRldiwgZm10LCBhcmdzLi4uKQkJ CQlcCj4gIAlkcm1fZGV2X3ByaW50ayhkZXYsIEtFUk5fREVCVUcsIERSTV9VVF9BVE9NSUMsIF9f ZnVuY19fLCAiIiwJXAo+ICAJCSAgICAgICBmbXQsICMjYXJncykKPiAgI2RlZmluZSBEUk1fREVC VUdfQVRPTUlDKGZtdCwgLi4uKQkJCQkJXAo+IC0JZHJtX3ByaW50ayhLRVJOX0RFQlVHLCBEUk1f VVRfQVRPTUlDLCBmbXQsICMjX19WQV9BUkdTX18pCj4gKwlkcm1fZGJnKERSTV9VVF9BVE9NSUMs IGZtdCwgIyNfX1ZBX0FSR1NfXykKPiAgCj4gICNkZWZpbmUgRFJNX0RFVl9ERUJVR19WQkwoZGV2 LCBmbXQsIGFyZ3MuLi4pCQkJCVwKPiAgCWRybV9kZXZfcHJpbnRrKGRldiwgS0VSTl9ERUJVRywg RFJNX1VUX1ZCTCwgX19mdW5jX18sICIiLCBmbXQsCVwKPiAgCQkgICAgICAgIyNhcmdzKQo+IC0j ZGVmaW5lIERSTV9ERUJVR19WQkwoZm10LCAuLi4pCQkJCQlcCj4gLQlkcm1fcHJpbnRrKEtFUk5f REVCVUcsIERSTV9VVF9WQkwsIGZtdCwgIyNfX1ZBX0FSR1NfXykKPiArI2RlZmluZSBEUk1fREVC VUdfVkJMKGZtdCwgLi4uKQkJCQkJCVwKPiArCWRybV9kYmcoRFJNX1VUX1ZCTCwgZm10LCAjI19f VkFfQVJHU19fKQo+ICAKPiAgI2RlZmluZSBEUk1fREVCVUdfTEVBU0UoZm10LCAuLi4pCQkJCQlc Cj4gLQlkcm1fcHJpbnRrKEtFUk5fREVCVUcsIERSTV9VVF9MRUFTRSwgZm10LCAjI19fVkFfQVJH U19fKQo+ICsJZHJtX2RiZyhEUk1fVVRfTEVBU0UsIGZtdCwgIyNfX1ZBX0FSR1NfXykKPiAgCj4g ICNkZWZpbmUgX0RSTV9ERVZfREVGSU5FX0RFQlVHX1JBVEVMSU1JVEVEKGRldiwgbGV2ZWwsIGZt dCwgYXJncy4uLikJXAo+ICAoewkJCQkJCQkJCVwKPiAtLSAKPiAyLjE1LjAKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbeCONad (ORCPT ); Thu, 15 Mar 2018 09:30:33 -0400 Received: from mga17.intel.com ([192.55.52.151]:42446 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbeCONab (ORCPT ); Thu, 15 Mar 2018 09:30:31 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,310,1517904000"; d="scan'208";a="24304478" Date: Thu, 15 Mar 2018 15:30:26 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Joe Perches Cc: Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Message-ID: <20180315133026.GR5453@intel.com> References: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > arguments that can be removed by creating separate functins. > > Create specific functions for these calls to reduce x86/64 defconfig > size by ~20k. > > Modify the existing macros to use the specific calls. > > new: > $ size -t drivers/gpu/drm/built-in.a | tail -1 > 1876562 44542 995 1922099 1d5433 (TOTALS) > > old: > $ size -t drivers/gpu/drm/built-in.a | tail -1 > 1897565 44542 995 1943102 1da63e (TOTALS) > > Miscellanea: > > o intel_display requires a change to use the specific calls. How much would we lose if we move the (drm_debug&FOO) outside the functions again? I'm somewhat concerned about all the function call overhead when debugs aren't even enabled. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/drm_print.c | 28 +++++++++++++++++++++------- > drivers/gpu/drm/i915/intel_display.c | 15 ++++----------- > include/drm/drm_print.h | 27 ++++++++++++++------------- > 3 files changed, 39 insertions(+), 31 deletions(-) > > diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c > index 781518fd88e3..79abf6d5b4db 100644 > --- a/drivers/gpu/drm/drm_print.c > +++ b/drivers/gpu/drm/drm_print.c > @@ -89,23 +89,37 @@ void drm_dev_printk(const struct device *dev, const char *level, > } > EXPORT_SYMBOL(drm_dev_printk); > > -void drm_printk(const char *level, unsigned int category, > - const char *format, ...) > +void drm_dbg(unsigned int category, const char *format, ...) > { > struct va_format vaf; > va_list args; > > - if (category != DRM_UT_NONE && !(drm_debug & category)) > + if (!(drm_debug & category)) > return; > > va_start(args, format); > vaf.fmt = format; > vaf.va = &args; > > - printk("%s" "[" DRM_NAME ":%ps]%s %pV", > - level, __builtin_return_address(0), > - strcmp(level, KERN_ERR) == 0 ? " *ERROR*" : "", &vaf); > + printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV", > + __builtin_return_address(0), &vaf); > + > + va_end(args); > +} > +EXPORT_SYMBOL(drm_dbg); > + > +void drm_err(const char *format, ...) > +{ > + struct va_format vaf; > + va_list args; > + > + va_start(args, format); > + vaf.fmt = format; > + vaf.va = &args; > + > + printk(KERN_ERR "[" DRM_NAME ":%ps] *ERROR* %pV", > + __builtin_return_address(0), &vaf); > > va_end(args); > } > -EXPORT_SYMBOL(drm_printk); > +EXPORT_SYMBOL(drm_err); > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 2933ad38094f..d8e522e3cd39 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -11059,24 +11059,17 @@ intel_compare_link_m_n(const struct intel_link_m_n *m_n, > static void __printf(3, 4) > pipe_config_err(bool adjust, const char *name, const char *format, ...) > { > - char *level; > - unsigned int category; > struct va_format vaf; > va_list args; > > - if (adjust) { > - level = KERN_DEBUG; > - category = DRM_UT_KMS; > - } else { > - level = KERN_ERR; > - category = DRM_UT_NONE; > - } > - > va_start(args, format); > vaf.fmt = format; > vaf.va = &args; > > - drm_printk(level, category, "mismatch in %s %pV", name, &vaf); > + if (adjust) > + drm_dbg(DRM_UT_KMS, "mismatch in %s %pV", name, &vaf); > + else > + drm_err("mismatch in %s %pV", name, &vaf); > > va_end(args); > } > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index 2a4a42e59a47..3a40c5a3a5fa 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -200,9 +200,10 @@ __printf(6, 7) > void drm_dev_printk(const struct device *dev, const char *level, > unsigned int category, const char *function_name, > const char *prefix, const char *format, ...); > -__printf(3, 4) > -void drm_printk(const char *level, unsigned int category, > - const char *format, ...); > +__printf(2, 3) > +void drm_dbg(unsigned int category, const char *format, ...); > +__printf(1, 2) > +void drm_err(const char *format, ...); > > /* Macros to make printk easier */ > > @@ -236,7 +237,7 @@ void drm_printk(const char *level, unsigned int category, > drm_dev_printk(dev, KERN_ERR, DRM_UT_NONE, __func__, " *ERROR*",\ > fmt, ##__VA_ARGS__) > #define DRM_ERROR(fmt, ...) \ > - drm_printk(KERN_ERR, DRM_UT_NONE, fmt, ##__VA_ARGS__) > + drm_err(fmt, ##__VA_ARGS__) > > /** > * Rate limited error output. Like DRM_ERROR() but won't flood the log. > @@ -279,40 +280,40 @@ void drm_printk(const char *level, unsigned int category, > drm_dev_printk(dev, KERN_DEBUG, DRM_UT_CORE, __func__, "", fmt, \ > ##args) > #define DRM_DEBUG(fmt, ...) \ > - drm_printk(KERN_DEBUG, DRM_UT_CORE, fmt, ##__VA_ARGS__) > + drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__) > > #define DRM_DEV_DEBUG_DRIVER(dev, fmt, args...) \ > drm_dev_printk(dev, KERN_DEBUG, DRM_UT_DRIVER, __func__, "", \ > fmt, ##args) > #define DRM_DEBUG_DRIVER(fmt, ...) \ > - drm_printk(KERN_DEBUG, DRM_UT_DRIVER, fmt, ##__VA_ARGS__) > + drm_dbg(DRM_UT_DRIVER, fmt, ##__VA_ARGS__) > > #define DRM_DEV_DEBUG_KMS(dev, fmt, args...) \ > drm_dev_printk(dev, KERN_DEBUG, DRM_UT_KMS, __func__, "", fmt, \ > ##args) > -#define DRM_DEBUG_KMS(fmt, ...) \ > - drm_printk(KERN_DEBUG, DRM_UT_KMS, fmt, ##__VA_ARGS__) > +#define DRM_DEBUG_KMS(fmt, ...) \ > + drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__) > > #define DRM_DEV_DEBUG_PRIME(dev, fmt, args...) \ > drm_dev_printk(dev, KERN_DEBUG, DRM_UT_PRIME, __func__, "", \ > fmt, ##args) > #define DRM_DEBUG_PRIME(fmt, ...) \ > - drm_printk(KERN_DEBUG, DRM_UT_PRIME, fmt, ##__VA_ARGS__) > + drm_dbg(DRM_UT_PRIME, fmt, ##__VA_ARGS__) > > #define DRM_DEV_DEBUG_ATOMIC(dev, fmt, args...) \ > drm_dev_printk(dev, KERN_DEBUG, DRM_UT_ATOMIC, __func__, "", \ > fmt, ##args) > #define DRM_DEBUG_ATOMIC(fmt, ...) \ > - drm_printk(KERN_DEBUG, DRM_UT_ATOMIC, fmt, ##__VA_ARGS__) > + drm_dbg(DRM_UT_ATOMIC, fmt, ##__VA_ARGS__) > > #define DRM_DEV_DEBUG_VBL(dev, fmt, args...) \ > drm_dev_printk(dev, KERN_DEBUG, DRM_UT_VBL, __func__, "", fmt, \ > ##args) > -#define DRM_DEBUG_VBL(fmt, ...) \ > - drm_printk(KERN_DEBUG, DRM_UT_VBL, fmt, ##__VA_ARGS__) > +#define DRM_DEBUG_VBL(fmt, ...) \ > + drm_dbg(DRM_UT_VBL, fmt, ##__VA_ARGS__) > > #define DRM_DEBUG_LEASE(fmt, ...) \ > - drm_printk(KERN_DEBUG, DRM_UT_LEASE, fmt, ##__VA_ARGS__) > + drm_dbg(DRM_UT_LEASE, fmt, ##__VA_ARGS__) > > #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, level, fmt, args...) \ > ({ \ > -- > 2.15.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC