From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 03/14] x86: use dma-direct Date: Thu, 15 Mar 2018 14:40:28 +0100 Message-ID: <20180315134028.GA18074@lst.de> References: <20180314175213.20256-1-hch@lst.de> <20180314175213.20256-4-hch@lst.de> <20180315115348.GA16210@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Thomas Gleixner Cc: Tom Lendacky , Konrad Rzeszutek Wilk , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Muli Ben-Yehuda , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, David Woodhouse , Christoph Hellwig List-Id: iommu@lists.linux-foundation.org On Thu, Mar 15, 2018 at 01:53:52PM +0100, Thomas Gleixner wrote: > > > > The generic dma-direct implementation is now functionally equivalent to > > > > the x86 nommu dma_map implementation, so switch over to using it. > > > > > > Can you please convert the various drivers first and then remove the > > > unused code? > > > > Which various drivers? > > > > > > Note that the various iommu drivers are switched from x86_dma_supported > > The various iommu drivers .... It doesn't really make any sense to switch them separately. They've inherited the ops from x86 which used to override it on an arch level, and we've now generalized the exactly same implementation to common code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbeCONkb (ORCPT ); Thu, 15 Mar 2018 09:40:31 -0400 Received: from verein.lst.de ([213.95.11.211]:41205 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbeCONk3 (ORCPT ); Thu, 15 Mar 2018 09:40:29 -0400 Date: Thu, 15 Mar 2018 14:40:28 +0100 From: Christoph Hellwig To: Thomas Gleixner Cc: Christoph Hellwig , x86@kernel.org, Konrad Rzeszutek Wilk , Tom Lendacky , David Woodhouse , Muli Ben-Yehuda , Jon Mason , Joerg Roedel , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/14] x86: use dma-direct Message-ID: <20180315134028.GA18074@lst.de> References: <20180314175213.20256-1-hch@lst.de> <20180314175213.20256-4-hch@lst.de> <20180315115348.GA16210@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 01:53:52PM +0100, Thomas Gleixner wrote: > > > > The generic dma-direct implementation is now functionally equivalent to > > > > the x86 nommu dma_map implementation, so switch over to using it. > > > > > > Can you please convert the various drivers first and then remove the > > > unused code? > > > > Which various drivers? > > > > > > Note that the various iommu drivers are switched from x86_dma_supported > > The various iommu drivers .... It doesn't really make any sense to switch them separately. They've inherited the ops from x86 which used to override it on an arch level, and we've now generalized the exactly same implementation to common code.