From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Date: Thu, 15 Mar 2018 17:37:34 +0200 Message-ID: <20180315153734.GT5453@intel.com> References: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> <20180315133026.GR5453@intel.com> <1b50f5d8-97a6-2442-34bb-2782c35505fd@linux.intel.com> <20180315150524.GS5453@intel.com> <1521127073.22221.13.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1521127073.22221.13.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joe Perches Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMTUsIDIwMTggYXQgMDg6MTc6NTNBTSAtMDcwMCwgSm9lIFBlcmNoZXMgd3Jv dGU6Cj4gT24gVGh1LCAyMDE4LTAzLTE1IGF0IDE3OjA1ICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qg d3JvdGU6Cj4gPiBPbiBUaHUsIE1hciAxNSwgMjAxOCBhdCAwMzowNDo1MlBNICswMTAwLCBNYWFy dGVuIExhbmtob3JzdCB3cm90ZToKPiA+ID4gT3AgMTUtMDMtMTggb20gMTQ6MzAgc2NocmVlZiBW aWxsZSBTeXJqw6Rsw6Q6Cj4gPiA+ID4gT24gVHVlLCBNYXIgMTMsIDIwMTggYXQgMDM6MDI6MTVQ TSAtMDcwMCwgSm9lIFBlcmNoZXMgd3JvdGU6Cj4gPiA+ID4gPiBkcm1fcHJpbnRrIGlzIHVzZWQg Zm9yIGJvdGggRFJNX0VSUk9SIGFuZCBEUk1fREVCVUcgd2l0aCB1bm5lY2Vzc2FyeQo+ID4gPiA+ ID4gYXJndW1lbnRzIHRoYXQgY2FuIGJlIHJlbW92ZWQgYnkgY3JlYXRpbmcgc2VwYXJhdGUgZnVu Y3RpbnMuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IENyZWF0ZSBzcGVjaWZpYyBmdW5jdGlvbnMgZm9y IHRoZXNlIGNhbGxzIHRvIHJlZHVjZSB4ODYvNjQgZGVmY29uZmlnCj4gPiA+ID4gPiBzaXplIGJ5 IH4yMGsuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IE1vZGlmeSB0aGUgZXhpc3RpbmcgbWFjcm9zIHRv IHVzZSB0aGUgc3BlY2lmaWMgY2FsbHMuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IG5ldzoKPiA+ID4g PiA+ICQgc2l6ZSAtdCBkcml2ZXJzL2dwdS9kcm0vYnVpbHQtaW4uYSB8IHRhaWwgLTEKPiA+ID4g PiA+IDE4NzY1NjIJICA0NDU0MgkgICAgOTk1CTE5MjIwOTkJIDFkNTQzMwkoVE9UQUxTKQo+ID4g PiA+ID4gCj4gPiA+ID4gPiBvbGQ6Cj4gPiA+ID4gPiAkIHNpemUgLXQgZHJpdmVycy9ncHUvZHJt L2J1aWx0LWluLmEgfCB0YWlsIC0xCj4gPiA+ID4gPiAxODk3NTY1CSAgNDQ1NDIJICAgIDk5NQkx OTQzMTAyCSAxZGE2M2UJKFRPVEFMUykKPiA+ID4gPiA+IAo+ID4gPiA+ID4gTWlzY2VsbGFuZWE6 Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IG8gaW50ZWxfZGlzcGxheSByZXF1aXJlcyBhIGNoYW5nZSB0 byB1c2UgdGhlIHNwZWNpZmljIGNhbGxzLgo+ID4gPiA+IAo+ID4gPiA+IEhvdyBtdWNoIHdvdWxk IHdlIGxvc2UgaWYgd2UgbW92ZSB0aGUgKGRybV9kZWJ1ZyZGT08pIG91dHNpZGUgdGhlCj4gPiA+ ID4gZnVuY3Rpb25zIGFnYWluPwo+IAo+IGFnYWluPwoKV2UgdXNlZCB0byBkbyB0aGF0LiBTb21l b25lIGNoYW5nZWQgaXQgYSB3aGlsZSBiYWNrLCB1bmludGVudGlhbGx5CkkgYmVsaWV2ZS4KCj4g Cj4gPiA+ID4gIEknbSBzb21ld2hhdCBjb25jZXJuZWQgYWJvdXQgYWxsIHRoZSBmdW5jdGlvbiBj YWxsCj4gPiA+ID4gb3ZlcmhlYWQgd2hlbiBkZWJ1Z3MgYXJlbid0IGV2ZW4gZW5hYmxlZC4KPiAK PiBQZXJoYXBzIGJldHRlciB0byBoYXZlIGNvbXBpbGF0aW9uIGVsaW1pbmF0aW9uCj4gb2YgdGhl IGVudGlyZSBkZWJ1ZyBvdXRwdXQgaW5zdGVhZC4KClRoYXQgd291bGQgcmVxdWlyZSBldmVyeSBi dWcgcmVwb3J0ZXIgdG8gcmVjb21waWxlIHRoZSBrZXJuZWwgZmlyc3QuClNvIHRoaXMgaXMgbm90 IGEgc29sdXRpb24gd2Ugd291bGQgZXZlciBzZXJpb3VzbHkgY29uc2lkZXIuCgpOb3Qgc3VyZSBp ZiBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byB1c2UgdGhlIGFsdGVybmF0aXZlcyB0aGluZyB0bwpl bGltaW5hdGUgdGhlIGZ1bmN0aW9uIGNhbGxzIHVubGVzcyB0aGUgdXNlciBib290cyB3aWggZHJt LmRlYnVnIT0wPwoKPiAKPiBJIHRoaW5rIHlvdSBhcmUgZGlzY3Vzc2luZyBhIGRpZmZlcmVudCBp c3N1ZSBhbmQKPiB0aGlzIGRpc2N1c3Npb24gc2hvdWxkIG5vdCBibG9jayB0aGlzIHBhdGNoIGFz Cj4gdGhpcyBwYXRjaCBoYXMgbm8gaW1wYWN0IG90aGVyIHRoYW4gY29kZSBzaXplCj4gcmVkdWN0 aW9uLgoKQnV0IHdoYXQgaXMgdGhlIGdvYWwgb2YgdGhlIGNvZGUgc2l6ZSByZWR1Y3Rpb24/IEkg YXNzdW1lIHRoZSBtYWluCmdvYWwgaXMgdG8gbWFrZSBiZXR0ZXIgdXNlIG9mIHRoZSBpbnN0cnVj dGlvbiBjYWNoZSB0byBtYWtlIHRoZQpjb2RlIGZhc3Rlci4gSWYgdGhlcmUncyBhIHRyYWRlb2Zm IGJldHdlZW4gc21hbGxlciBhbmQgc2xpZ2h0bHkKZmFzdGVyIHZzLiBsYXJnZXIgYW5kIGEgc2lu Z2lmaWNhbnRseSBmYXN0ZXIgSSB0ZW5kIHRvIHRoaW5rIHdlCnNob3VsZCBnbyBmb3IgdGhlIGxh dHRlciBvcHRpb24uCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932577AbeCOPlf (ORCPT ); Thu, 15 Mar 2018 11:41:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:36825 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751918AbeCOPlb (ORCPT ); Thu, 15 Mar 2018 11:41:31 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,311,1517904000"; d="scan'208";a="25540547" Date: Thu, 15 Mar 2018 17:37:34 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Joe Perches Cc: Maarten Lankhorst , Gustavo Padovan , Sean Paul , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Message-ID: <20180315153734.GT5453@intel.com> References: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> <20180315133026.GR5453@intel.com> <1b50f5d8-97a6-2442-34bb-2782c35505fd@linux.intel.com> <20180315150524.GS5453@intel.com> <1521127073.22221.13.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1521127073.22221.13.camel@perches.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 08:17:53AM -0700, Joe Perches wrote: > On Thu, 2018-03-15 at 17:05 +0200, Ville Syrjälä wrote: > > On Thu, Mar 15, 2018 at 03:04:52PM +0100, Maarten Lankhorst wrote: > > > Op 15-03-18 om 14:30 schreef Ville Syrjälä: > > > > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > > > > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > > > > > arguments that can be removed by creating separate functins. > > > > > > > > > > Create specific functions for these calls to reduce x86/64 defconfig > > > > > size by ~20k. > > > > > > > > > > Modify the existing macros to use the specific calls. > > > > > > > > > > new: > > > > > $ size -t drivers/gpu/drm/built-in.a | tail -1 > > > > > 1876562 44542 995 1922099 1d5433 (TOTALS) > > > > > > > > > > old: > > > > > $ size -t drivers/gpu/drm/built-in.a | tail -1 > > > > > 1897565 44542 995 1943102 1da63e (TOTALS) > > > > > > > > > > Miscellanea: > > > > > > > > > > o intel_display requires a change to use the specific calls. > > > > > > > > How much would we lose if we move the (drm_debug&FOO) outside the > > > > functions again? > > again? We used to do that. Someone changed it a while back, unintentially I believe. > > > > > I'm somewhat concerned about all the function call > > > > overhead when debugs aren't even enabled. > > Perhaps better to have compilation elimination > of the entire debug output instead. That would require every bug reporter to recompile the kernel first. So this is not a solution we would ever seriously consider. Not sure if it would be possible to use the alternatives thing to eliminate the function calls unless the user boots wih drm.debug!=0? > > I think you are discussing a different issue and > this discussion should not block this patch as > this patch has no impact other than code size > reduction. But what is the goal of the code size reduction? I assume the main goal is to make better use of the instruction cache to make the code faster. If there's a tradeoff between smaller and slightly faster vs. larger and a singificantly faster I tend to think we should go for the latter option. -- Ville Syrjälä Intel OTC