From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Date: Thu, 15 Mar 2018 18:14:34 +0200 Message-ID: <20180315161434.GV5453@intel.com> References: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> <20180315133026.GR5453@intel.com> <1b50f5d8-97a6-2442-34bb-2782c35505fd@linux.intel.com> <20180315150524.GS5453@intel.com> <1521127073.22221.13.camel@perches.com> <20180315153734.GT5453@intel.com> <1521128645.22221.18.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1521128645.22221.18.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joe Perches Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMTUsIDIwMTggYXQgMDg6NDQ6MDVBTSAtMDcwMCwgSm9lIFBlcmNoZXMgd3Jv dGU6Cj4gT24gVGh1LCAyMDE4LTAzLTE1IGF0IDE3OjM3ICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qg d3JvdGU6Cj4gPiBPbiBUaHUsIE1hciAxNSwgMjAxOCBhdCAwODoxNzo1M0FNIC0wNzAwLCBKb2Ug UGVyY2hlcyB3cm90ZToKPiA+ID4gT24gVGh1LCAyMDE4LTAzLTE1IGF0IDE3OjA1ICswMjAwLCBW aWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+ID4gT24gVGh1LCBNYXIgMTUsIDIwMTggYXQgMDM6 MDQ6NTJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPiA+ID4gPiBPcCAxNS0w My0xOCBvbSAxNDozMCBzY2hyZWVmIFZpbGxlIFN5cmrDpGzDpDoKPiA+ID4gPiA+ID4gT24gVHVl LCBNYXIgMTMsIDIwMTggYXQgMDM6MDI6MTVQTSAtMDcwMCwgSm9lIFBlcmNoZXMgd3JvdGU6Cj4g PiA+ID4gPiA+ID4gZHJtX3ByaW50ayBpcyB1c2VkIGZvciBib3RoIERSTV9FUlJPUiBhbmQgRFJN X0RFQlVHIHdpdGggdW5uZWNlc3NhcnkKPiA+ID4gPiA+ID4gPiBhcmd1bWVudHMgdGhhdCBjYW4g YmUgcmVtb3ZlZCBieSBjcmVhdGluZyBzZXBhcmF0ZSBmdW5jdGlucy4KPiA+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gPiBDcmVhdGUgc3BlY2lmaWMgZnVuY3Rpb25zIGZvciB0aGVzZSBjYWxscyB0 byByZWR1Y2UgeDg2LzY0IGRlZmNvbmZpZwo+ID4gPiA+ID4gPiA+IHNpemUgYnkgfjIway4KPiA+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBNb2RpZnkgdGhlIGV4aXN0aW5nIG1hY3JvcyB0byB1 c2UgdGhlIHNwZWNpZmljIGNhbGxzLgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IG5ldzoK PiA+ID4gPiA+ID4gPiAkIHNpemUgLXQgZHJpdmVycy9ncHUvZHJtL2J1aWx0LWluLmEgfCB0YWls IC0xCj4gPiA+ID4gPiA+ID4gMTg3NjU2MgkgIDQ0NTQyCSAgICA5OTUJMTkyMjA5OQkgMWQ1NDMz CShUT1RBTFMpCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gb2xkOgo+ID4gPiA+ID4gPiA+ ICQgc2l6ZSAtdCBkcml2ZXJzL2dwdS9kcm0vYnVpbHQtaW4uYSB8IHRhaWwgLTEKPiA+ID4gPiA+ ID4gPiAxODk3NTY1CSAgNDQ1NDIJICAgIDk5NQkxOTQzMTAyCSAxZGE2M2UJKFRPVEFMUykKPiA+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBNaXNjZWxsYW5lYToKPiA+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gPiBvIGludGVsX2Rpc3BsYXkgcmVxdWlyZXMgYSBjaGFuZ2UgdG8gdXNlIHRoZSBz cGVjaWZpYyBjYWxscy4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IEhvdyBtdWNoIHdvdWxkIHdl IGxvc2UgaWYgd2UgbW92ZSB0aGUgKGRybV9kZWJ1ZyZGT08pIG91dHNpZGUgdGhlCj4gPiA+ID4g PiA+IGZ1bmN0aW9ucyBhZ2Fpbj8KPiA+ID4gCj4gPiA+IGFnYWluPwo+ID4gCj4gPiBXZSB1c2Vk IHRvIGRvIHRoYXQuIFNvbWVvbmUgY2hhbmdlZCBpdCBhIHdoaWxlIGJhY2ssIHVuaW50ZW50aWFs bHkKPiA+IEkgYmVsaWV2ZS4KPiA+IAo+ID4gPiAKPiA+ID4gPiA+ID4gIEknbSBzb21ld2hhdCBj b25jZXJuZWQgYWJvdXQgYWxsIHRoZSBmdW5jdGlvbiBjYWxsCj4gPiA+ID4gPiA+IG92ZXJoZWFk IHdoZW4gZGVidWdzIGFyZW4ndCBldmVuIGVuYWJsZWQuCj4gPiA+IAo+ID4gPiBQZXJoYXBzIGJl dHRlciB0byBoYXZlIGNvbXBpbGF0aW9uIGVsaW1pbmF0aW9uCj4gPiA+IG9mIHRoZSBlbnRpcmUg ZGVidWcgb3V0cHV0IGluc3RlYWQuCj4gPiAKPiA+IFRoYXQgd291bGQgcmVxdWlyZSBldmVyeSBi dWcgcmVwb3J0ZXIgdG8gcmVjb21waWxlIHRoZSBrZXJuZWwgZmlyc3QuCj4gPiBTbyB0aGlzIGlz IG5vdCBhIHNvbHV0aW9uIHdlIHdvdWxkIGV2ZXIgc2VyaW91c2x5IGNvbnNpZGVyLgo+ID4gCj4g PiBOb3Qgc3VyZSBpZiBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byB1c2UgdGhlIGFsdGVybmF0aXZl cyB0aGluZyB0bwo+ID4gZWxpbWluYXRlIHRoZSBmdW5jdGlvbiBjYWxscyB1bmxlc3MgdGhlIHVz ZXIgYm9vdHMgd2loIGRybS5kZWJ1ZyE9MD8KPiA+IAo+ID4gPiAKPiA+ID4gSSB0aGluayB5b3Ug YXJlIGRpc2N1c3NpbmcgYSBkaWZmZXJlbnQgaXNzdWUgYW5kCj4gPiA+IHRoaXMgZGlzY3Vzc2lv biBzaG91bGQgbm90IGJsb2NrIHRoaXMgcGF0Y2ggYXMKPiA+ID4gdGhpcyBwYXRjaCBoYXMgbm8g aW1wYWN0IG90aGVyIHRoYW4gY29kZSBzaXplCj4gPiA+IHJlZHVjdGlvbi4KPiA+IAo+ID4gQnV0 IHdoYXQgaXMgdGhlIGdvYWwgb2YgdGhlIGNvZGUgc2l6ZSByZWR1Y3Rpb24/Cj4gCj4gU21hbGxl ciBjb2RlLgo+IAo+ID4gSSBhc3N1bWUgdGhlIG1haW4KPiA+IGdvYWwgaXMgdG8gbWFrZSBiZXR0 ZXIgdXNlIG9mIHRoZSBpbnN0cnVjdGlvbiBjYWNoZSB0byBtYWtlIHRoZQo+ID4gY29kZSBmYXN0 ZXIuIElmIHRoZXJlJ3MgYSB0cmFkZW9mZiBiZXR3ZWVuIHNtYWxsZXIgYW5kIHNsaWdodGx5Cj4g PiBmYXN0ZXIgdnMuIGxhcmdlciBhbmQgYSBzaW5naWZpY2FudGx5IGZhc3RlciBJIHRlbmQgdG8g dGhpbmsgd2UKPiA+IHNob3VsZCBnbyBmb3IgdGhlIGxhdHRlciBvcHRpb24uCj4gCj4gVGhlcmUn cyBubyB0cmFkZS1vZmYgaW4gdGhpcyBwYXRjaCBmb3IgZmFzdGVyL2xhcmdlci4KPiBUaGlzIHBh dGNoIGlzIHNpbXBseSBzbWFsbGVyLiAgU21hbGxlciBpcyBiZXR0ZXIuCgpUaGlzIGZlZWxzIGEg Yml0IGxpa2Ugc2F5aW5nIHBpbmsgaXMgYmV0dGVyIHRoYW4gcmVkIGJlY2F1c2UgaXQncwptb3Jl IHBpbmsuCgpUaGF0IHNhaWQsIEknbSBub3QgYXJndWluZyBhZ2FpbnN0IHRoaXMgcGF0Y2ggYXMg c3VjaC4gTWFraW5nIHRoaW5ncwpzbWFsbGVyICJqdXN0IGJlY2F1c2UiIHVzdWFsbHkgZG9lc24n dCBjYXVzZSBwcm9ibGVtcy4gQnV0IEkgd2FzCmhvcGluZyB0aGF0IHdlIG1pZ2h0IGJlIGFmdGVy IHNvbWUgbW9yZSB0YW5naWJsZSBnYWlucyBoZXJlLCBhbmQKdGh1cyBwb2ludGVkIG91dCB0aGF0 IHRoZXJlIG1heSBiZSBhIGJldHRlciB3YXkgdG8gYWNoaWV2ZSBldmVuCmJpZ2dlciBnYWlucy4K Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbeCOQOl (ORCPT ); Thu, 15 Mar 2018 12:14:41 -0400 Received: from mga04.intel.com ([192.55.52.120]:22844 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbeCOQOj (ORCPT ); Thu, 15 Mar 2018 12:14:39 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,311,1517904000"; d="scan'208";a="39195950" Date: Thu, 15 Mar 2018 18:14:34 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Joe Perches Cc: Maarten Lankhorst , Gustavo Padovan , Sean Paul , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses Message-ID: <20180315161434.GV5453@intel.com> References: <016b5cb84cede20fd0f91ed6965421d99fd5f2ce.1520978414.git.joe@perches.com> <20180315133026.GR5453@intel.com> <1b50f5d8-97a6-2442-34bb-2782c35505fd@linux.intel.com> <20180315150524.GS5453@intel.com> <1521127073.22221.13.camel@perches.com> <20180315153734.GT5453@intel.com> <1521128645.22221.18.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1521128645.22221.18.camel@perches.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 08:44:05AM -0700, Joe Perches wrote: > On Thu, 2018-03-15 at 17:37 +0200, Ville Syrjälä wrote: > > On Thu, Mar 15, 2018 at 08:17:53AM -0700, Joe Perches wrote: > > > On Thu, 2018-03-15 at 17:05 +0200, Ville Syrjälä wrote: > > > > On Thu, Mar 15, 2018 at 03:04:52PM +0100, Maarten Lankhorst wrote: > > > > > Op 15-03-18 om 14:30 schreef Ville Syrjälä: > > > > > > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > > > > > > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > > > > > > > arguments that can be removed by creating separate functins. > > > > > > > > > > > > > > Create specific functions for these calls to reduce x86/64 defconfig > > > > > > > size by ~20k. > > > > > > > > > > > > > > Modify the existing macros to use the specific calls. > > > > > > > > > > > > > > new: > > > > > > > $ size -t drivers/gpu/drm/built-in.a | tail -1 > > > > > > > 1876562 44542 995 1922099 1d5433 (TOTALS) > > > > > > > > > > > > > > old: > > > > > > > $ size -t drivers/gpu/drm/built-in.a | tail -1 > > > > > > > 1897565 44542 995 1943102 1da63e (TOTALS) > > > > > > > > > > > > > > Miscellanea: > > > > > > > > > > > > > > o intel_display requires a change to use the specific calls. > > > > > > > > > > > > How much would we lose if we move the (drm_debug&FOO) outside the > > > > > > functions again? > > > > > > again? > > > > We used to do that. Someone changed it a while back, unintentially > > I believe. > > > > > > > > > > > I'm somewhat concerned about all the function call > > > > > > overhead when debugs aren't even enabled. > > > > > > Perhaps better to have compilation elimination > > > of the entire debug output instead. > > > > That would require every bug reporter to recompile the kernel first. > > So this is not a solution we would ever seriously consider. > > > > Not sure if it would be possible to use the alternatives thing to > > eliminate the function calls unless the user boots wih drm.debug!=0? > > > > > > > > I think you are discussing a different issue and > > > this discussion should not block this patch as > > > this patch has no impact other than code size > > > reduction. > > > > But what is the goal of the code size reduction? > > Smaller code. > > > I assume the main > > goal is to make better use of the instruction cache to make the > > code faster. If there's a tradeoff between smaller and slightly > > faster vs. larger and a singificantly faster I tend to think we > > should go for the latter option. > > There's no trade-off in this patch for faster/larger. > This patch is simply smaller. Smaller is better. This feels a bit like saying pink is better than red because it's more pink. That said, I'm not arguing against this patch as such. Making things smaller "just because" usually doesn't cause problems. But I was hoping that we might be after some more tangible gains here, and thus pointed out that there may be a better way to achieve even bigger gains. -- Ville Syrjälä Intel OTC