From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Manikanta Maddireddy <mmaddireddy@nvidia.com>,
Stephen Warren <swarren@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: mark PM functions as __maybe_unused
Date: Thu, 15 Mar 2018 17:49:27 +0100 [thread overview]
Message-ID: <20180315164927.GA31871@ulmo> (raw)
In-Reply-To: <20180315161901.772729-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Thu, Mar 15, 2018 at 05:18:39PM +0100, Arnd Bergmann wrote:
> The new PM support causes a warning when CONFIG_PM is disabled:
>
> drivers/pci/host/pci-tegra.c:2482:12: error: 'tegra_pcie_pm_resume' defined but not used [-Werror=unused-function]
> static int tegra_pcie_pm_resume(struct device *dev)
> drivers/pci/host/pci-tegra.c:2463:12: error: 'tegra_pcie_pm_suspend' defined but not used [-Werror=unused-function]
> static int tegra_pcie_pm_suspend(struct device *dev)
>
> Marking the functions as __maybe_unused lets the compiler drop them
> silently instead.
>
> Fixes: b90b44154023 ("PCI: tegra: Add power management support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pci/host/pci-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-03-15 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 16:18 [PATCH] PCI: tegra: mark PM functions as __maybe_unused Arnd Bergmann
2018-03-15 16:49 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315164927.GA31871@ulmo \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=swarren@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.