From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com ([192.55.52.43]:28816 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbeCOReA (ORCPT ); Thu, 15 Mar 2018 13:34:00 -0400 Date: Thu, 15 Mar 2018 19:33:55 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ulrich Hecht Cc: intel-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, laurent.pinchart@ideasonboard.com Subject: Re: [Intel-gfx] [PATCH igt 5/8] tests/kms_plane_lowres: skip i915-specific tests on other platforms Message-ID: <20180315173355.GX5453@intel.com> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1521125144-28614-6-git-send-email-ulrich.hecht+renesas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1521125144-28614-6-git-send-email-ulrich.hecht+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Thu, Mar 15, 2018 at 03:45:41PM +0100, Ulrich Hecht wrote: > Add is_i915_device() requirement to tests using Intel-specific APIs. > > Signed-off-by: Ulrich Hecht > --- > tests/kms_plane_lowres.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c > index d1e4b3c..8fc7654 100644 > --- a/tests/kms_plane_lowres.c > +++ b/tests/kms_plane_lowres.c > @@ -270,6 +270,7 @@ run_tests_for_pipe(data_t *data, enum pipe pipe) > igt_skip_on(pipe >= data->display.n_pipes); > > igt_display_require_output_on_pipe(&data->display, pipe); > + igt_require(is_i915_device(data->drm_fd)); What's the i915 specific thing here? The tiling formats? You should still be able to do the linear tests. We probably want to utilize https://patchwork.freedesktop.org/patch/210341/ to skip any test that is trying to use an unsupported modifier. Looks like I didn't account for drivers that don't support blobifiers. Shouldn't be too difficult to fix that up though. > } > > igt_subtest_f("pipe-%s-tiling-none", > -- > 2.7.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrj�l� Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH igt 5/8] tests/kms_plane_lowres: skip i915-specific tests on other platforms Date: Thu, 15 Mar 2018 19:33:55 +0200 Message-ID: <20180315173355.GX5453@intel.com> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1521125144-28614-6-git-send-email-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FBF289C1B for ; Thu, 15 Mar 2018 17:33:59 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1521125144-28614-6-git-send-email-ulrich.hecht+renesas@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, laurent.pinchart@ideasonboard.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMTUsIDIwMTggYXQgMDM6NDU6NDFQTSArMDEwMCwgVWxyaWNoIEhlY2h0IHdy b3RlOgo+IEFkZCBpc19pOTE1X2RldmljZSgpIHJlcXVpcmVtZW50IHRvIHRlc3RzIHVzaW5nIElu dGVsLXNwZWNpZmljIEFQSXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogVWxyaWNoIEhlY2h0IDx1bHJp Y2guaGVjaHQrcmVuZXNhc0BnbWFpbC5jb20+Cj4gLS0tCj4gIHRlc3RzL2ttc19wbGFuZV9sb3dy ZXMuYyB8IDEgKwo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0t Z2l0IGEvdGVzdHMva21zX3BsYW5lX2xvd3Jlcy5jIGIvdGVzdHMva21zX3BsYW5lX2xvd3Jlcy5j Cj4gaW5kZXggZDFlNGIzYy4uOGZjNzY1NCAxMDA2NDQKPiAtLS0gYS90ZXN0cy9rbXNfcGxhbmVf bG93cmVzLmMKPiArKysgYi90ZXN0cy9rbXNfcGxhbmVfbG93cmVzLmMKPiBAQCAtMjcwLDYgKzI3 MCw3IEBAIHJ1bl90ZXN0c19mb3JfcGlwZShkYXRhX3QgKmRhdGEsIGVudW0gcGlwZSBwaXBlKQo+ ICAJCWlndF9za2lwX29uKHBpcGUgPj0gZGF0YS0+ZGlzcGxheS5uX3BpcGVzKTsKPiAgCj4gIAkJ aWd0X2Rpc3BsYXlfcmVxdWlyZV9vdXRwdXRfb25fcGlwZSgmZGF0YS0+ZGlzcGxheSwgcGlwZSk7 Cj4gKwkJaWd0X3JlcXVpcmUoaXNfaTkxNV9kZXZpY2UoZGF0YS0+ZHJtX2ZkKSk7CgpXaGF0J3Mg dGhlIGk5MTUgc3BlY2lmaWMgdGhpbmcgaGVyZT8gVGhlIHRpbGluZyBmb3JtYXRzPyBZb3Ugc2hv dWxkCnN0aWxsIGJlIGFibGUgdG8gZG8gdGhlIGxpbmVhciB0ZXN0cy4KCldlIHByb2JhYmx5IHdh bnQgdG8gdXRpbGl6ZSBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMjEw MzQxLwp0byBza2lwIGFueSB0ZXN0IHRoYXQgaXMgdHJ5aW5nIHRvIHVzZSBhbiB1bnN1cHBvcnRl ZCBtb2RpZmllci4gTG9va3MKbGlrZSBJIGRpZG4ndCBhY2NvdW50IGZvciBkcml2ZXJzIHRoYXQg ZG9uJ3Qgc3VwcG9ydCBibG9iaWZpZXJzLgpTaG91bGRuJ3QgYmUgdG9vIGRpZmZpY3VsdCB0byBm aXggdGhhdCB1cCB0aG91Z2guCgo+ICAJfQo+ICAKPiAgCWlndF9zdWJ0ZXN0X2YoInBpcGUtJXMt dGlsaW5nLW5vbmUiLAo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9U QwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK