All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: changbin.du@intel.com, jolsa@redhat.com, peterz@infradead.org,
	mingo@redhat.com, namhyung@kernel.org, yan.y.zhao@intel.com,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf trace: __print_array should print hex format instead of dec
Date: Thu, 15 Mar 2018 14:49:50 -0300	[thread overview]
Message-ID: <20180315174950.GF3690@kernel.org> (raw)
In-Reply-To: <20180315133156.3389b762@vmware.local.home>

Em Thu, Mar 15, 2018 at 01:31:56PM -0400, Steven Rostedt escreveu:
> On Thu, 15 Mar 2018 13:20:25 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Tue, 13 Mar 2018 11:27:32 -0300
> > Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > 
> > > Em Tue, Mar 13, 2018 at 06:39:17PM +0800, changbin.du@intel.com escreveu:  
> > > > From: Changbin Du <changbin.du@intel.com>
> > > > 
> > > > The token '__print_array' is to print the array in hex format, but not
> > > > decimal numbers. The implementation of __print_array in kernel side is:
> > > > __print_array()->trace_print_array_seq()
> > > > 
> > > > This patch align the perf's behavior with kernel so we have a consistent
> > > > event format.    
> > > 
> > > Look ok, i.e. makes the userspace formatting do what the equivalent
> > > kernel code does, Rostedt, Ack?
> > >   
> > 
> > Thanks for sending this to me. I'll see how it affects trace-cmd, and
> > let you know.
> >
> 
> Looks good!
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

thanks, applying

      reply	other threads:[~2018-03-15 17:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 10:39 [PATCH] perf trace: __print_array should print hex format instead of dec changbin.du
2018-03-13 14:27 ` Arnaldo Carvalho de Melo
2018-03-15 17:20   ` Steven Rostedt
2018-03-15 17:31     ` Steven Rostedt
2018-03-15 17:49       ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315174950.GF3690@kernel.org \
    --to=acme@kernel.org \
    --cc=changbin.du@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.