From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:51651 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbeCPIvI (ORCPT ); Fri, 16 Mar 2018 04:51:08 -0400 Received: by mail-wm0-f65.google.com with SMTP id h21so1567905wmd.1 for ; Fri, 16 Mar 2018 01:51:08 -0700 (PDT) Date: Fri, 16 Mar 2018 09:51:05 +0100 From: Daniel Vetter To: Ulrich Hecht Cc: intel-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, laurent.pinchart@ideasonboard.com Subject: Re: [Intel-gfx] [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms Message-ID: <20180316085105.GD14155@phenom.ffwll.local> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1521125144-28614-2-git-send-email-ulrich.hecht+renesas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1521125144-28614-2-git-send-email-ulrich.hecht+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Thu, Mar 15, 2018 at 03:45:37PM +0100, Ulrich Hecht wrote: > Add is_i915_device() requirement to tests using Intel-specific APIs. > > Signed-off-by: Ulrich Hecht Reviewed-by: Daniel Vetter > --- > tests/kms_addfb_basic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c > index 7d8852f..cf9ba37 100644 > --- a/tests/kms_addfb_basic.c > +++ b/tests/kms_addfb_basic.c > @@ -104,6 +104,7 @@ static void invalid_tests(int fd) > } > > igt_subtest("clobberred-modifier") { > + igt_require(is_i915_device(fd)); > f.flags = 0; > f.modifier[0] = 0; > gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4); > @@ -318,6 +319,7 @@ static void size_tests(int fd) > } > > igt_subtest("bo-too-small-due-to-tiling") { > + igt_require(is_i915_device(fd)); > gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4); > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 && > errno == EINVAL); > @@ -369,6 +371,7 @@ static void addfb25_tests(int fd) > > igt_subtest_group { > igt_fixture { > + igt_require(is_i915_device(fd)); > gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4); > igt_require_fb_modifiers(fd); > } > -- > 2.7.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms Date: Fri, 16 Mar 2018 09:51:05 +0100 Message-ID: <20180316085105.GD14155@phenom.ffwll.local> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1521125144-28614-2-git-send-email-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 546636E96A for ; Fri, 16 Mar 2018 08:51:09 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id w128so1584476wmw.0 for ; Fri, 16 Mar 2018 01:51:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1521125144-28614-2-git-send-email-ulrich.hecht+renesas@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, laurent.pinchart@ideasonboard.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMTUsIDIwMTggYXQgMDM6NDU6MzdQTSArMDEwMCwgVWxyaWNoIEhlY2h0IHdy b3RlOgo+IEFkZCBpc19pOTE1X2RldmljZSgpIHJlcXVpcmVtZW50IHRvIHRlc3RzIHVzaW5nIElu dGVsLXNwZWNpZmljIEFQSXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogVWxyaWNoIEhlY2h0IDx1bHJp Y2guaGVjaHQrcmVuZXNhc0BnbWFpbC5jb20+CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8 ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIHRlc3RzL2ttc19hZGRmYl9iYXNpYy5j IHwgMyArKysKPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1n aXQgYS90ZXN0cy9rbXNfYWRkZmJfYmFzaWMuYyBiL3Rlc3RzL2ttc19hZGRmYl9iYXNpYy5jCj4g aW5kZXggN2Q4ODUyZi4uY2Y5YmEzNyAxMDA2NDQKPiAtLS0gYS90ZXN0cy9rbXNfYWRkZmJfYmFz aWMuYwo+ICsrKyBiL3Rlc3RzL2ttc19hZGRmYl9iYXNpYy5jCj4gQEAgLTEwNCw2ICsxMDQsNyBA QCBzdGF0aWMgdm9pZCBpbnZhbGlkX3Rlc3RzKGludCBmZCkKPiAgCX0KPiAgCj4gIAlpZ3Rfc3Vi dGVzdCgiY2xvYmJlcnJlZC1tb2RpZmllciIpIHsKPiArCQlpZ3RfcmVxdWlyZShpc19pOTE1X2Rl dmljZShmZCkpOwo+ICAJCWYuZmxhZ3MgPSAwOwo+ICAJCWYubW9kaWZpZXJbMF0gPSAwOwo+ICAJ CWdlbV9zZXRfdGlsaW5nKGZkLCBnZW1fYm8sIEk5MTVfVElMSU5HX1gsIDUxMio0KTsKPiBAQCAt MzE4LDYgKzMxOSw3IEBAIHN0YXRpYyB2b2lkIHNpemVfdGVzdHMoaW50IGZkKQo+ICAJfQo+ICAK PiAgCWlndF9zdWJ0ZXN0KCJiby10b28tc21hbGwtZHVlLXRvLXRpbGluZyIpIHsKPiArCQlpZ3Rf cmVxdWlyZShpc19pOTE1X2RldmljZShmZCkpOwo+ICAJCWdlbV9zZXRfdGlsaW5nKGZkLCBnZW1f Ym9fc21hbGwsIEk5MTVfVElMSU5HX1gsIDEwMjQqNCk7Cj4gIAkJaWd0X2Fzc2VydChkcm1Jb2N0 bChmZCwgRFJNX0lPQ1RMX01PREVfQURERkIyLCAmZikgPT0gLTEgJiYKPiAgCQkJICAgZXJybm8g PT0gRUlOVkFMKTsKPiBAQCAtMzY5LDYgKzM3MSw3IEBAIHN0YXRpYyB2b2lkIGFkZGZiMjVfdGVz dHMoaW50IGZkKQo+ICAKPiAgCWlndF9zdWJ0ZXN0X2dyb3VwIHsKPiAgCQlpZ3RfZml4dHVyZSB7 Cj4gKwkJCWlndF9yZXF1aXJlKGlzX2k5MTVfZGV2aWNlKGZkKSk7Cj4gIAkJCWdlbV9zZXRfdGls aW5nKGZkLCBnZW1fYm8sIEk5MTVfVElMSU5HX1gsIDEwMjQqNCk7Cj4gIAkJCWlndF9yZXF1aXJl X2ZiX21vZGlmaWVycyhmZCk7Cj4gIAkJfQo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==