From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:59909 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbeCPMze (ORCPT ); Fri, 16 Mar 2018 08:55:34 -0400 Date: Fri, 16 Mar 2018 14:55:25 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Sahil Rihan , Alexei Starovoitov , stable@vger.kernel.org, Peter Huewe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH] tpm: allow TCPA log area to be empty Message-ID: <20180316125525.GB5035@linux.intel.com> References: <20180310161637.7723-1-jarkko.sakkinen@linux.intel.com> <20180312150231.GA24717@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180312150231.GA24717@ziepe.ca> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Mon, Mar 12, 2018 at 09:02:32AM -0600, Jason Gunthorpe wrote: > On Sat, Mar 10, 2018 at 06:16:37PM +0200, Jarkko Sakkinen wrote: > > TCPA log are can be empty when the TPM is disabled. This commit changes the > > behavior of tpm_read_log_acpi() to return successfully in this case. > > The commit should explain why we'd want this.. > > eg Why does it matter to create the extra sysfs files to report an empty > log? > > Jason The initialization of the driver will fail otherwise. Not sure if I understand your question. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen) Date: Fri, 16 Mar 2018 14:55:25 +0200 Subject: [PATCH] tpm: allow TCPA log area to be empty In-Reply-To: <20180312150231.GA24717@ziepe.ca> References: <20180310161637.7723-1-jarkko.sakkinen@linux.intel.com> <20180312150231.GA24717@ziepe.ca> Message-ID: <20180316125525.GB5035@linux.intel.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Mon, Mar 12, 2018 at 09:02:32AM -0600, Jason Gunthorpe wrote: > On Sat, Mar 10, 2018 at 06:16:37PM +0200, Jarkko Sakkinen wrote: > > TCPA log are can be empty when the TPM is disabled. This commit changes the > > behavior of tpm_read_log_acpi() to return successfully in this case. > > The commit should explain why we'd want this.. > > eg Why does it matter to create the extra sysfs files to report an empty > log? > > Jason The initialization of the driver will fail otherwise. Not sure if I understand your question. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html