From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521205285; bh=qeJmNS2f9yj3D5UpjgNUKFk2/fda3JhaTjsdcoIFKL8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=l7yfEYD9450EsfoDoxVk3J9PCDVD5noIs7i3CY9LTpdJPDOOYIXOfTr6NlLyONXYJ xlr+xrVkZRVKljVmIbg9Wek3DBhL0OfnphyC8hd/+5+5tQxd0A5LfPG/Ralab71or6 ukIv131NfsbTX7hZ5c03k4cCPUE/xtblwrfwlydA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521205284; bh=qeJmNS2f9yj3D5UpjgNUKFk2/fda3JhaTjsdcoIFKL8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=LQKbRM6wQ9e6JrjAagC1VivnrGcVQZVoFaYCi55c9aFG1xRFJn4nUkr8BXwoupDN2 N2udPlWyynX0UBIXBIN8sNFnZaFhv4St3wl1quoqhD6U+N61nbbvYwnIZTSYukkF+Z VY7eu90ko5CslgKwckrvCdV5nB1mlrf40y/ENaXs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kalle Valo In-Reply-To: <20180315072909.1512-1-zajec5@gmail.com> References: <20180315072909.1512-1-zajec5@gmail.com> Message-Id: <20180316130125.97A8F60C64@smtp.codeaurora.org> Subject: Re: [Bridge] [V2] brcmfmac: drop Inter-Access Point Protocol packets by default List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Fri, 16 Mar 2018 13:01:26 -0000 To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: James Hughes , Arend van Spriel , netdev@vger.kernel.org, Chi-Hsien Lin , bridge@lists.linux-foundation.org, linux-wireless@vger.kernel.org, Hante Meuleman , Pieter-Paul Giesberts , brcm80211-dev-list.pdl@broadcom.com, Wright Feng , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Felix Fietkau , brcm80211-dev-list@cypress.com, Franky Lin Rafał Miłecki wrote: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares. > > Older firmwares were only generating 802.11f frames. Newer ones like: > 1) 10.10 (TOB) (r663589) > 2) 10.10.122.20 (r683106) > for 4366b1 and 4366c0 respectively seem to also /respect/ 802.11f frames > in the Tx path by performing a STA disassociation. > > This obsoleted standard and its implementation is something that: > 1) Most people don't need / want to use > 2) Can allow local DoS attacks > 3) Breaks AP interfaces in some specific bridge setups > > To solve issues it can cause this commit modifies brcmfmac to drop IAPP > packets. If affects: > 1) Rx path: driver won't be sending these unwanted packets up. > 2) Tx path: driver will reject packets that would trigger STA > disassociation perfromed by a firmware (possible local DoS attack). > > It appears there are some Broadcom's clients/users who care about this > feature despite the drawbacks. They can switch it on using a new module > param. > > This change results in only two more comparisons (check for module param > and check for Ethernet packet length) for 99.9% of packets. Its overhead > should be very minimal. > > Signed-off-by: Rafał Miłecki > Acked-by: Arend van Spriel Patch applied to wireless-drivers.git, thanks. 125905517028 brcmfmac: drop Inter-Access Point Protocol packets by default -- https://patchwork.kernel.org/patch/10283971/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [V2] brcmfmac: drop Inter-Access Point Protocol packets by default Date: Fri, 16 Mar 2018 13:01:25 +0000 (UTC) Message-ID: <20180316130125.97A8F60C64@smtp.codeaurora.org> References: <20180315072909.1512-1-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: James Hughes , Arend van Spriel , netdev@vger.kernel.org, Chi-Hsien Lin , bridge@lists.linux-foundation.org, linux-wireless@vger.kernel.org, Hante Meuleman , Pieter-Paul Giesberts , brcm80211-dev-list.pdl@broadcom.com, Wright Feng , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Felix Fietkau , brcm80211-dev-list@cypress.com, Franky Lin To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Return-path: In-Reply-To: <20180315072909.1512-1-zajec5@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org Rafał Miłecki wrote: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares. > > Older firmwares were only generating 802.11f frames. Newer ones like: > 1) 10.10 (TOB) (r663589) > 2) 10.10.122.20 (r683106) > for 4366b1 and 4366c0 respectively seem to also /respect/ 802.11f frames > in the Tx path by performing a STA disassociation. > > This obsoleted standard and its implementation is something that: > 1) Most people don't need / want to use > 2) Can allow local DoS attacks > 3) Breaks AP interfaces in some specific bridge setups > > To solve issues it can cause this commit modifies brcmfmac to drop IAPP > packets. If affects: > 1) Rx path: driver won't be sending these unwanted packets up. > 2) Tx path: driver will reject packets that would trigger STA > disassociation perfromed by a firmware (possible local DoS attack). > > It appears there are some Broadcom's clients/users who care about this > feature despite the drawbacks. They can switch it on using a new module > param. > > This change results in only two more comparisons (check for module param > and check for Ethernet packet length) for 99.9% of packets. Its overhead > should be very minimal. > > Signed-off-by: Rafał Miłecki > Acked-by: Arend van Spriel Patch applied to wireless-drivers.git, thanks. 125905517028 brcmfmac: drop Inter-Access Point Protocol packets by default -- https://patchwork.kernel.org/patch/10283971/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches