From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:45822 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbeCPSxr (ORCPT ); Fri, 16 Mar 2018 14:53:47 -0400 Date: Fri, 16 Mar 2018 14:53:34 -0400 From: Sowmini Varadhan To: Kirill Tkhai Cc: santosh.shilimkar@oracle.com, davem@davemloft.net, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, edumazet@google.com Subject: Re: [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL) Message-ID: <20180316185334.GQ16870@oracle.com> References: <152120385651.2065.2567466917573907029.stgit@localhost.localdomain> <20180316130008.GE16870@oracle.com> <512c2483-aa62-b385-6079-1b6ff8ba4636@virtuozzo.com> <20180316172918.GM16870@oracle.com> <82d6e954-8043-078c-266c-2f1ac992f864@virtuozzo.com> <20180316183133.GP16870@oracle.com> <856ac399-c934-6a14-1ae7-d921c449c4b1@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <856ac399-c934-6a14-1ae7-d921c449c4b1@virtuozzo.com> Sender: netdev-owner@vger.kernel.org List-ID: On (03/16/18 21:48), Kirill Tkhai wrote: > > > Thus I have to spend some time reviewing your patch, > > and I cannot give you an answer in the next 5 minutes. > > No problem, 5 minutes response never required. Thanks for > your review. thank you. I would like to take some time this weekend to understand why v1 of your patch hit the null rtn, but v2 did not (a superficial glance at the patch suggested that you were registering twice in both cases, with just a reordering, so I would like to understand the root-cause of the null ptr deref with v1) As for registering 2 times, that needs some comments to provide guidance for other subsystems. e.g., I found the large block comment in net-namespace.h very helpful, so lets please clearly document what and why and when this should be used. --Sowmini