From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 2/5] drm/i915/psr: Tie PSR2 support to Y coordinate requirement in intel_psr_init_dpcd() Date: Fri, 16 Mar 2018 16:25:30 -0700 Message-ID: <20180316232530.GC2575@intel.com> References: <20180316230501.974-1-jose.souza@intel.com> <20180316230501.974-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8F616E0B1 for ; Fri, 16 Mar 2018 23:25:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180316230501.974-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMTYsIDIwMTggYXQgMDQ6MDQ6NThQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBNb3ZlIHRvIG9ubHkgb25lIHBsYWNlIHRoZSBzaW5rIHJlcXVpcmVt ZW50cyB0aGF0IHRoZSBhY3R1YWwgZHJpdmVyCj4gbmVlZHMgdG8gZW5hYmxlIFBTUjIuCj4gCj4g QWxzbyBpbnRlbF9wc3IyX2NvbmZpZ192YWxpZCgpIGlzIGNhbGxlZCBldmVyeSB0aW1lIHRoZSBj cnRjIGNvbmZpZwo+IGlzIGNvbXB1dGVkLCB3YXN0aW5nIHNvbWUgdGltZSBldmVyeSB0aW1lIGl0 IHdhcyBjaGVja2luZyBmb3IKPiBZIGNvb3JkaW5hdGUgcmVxdWlyZW1lbnQuCj4gCj4gVGhpcyBh bGxvdyB1cyB0byBudWtlIHlfY29yZF9zdXBwb3J0IGFuZCBzb21lIG9mIFZTQyBzZXR1cCBjb2Rl IHRoYXQKPiB3YXMgaGFuZGxpbmcgYSBzY2VuYXJpbyB0aGF0IHdvdWxkIG5ldmVyIGhhcHBlbihQ U1IyIHdpdGhvdXQgWQo+IGNvb3JkaW5hdGUpLgo+IAo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFu IDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2Ry aWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291 emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9k cmlnby52aXZpQGludGVsLmNvbT4KCj4gLS0tCj4gCj4gdjI6IENoYW5nZXMgaW4gY29tbWVudCBy ZXF1ZXN0ZWQgYnkgUm9kcmlnbyBWaXZpCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggIHwgIDEgLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDU2ICsr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2Vk LCAyOSBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmgKPiBpbmRleCA4YTU4NDI3M2Y4OTcuLmQ0YmM4ZDE4ZjU2YyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaAo+IEBAIC02MDMsNyArNjAzLDYgQEAgc3RydWN0IGk5MTVfcHNyIHsKPiAg CXVuc2lnbmVkIGJ1c3lfZnJvbnRidWZmZXJfYml0czsKPiAgCWJvb2wgcHNyMl9zdXBwb3J0Owo+ ICAJYm9vbCBsaW5rX3N0YW5kYnk7Cj4gLQlib29sIHlfY29yZF9zdXBwb3J0Owo+ICAJYm9vbCBj b2xvcmltZXRyeV9zdXBwb3J0Owo+ICAJYm9vbCBhbHBtOwo+ICAJYm9vbCBoYXNfaHdfdHJhY2tp bmc7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBpbmRleCA5ODExZjVmMGJjNzUuLjU1OTNk MWYzMDQ5YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gQEAgLTkzLDcgKzkzLDcg QEAgc3RhdGljIHZvaWQgcHNyX2F1eF9pb19wb3dlcl9wdXQoc3RydWN0IGludGVsX2RwICppbnRl bF9kcCkKPiAgCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBwc3JfYXV4X2RvbWFp bihpbnRlbF9kcCkpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgYm9vbCBpbnRlbF9kcF9nZXRfeV9jb3Jk X3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICtzdGF0aWMgYm9vbCBpbnRlbF9k cF9nZXRfeV9jb29yZF9yZXF1aXJlZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICB7Cj4g IAl1aW50OF90IHBzcl9jYXBzID0gMDsKPiAgCj4gQEAgLTEzNywyMiArMTM3LDM5IEBAIHZvaWQg aW50ZWxfcHNyX2luaXRfZHBjZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAKPiAgCWlm IChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkgJiYKPiAgCSAgICAoaW50ZWxfZHAtPnBzcl9kcGNk WzBdICYgRFBfUFNSMl9JU19TVVBQT1JURUQpKSB7Cj4gLQkJdWludDhfdCBmcmFtZV9zeW5jX2Nh cDsKPiArCQl1aW50OF90IGZyYW1lX3N5bmNfY2FwLCB5X2Nvb3JkX3JlcTsKPiAgCj4gIAkJZGV2 X3ByaXYtPnBzci5zaW5rX3N1cHBvcnQgPSB0cnVlOwo+ICsKPiArCQkvKiBQU1IyIG5lZWRzIGZy YW1lIHN5bmMgdG8gZG8gc2VsZWN0aXZlIHVwZGF0ZXMgKi8KPiAgCQlpZiAoZHJtX2RwX2RwY2Rf cmVhZGIoJmludGVsX2RwLT5hdXgsCj4gIAkJCQkgICAgICBEUF9TSU5LX0RFVklDRV9BVVhfRlJB TUVfU1lOQ19DQVAsCj4gIAkJCQkgICAgICAmZnJhbWVfc3luY19jYXApICE9IDEpCj4gIAkJCWZy YW1lX3N5bmNfY2FwID0gMDsKPiAgCQlmcmFtZV9zeW5jX2NhcCA9IChmcmFtZV9zeW5jX2NhcCAm IERQX0FVWF9GUkFNRV9TWU5DX0NBUCk7Cj4gLQkJLyogUFNSMiBuZWVkcyBmcmFtZSBzeW5jIGFz IHdlbGwgKi8KPiAtCQlkZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCA9IGZyYW1lX3N5bmNfY2Fw Owo+IC0JCURSTV9ERUJVR19LTVMoIlBTUjIgJXMgb24gc2luayIsCj4gLQkJCSAgICAgIGRldl9w cml2LT5wc3IucHNyMl9zdXBwb3J0ID8gInN1cHBvcnRlZCIgOiAibm90IHN1cHBvcnRlZCIpOwo+ ICsKPiArCQkvKgo+ICsJCSAqIEFsbCBwYW5lbHMgdGhhdCBzdXBwb3J0cyBQU1IgdmVyc2lvbiAw M2ggKFBTUjIgKwo+ICsJCSAqIFktY29vcmRpbmF0ZSkgc3VwcG9ydCBjYW4gaGFuZGxlIFktY29v cmRpbmF0ZXMgaW4gVlNDCj4gKwkJICogYnV0IHdlIGFyZSBvbmx5IHN1cmUgdGhhdCBpdCBpcyBn b2luZyB0byBiZSB1c2VkIHdoZW4KPiArCQkgKiByZXF1aXJlZCBieSB0aGUgcGFuZWwuIFRoaXMg d2F5IHBhbmVsIGlzIGNhcGFibGUgdG8gZG8KPiArCQkgKiBzZWxlY3RpdmUgdXBkYXRlIGV2ZW4g d2l0aG91dCBhIHZhbGlkIGF1eCBmcmFtZSBzeW5jLgo+ICsJCSAqCj4gKwkJICogVG8gc3VwcG9y dCBQU1IgdmVyc2lvbiAwMmggYW5kIFBTUiB2ZXJzaW9uIDAzaCB3aXRob3V0Cj4gKwkJICogWS1j b29yZGluYXRlIHJlcXVpcmVtZW50IHBhbmVscyB3ZSB3b3VsZCBuZWVkIHRvIGVuYWJsZQo+ICsJ CSAqIEdUQyBmaXJzdC4KPiArCQkgKi8KPiArCQl5X2Nvb3JkX3JlcSA9IGludGVsX2RwX2dldF95 X2Nvb3JkX3JlcXVpcmVkKGludGVsX2RwKTsKPiArCj4gKwkJZGV2X3ByaXYtPnBzci5wc3IyX3N1 cHBvcnQgPSBmcmFtZV9zeW5jX2NhcCAmJiB5X2Nvb3JkX3JlcTsKPiArCQlpZiAoZGV2X3ByaXYt PnBzci5wc3IyX3N1cHBvcnQpCj4gKwkJCURSTV9ERUJVR19LTVMoIlBTUjIgc3VwcG9ydGVkIG9u IHNpbmtcbiIpOwo+ICsJCWVsc2UKPiArCQkJRFJNX0RFQlVHX0tNUygiUFNSMiBub3Qgc3VwcG9y dGVkIG9uIHNpbmsiCj4gKwkJCQkgICAgICAiKGZyYW1lIHN5bmM6ICVkIFktY29vcmQgcmVxdWly ZWQ6ICVkKVxuIiwKPiArCQkJCSAgICAgIGZyYW1lX3N5bmNfY2FwLCB5X2Nvb3JkX3JlcSk7Cj4g IAo+ICAJCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCkgewo+IC0JCQlkZXZfcHJpdi0+ cHNyLnlfY29yZF9zdXBwb3J0ID0KPiAtCQkJCWludGVsX2RwX2dldF95X2NvcmRfc3RhdHVzKGlu dGVsX2RwKTsKPiAgCQkJZGV2X3ByaXYtPnBzci5jb2xvcmltZXRyeV9zdXBwb3J0ID0KPiAgCQkJ CWludGVsX2RwX2dldF9jb2xvcmltZXRyeV9zdGF0dXMoaW50ZWxfZHApOwo+ICAJCQlkZXZfcHJp di0+cHNyLmFscG0gPQo+IEBAIC0xOTgsMTYgKzIxNSwxMiBAQCBzdGF0aWMgdm9pZCBoc3dfcHNy X3NldHVwX3ZzYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAJCW1lbXNldCgmcHNyX3Zz YywgMCwgc2l6ZW9mKHBzcl92c2MpKTsKPiAgCQlwc3JfdnNjLnNkcF9oZWFkZXIuSEIwID0gMDsK PiAgCQlwc3JfdnNjLnNkcF9oZWFkZXIuSEIxID0gMHg3Owo+IC0JCWlmIChkZXZfcHJpdi0+cHNy LmNvbG9yaW1ldHJ5X3N1cHBvcnQgJiYKPiAtCQkgICAgZGV2X3ByaXYtPnBzci55X2NvcmRfc3Vw cG9ydCkgewo+ICsJCWlmIChkZXZfcHJpdi0+cHNyLmNvbG9yaW1ldHJ5X3N1cHBvcnQpIHsKPiAg CQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMiA9IDB4NTsKPiAgCQkJcHNyX3ZzYy5zZHBfaGVhZGVy LkhCMyA9IDB4MTM7Cj4gLQkJfSBlbHNlIGlmIChkZXZfcHJpdi0+cHNyLnlfY29yZF9zdXBwb3J0 KSB7Cj4gKwkJfSBlbHNlIHsKPiAgCQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMiA9IDB4NDsKPiAg CQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMyA9IDB4ZTsKPiAtCQl9IGVsc2Ugewo+IC0JCQlwc3Jf dnNjLnNkcF9oZWFkZXIuSEIyID0gMHgzOwo+IC0JCQlwc3JfdnNjLnNkcF9oZWFkZXIuSEIzID0g MHhjOwo+ICAJCX0KPiAgCX0gZWxzZSB7Cj4gIAkJLyogUHJlcGFyZSBWU0MgcGFja2V0IGFzIHBl ciBFRFAgMS4zIHNwZWMsIFRhYmxlIDMuMTAgKi8KPiBAQCAtNDc4LDE1ICs0OTEsNiBAQCBzdGF0 aWMgYm9vbCBpbnRlbF9wc3IyX2NvbmZpZ192YWxpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw LAo+ICAJCXJldHVybiBmYWxzZTsKPiAgCX0KPiAgCj4gLQkvKgo+IC0JICogRklYTUU6ZW5hYmxl IHBzcjIgb25seSBmb3IgeS1jb3JkaW5hdGUgcHNyMiBwYW5lbHMKPiAtCSAqIEFmdGVyIGd0YyBp bXBsZW1lbnRhdGlvbiAsIHJlbW92ZSB0aGlzIHJlc3RyaWN0aW9uLgo+IC0JICovCj4gLQlpZiAo IWRldl9wcml2LT5wc3IueV9jb3JkX3N1cHBvcnQpIHsKPiAtCQlEUk1fREVCVUdfS01TKCJQU1Iy IG5vdCBlbmFibGVkLCBwYW5lbCBkb2VzIG5vdCBzdXBwb3J0IFkgY29vcmRpbmF0ZVxuIik7Cj4g LQkJcmV0dXJuIGZhbHNlOwo+IC0JfQo+IC0KPiAgCXJldHVybiB0cnVlOwo+ICB9Cj4gIAo+IEBA IC01ODYsMTQgKzU5MCwxMiBAQCBzdGF0aWMgdm9pZCBoc3dfcHNyX2VuYWJsZV9zb3VyY2Uoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdf cG9ydC0+YmFzZS5iYXNlLmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZGV2KTsKPiAgCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IGNy dGNfc3RhdGUtPmNwdV90cmFuc2NvZGVyOwo+IC0JdTMyIGNoaWNrZW47Cj4gIAo+ICAJcHNyX2F1 eF9pb19wb3dlcl9nZXQoaW50ZWxfZHApOwo+ICAKPiAgCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJf c3VwcG9ydCkgewo+IC0JCWNoaWNrZW4gPSBQU1IyX1ZTQ19FTkFCTEVfUFJPR19IRUFERVI7Cj4g LQkJaWYgKGRldl9wcml2LT5wc3IueV9jb3JkX3N1cHBvcnQpCj4gLQkJCWNoaWNrZW4gfD0gUFNS Ml9BRERfVkVSVElDQUxfTElORV9DT1VOVDsKPiArCQl1MzIgY2hpY2tlbiA9IFBTUjJfVlNDX0VO QUJMRV9QUk9HX0hFQURFUgo+ICsJCQkgICAgICB8IFBTUjJfQUREX1ZFUlRJQ0FMX0xJTkVfQ09V TlQ7Cj4gIAkJSTkxNV9XUklURShDSElDS0VOX1RSQU5TKGNwdV90cmFuc2NvZGVyKSwgY2hpY2tl bik7Cj4gIAo+ICAJCUk5MTVfV1JJVEUoRURQX1BTUl9ERUJVRywKPiAtLSAKPiAyLjE2LjIKPiAK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==