From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4] EDAC, sb_edac: Remove VLA usage From: Borislav Petkov Message-Id: <20180317043040.GA973@pd.tnic> Date: Sat, 17 Mar 2018 05:30:41 +0100 To: "Gustavo A. R. Silva" Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBNYXIgMTQsIDIwMTggYXQgMDE6MjE6MzJQTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBJbiBwcmVwYXJhdGlvbiB0byBlbmFibGluZyAtV3ZsYSwgcmVtb3ZlIFZM QSBhbmQgcmVwbGFjZSBpdAo+IHdpdGggYSBmaXhlZC1sZW5ndGggYXJyYXkgaW5zdGVhZC4KPiAK PiBGaXhlZCBhcyBwYXJ0IG9mIHRoZSBkaXJlY3RpdmUgdG8gcmVtb3ZlIGFsbCBWTEFzIGZyb20K PiB0aGUga2VybmVsOiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOC8zLzcvNjIxCj4gCj4gQWxz bywgcmVtb3ZlIG1heF9pbnRlcmxlYXZlIGFzIGl0IGlzIG5vIGxvbmdlciB1c2VmdWwuCj4gCj4g UmV2aWV3ZWQtYnk6IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhhYkBzLW9wZW5zb3VyY2Uu Y29tPgo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9AZW1iZWRk ZWRvci5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2NDoKPiAgLSBSZW1vdmUgbWF4X2ludGVybGVh dmUuCj4gCj4gQ2hhbmdlcyBpbiB2MzoKPiAgLSBVcGRhdGUgbWFjcm8gTUFYX0lOVEVSTEVBVkUg aW4gb3JkZXIgdG8gYXZvaWQgdG9vIGxvbmcgbGluZXMuCj4gICAgVGhpcyBjaGFuZ2UgaXMgYmFz ZWQgb24gTWF1cm8ncyBmZWVkYmFjay4KPiAgLSBVcGRhdGUgY2hhbmdlbG9nIHdpdGggTWF1cm8n cyBSZXZpZXdlZC1ieS4KPiAKPiBDaGFuZ2VzIGluIHYyOgo+ICAtIFVzZSBtYWNybyBtYXhfdCB0 byBjb21wdXRlIHRoZSBtYXggb2YgYWxsIHRocmVlIGFycmF5IHNpemVzLgo+ICAgIFRoaXMgY2hh bmdlIGlzIGJhc2VkIG9uIEJvcmlzbGF2J3MgZmVlZGJhY2suCj4gCj4gIGRyaXZlcnMvZWRhYy9z Yl9lZGFjLmMgfCAxMiArKysrKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKCkFwcGxpZWQsIHRoYW5rcy4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbeCQEbY (ORCPT ); Sat, 17 Mar 2018 00:31:24 -0400 Received: from mail.skyhub.de ([5.9.137.197]:55924 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710AbeCQEbW (ORCPT ); Sat, 17 Mar 2018 00:31:22 -0400 Date: Sat, 17 Mar 2018 05:30:41 +0100 From: Borislav Petkov To: "Gustavo A. R. Silva" Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] EDAC, sb_edac: Remove VLA usage Message-ID: <20180317043040.GA973@pd.tnic> References: <20180314182131.GA25259@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180314182131.GA25259@embeddedgus> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 14, 2018 at 01:21:32PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with a fixed-length array instead. > > Fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Also, remove max_interleave as it is no longer useful. > > Reviewed-by: Mauro Carvalho Chehab > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v4: > - Remove max_interleave. > > Changes in v3: > - Update macro MAX_INTERLEAVE in order to avoid too long lines. > This change is based on Mauro's feedback. > - Update changelog with Mauro's Reviewed-by. > > Changes in v2: > - Use macro max_t to compute the max of all three array sizes. > This change is based on Borislav's feedback. > > drivers/edac/sb_edac.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.