Re: [PATCH v2] netns: send uevent messages

[Christian Brauner <christian.brauner@canonical.com>]

On Fri, Mar 16, 2018 at 02:41:45PM -0400, David Miller wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> Date: Fri, 16 Mar 2018 13:50:30 +0100
> 
> > +static int uevent_net_broadcast(struct sock *usk, struct sk_buff *skb,
> > +				struct netlink_ext_ack *extack)
> > +{
> > +	int ret;
> > +	/* u64 to chars: 2^64 - 1 = 21 chars */
> > +	char buf[sizeof("SEQNUM=") + 21];
> > +	struct sk_buff *skbc;
> 
> I hate to be difficult, but please use reverse christmas tree ordering
> for local variables.

No problem David, coding style is important. I'm about to send out
another version with:

/* u64 to chars: 2^64 - 1 = 21 chars */
char buf[sizeof("SEQNUM=") + 21];
struct sk_buff *skbc;
int ret;

Thanks!
Christian

> 
> > +static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
> > +			      struct netlink_ext_ack *extack)
> > +{
> > +	int ret;
> > +	struct net *net;
> 
> Likewise.
> 
> Thank you.