From: Al Viro <viro@ZenIV.linux.org.uk>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
NeilBrown <neilb@suse.com>
Subject: Re: [PATCH] vfs: remove unnecessary fl_owner_t typedef
Date: Sat, 17 Mar 2018 19:14:15 +0000 [thread overview]
Message-ID: <20180317191415.GQ30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180317184840.GA32322@fieldses.org>
On Sat, Mar 17, 2018 at 02:48:40PM -0400, J. Bruce Fields wrote:
> This is a pretty simple patch that touches a lot of files. What's the
> procedure for handling patches like this? I haven't had to do this
> before.
I'm not sure it's a good idea. We want it opaque - if anything, I would
prefer to have anything mistakenly passing it to a function that takes
a pointer scream like hell at build time. The current variant doesn't
have such protection, but it can at least be grepped for. void * can't.
next prev parent reply other threads:[~2018-03-17 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 18:48 [PATCH] vfs: remove unnecessary fl_owner_t typedef J. Bruce Fields
2018-03-17 18:48 ` J. Bruce Fields
2018-03-17 19:12 ` Jeff Layton
2018-03-17 19:12 ` Jeff Layton
2018-03-17 19:14 ` Al Viro [this message]
2018-03-19 14:27 ` J. Bruce Fields
2018-03-18 20:39 ` NeilBrown
2018-03-18 20:39 ` NeilBrown
2018-03-19 14:27 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317191415.GQ30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.