From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: lars@metafoo.de, paolocretaro@gmail.com,
enric.balletbo@collabora.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: cros_ec: Move cros_ec_sensors_core.h in /include
Date: Sat, 17 Mar 2018 19:56:04 +0000 [thread overview]
Message-ID: <20180317195604.4a561f97@archlinux> (raw)
In-Reply-To: <20180313212328.129640-1-gwendal@chromium.org>
On Tue, 13 Mar 2018 14:23:28 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:
> Similar to other common iio frameworks, move cros_ec_sensors_core.h from
> drivers/iio/common/cros_ec_sensors/ to include/linux/iio/common.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 3 +--
> drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 3 +--
> drivers/iio/light/cros_ec_light_prox.c | 3 +--
> drivers/iio/pressure/cros_ec_baro.c | 3 +--
> .../linux/iio/common}/cros_ec_sensors_core.h | 2 ++
> 5 files changed, 6 insertions(+), 8 deletions(-)
> rename {drivers/iio/common/cros_ec_sensors => include/linux/iio/common}/cros_ec_sensors_core.h (99%)
>
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> index 7d30c59da3e2..8e3f99a8b30c 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> @@ -19,6 +19,7 @@
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/iio/buffer.h>
> +#include <linux/iio/common/cros_ec_sensors_core.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/kfifo_buf.h>
> #include <linux/iio/trigger_consumer.h>
> @@ -31,8 +32,6 @@
> #include <linux/slab.h>
> #include <linux/sysfs.h>
>
> -#include "cros_ec_sensors_core.h"
> -
> #define CROS_EC_SENSORS_MAX_CHANNELS 4
>
> /* State data for ec_sensors iio driver. */
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> index 416cae5ebbd0..ea3268bd92f4 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> @@ -16,6 +16,7 @@
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/iio/buffer.h>
> +#include <linux/iio/common/cros_ec_sensors_core.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/kfifo_buf.h>
> #include <linux/iio/trigger_consumer.h>
> @@ -27,8 +28,6 @@
> #include <linux/sysfs.h>
> #include <linux/platform_device.h>
>
> -#include "cros_ec_sensors_core.h"
> -
> static char *cros_ec_loc[] = {
> [MOTIONSENSE_LOC_BASE] = "base",
> [MOTIONSENSE_LOC_LID] = "lid",
> diff --git a/drivers/iio/light/cros_ec_light_prox.c b/drivers/iio/light/cros_ec_light_prox.c
> index acfad4aeb27a..15bd105b08f3 100644
> --- a/drivers/iio/light/cros_ec_light_prox.c
> +++ b/drivers/iio/light/cros_ec_light_prox.c
> @@ -16,6 +16,7 @@
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/iio/buffer.h>
> +#include <linux/iio/common/cros_ec_sensors_core.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/kfifo_buf.h>
> #include <linux/iio/trigger.h>
> @@ -29,8 +30,6 @@
> #include <linux/slab.h>
> #include <linux/sysfs.h>
>
> -#include "../common/cros_ec_sensors/cros_ec_sensors_core.h"
> -
> /*
> * We only represent one entry for light or proximity. EC is merging different
> * light sensors to return the what the eye would see. For proximity, we
> diff --git a/drivers/iio/pressure/cros_ec_baro.c b/drivers/iio/pressure/cros_ec_baro.c
> index 4599fde4dd25..87c07af9181f 100644
> --- a/drivers/iio/pressure/cros_ec_baro.c
> +++ b/drivers/iio/pressure/cros_ec_baro.c
> @@ -16,6 +16,7 @@
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/iio/buffer.h>
> +#include <linux/iio/common/cros_ec_sensors_core.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/kfifo_buf.h>
> #include <linux/iio/trigger.h>
> @@ -28,8 +29,6 @@
> #include <linux/slab.h>
> #include <linux/platform_device.h>
>
> -#include "../common/cros_ec_sensors/cros_ec_sensors_core.h"
> -
> /*
> * One channel for pressure, the other for timestamp.
> */
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h b/include/linux/iio/common/cros_ec_sensors_core.h
> similarity index 99%
> rename from drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h
> rename to include/linux/iio/common/cros_ec_sensors_core.h
> index 8bc2ca3c2e2e..a6701827a773 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h
> +++ b/include/linux/iio/common/cros_ec_sensors_core.h
> @@ -16,7 +16,9 @@
> #ifndef __CROS_EC_SENSORS_CORE_H
> #define __CROS_EC_SENSORS_CORE_H
>
> +#include <linux/iio/iio.h>
> #include <linux/irqreturn.h>
> +#include <linux/mfd/cros_ec.h>
>
> enum {
> CROS_EC_SENSOR_X,
next prev parent reply other threads:[~2018-03-17 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 21:23 [PATCH] iio: cros_ec: Move cros_ec_sensors_core.h in /include Gwendal Grignou
2018-03-17 19:56 ` Jonathan Cameron [this message]
2018-03-17 20:00 ` Jonathan Cameron
2018-03-28 23:53 ` [PATCH v2] " Gwendal Grignou
2018-03-30 9:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317195604.4a561f97@archlinux \
--to=jic23@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=gwendal@chromium.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=paolocretaro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.