From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Antonio Cardace <anto.cardace@gmail.com>
Cc: boris.brezillon@free-electrons.com,
linux-mtd@lists.infradead.org, andriy.shevchenko@linux.intel.com
Subject: Re: [PATCH] mtd: nftl: use %*ph to print small buffer
Date: Sun, 18 Mar 2018 22:23:10 +0100 [thread overview]
Message-ID: <20180318222310.63630656@bbrezillon> (raw)
In-Reply-To: <20180213175245.17703-1-anto.cardace@gmail.com>
On Tue, 13 Feb 2018 17:52:45 +0000
Antonio Cardace <anto.cardace@gmail.com> wrote:
> Use %*ph format to print small buffer as hex string.
Applied.
Thanks,
Boris
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Antonio Cardace <anto.cardace@gmail.com>
> ---
> What about this one?
>
> drivers/mtd/nftlmount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
> index 184c8fbfe465..a8bdc1455b50 100644
> --- a/drivers/mtd/nftlmount.c
> +++ b/drivers/mtd/nftlmount.c
> @@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord *nftl)
> if (memcmp(buf, "ANAND", 6)) {
> printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but went away on reread!\n",
> block * nftl->EraseSize, nftl->mbd.mtd->index);
> - printk(KERN_NOTICE "New data are: %02x %02x %02x %02x %02x %02x\n",
> - buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
> + printk(KERN_NOTICE "New data are: %6ph\n", buf);
> continue;
> }
> #endif
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-03-18 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 17:52 [PATCH] mtd: nftl: use %*ph to print small buffer Antonio Cardace
2018-03-16 14:20 ` Andy Shevchenko
2018-03-18 21:23 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318222310.63630656@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anto.cardace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.