diff for duplicates of <20180319144205.GA4619@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index d0ac4a5..f8b0726 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,18 +9,18 @@ On Fri, Mar 16, 2018 at 08:36:52AM -0400, Mimi Zohar wrote: > > > > > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > > -> > > With this patch, the Pi doesn't find the TPM. I'm seeing the +> > > With this patch, the Pi doesn't find the TPM. I'm seeing the > > > following line in dmesg. > > > -> > > [ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 +> > > [ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 > > > > Thank you for reporting this Mimi. Does it have TPM1/TPM2? > -> The pi has a TPM 2.0 attached to the GPIO. James pointed out the +> The pi has a TPM 2.0 attached to the GPIO. James pointed out the > change in return codes. > > -> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > chip->flags |= TPM_CHIP_FLAG_TPM2; > - > - return 0; diff --git a/a/content_digest b/N1/content_digest index a3f1fbc..7e948ee 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,7 +5,7 @@ "ref\01521203812.3503.19.camel@linux.vnet.ibm.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 19 Mar 2018 14:42:05 +0000\0" + "Date\0Mon, 19 Mar 2018 16:42:05 +0200\0" "To\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" "Cc\0linux-integrity@vger.kernel.org" linux-security-module@vger.kernel.org @@ -28,18 +28,18 @@ "> > > > \n" "> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" "> > > \n" - "> > > With this patch, the Pi doesn't find the TPM. \302\240I'm seeing the\n" + "> > > With this patch, the Pi doesn't find the TPM. I'm seeing the\n" "> > > following line in dmesg.\n" "> > > \n" - "> > > [\302\240\302\240\302\240\302\2401.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" + "> > > [ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" "> > \n" "> > Thank you for reporting this Mimi. Does it have TPM1/TPM2?\n" "> \n" - "> The pi has a TPM 2.0 attached to the GPIO. \302\240James pointed out the\n" + "> The pi has a TPM 2.0 attached to the GPIO. James pointed out the\n" "> change in return codes.\n" "> \n" "> \n" - "> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> chip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> -\n" "> - return 0;\n" @@ -56,4 +56,4 @@ "\n" /Jarkko -a18a872e45799d8efaefe46fa8166f01289bff433ef83ee514646d9bee1a6de2 +1d5f452558c8faa8af3a7411ad16b93b7b0234305b4b682320ebe43c3e2173aa
diff --git a/a/1.txt b/N2/1.txt index d0ac4a5..d570c2f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,18 +9,18 @@ On Fri, Mar 16, 2018 at 08:36:52AM -0400, Mimi Zohar wrote: > > > > > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > > -> > > With this patch, the Pi doesn't find the TPM. I'm seeing the +> > > With this patch, the Pi doesn't find the TPM. ?I'm seeing the > > > following line in dmesg. > > > -> > > [ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 +> > > [????1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 > > > > Thank you for reporting this Mimi. Does it have TPM1/TPM2? > -> The pi has a TPM 2.0 attached to the GPIO. James pointed out the +> The pi has a TPM 2.0 attached to the GPIO. ?James pointed out the > change in return codes. > > -> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > chip->flags |= TPM_CHIP_FLAG_TPM2; > - > - return 0; @@ -36,3 +36,7 @@ Oops, thank you James and Mimi for pointing this out. I'll refine the patch set. /Jarkko +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index a3f1fbc..d62b1b3 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,18 +3,10 @@ "ref\01520290344.10396.357.camel@linux.vnet.ibm.com\0" "ref\020180316122129.GA2458@linux.intel.com\0" "ref\01521203812.3503.19.camel@linux.vnet.ibm.com\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 19 Mar 2018 14:42:05 +0000\0" - "To\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" - "Cc\0linux-integrity@vger.kernel.org" - linux-security-module@vger.kernel.org - keyrings@vger.kernel.org - Peter Huewe <peterhuewe@gmx.de> - Jason Gunthorpe <jgg@ziepe.ca> - Arnd Bergmann <arnd@arndb.de> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - " open list <linux-kernel@vger.kernel.org>\0" + "From\0jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)\0" + "Subject\0[PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" + "Date\0Mon, 19 Mar 2018 16:42:05 +0200\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Fri, Mar 16, 2018 at 08:36:52AM -0400, Mimi Zohar wrote:\n" @@ -28,18 +20,18 @@ "> > > > \n" "> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" "> > > \n" - "> > > With this patch, the Pi doesn't find the TPM. \302\240I'm seeing the\n" + "> > > With this patch, the Pi doesn't find the TPM. ?I'm seeing the\n" "> > > following line in dmesg.\n" "> > > \n" - "> > > [\302\240\302\240\302\240\302\2401.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" + "> > > [????1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" "> > \n" "> > Thank you for reporting this Mimi. Does it have TPM1/TPM2?\n" "> \n" - "> The pi has a TPM 2.0 attached to the GPIO. \302\240James pointed out the\n" + "> The pi has a TPM 2.0 attached to the GPIO. ?James pointed out the\n" "> change in return codes.\n" "> \n" "> \n" - "> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> chip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> -\n" "> - return 0;\n" @@ -54,6 +46,10 @@ "Oops, thank you James and Mimi for pointing this out. I'll refine\n" "the patch set.\n" "\n" - /Jarkko + "/Jarkko\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -a18a872e45799d8efaefe46fa8166f01289bff433ef83ee514646d9bee1a6de2 +7207e7f05c9212aa929b029b055b6bc908ec83699d53cd86385625a3d7d62747
diff --git a/a/1.txt b/N3/1.txt index d0ac4a5..906fd41 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -20,7 +20,7 @@ On Fri, Mar 16, 2018 at 08:36:52AM -0400, Mimi Zohar wrote: > change in return codes. > > -> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > chip->flags |= TPM_CHIP_FLAG_TPM2; > - > - return 0; diff --git a/a/content_digest b/N3/content_digest index a3f1fbc..fecb848 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -5,7 +5,7 @@ "ref\01521203812.3503.19.camel@linux.vnet.ibm.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 19 Mar 2018 14:42:05 +0000\0" + "Date\0Mon, 19 Mar 2018 16:42:05 +0200\0" "To\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" "Cc\0linux-integrity@vger.kernel.org" linux-security-module@vger.kernel.org @@ -39,7 +39,7 @@ "> change in return codes.\n" "> \n" "> \n" - "> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> chip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> -\n" "> - return 0;\n" @@ -56,4 +56,4 @@ "\n" /Jarkko -a18a872e45799d8efaefe46fa8166f01289bff433ef83ee514646d9bee1a6de2 +4d3d20266c952c3cb6697f5201786df6548dc1632140d6f14f8f6131676cbf0b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.