All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	kernel@pengutronix.de, Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@free-electrons.com>
Subject: Re: [PATCH 0/4] net: dsa: mv88e6xxx: novice fixes and irq handling
Date: Mon, 19 Mar 2018 17:37:13 +0100	[thread overview]
Message-ID: <20180319163713.GH26039@lunn.ch> (raw)
In-Reply-To: <20180319100523.24498-1-u.kleine-koenig@pengutronix.de>

> 	interrupt-parent = <&gpiosb>;
> 	interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
> 
> to the switch of the espressobin's dtb, the irq couldn't be used. The
> reason is the interaction of several things:
> 
>  - On the first try to probe the switch, the driver did:
> 
> 	irq = of_irq_get(np, 0);
> 	request_threaded_irq(irq, NULL, func, IRQF_ONESHOT | IRQF_TRIGGER_FALLING, ...);

Hi Uwe

It looks like we should just drop IRQF_TRIGGER_FALLING from here. The
interrupt trigger will be configured by of_irq_get(). All the current
DT files actually list it as IRQ_TYPE_LEVEL_LOW.

> When I tested the second change however the driver still failed
> because the gpio controller doesn't support level sensitive
> irqs. :-|

Do you have documentation for the SoC? Is it a hardware limitation, or
just missing from the pinctrl driver?

     Andrew

  parent reply	other threads:[~2018-03-19 16:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 10:05 [PATCH 0/4] net: dsa: mv88e6xxx: novice fixes and irq handling Uwe Kleine-König
2018-03-19 10:05 ` [PATCH 1/4] net: dsa: mv88e6xxx: Fix name of switch 88E6141 Uwe Kleine-König
2018-03-19 11:58   ` Andrew Lunn
2018-03-19 10:05 ` [PATCH 2/4] net: dsa: mv88e6xxx: fix typo in a comment Uwe Kleine-König
2018-03-19 11:58   ` Andrew Lunn
2018-03-19 10:05 ` [PATCH 3/4] net: dsa: mv88e6xxx: fix interrupt name for g2 irq Uwe Kleine-König
2018-03-19 11:59   ` Andrew Lunn
2018-03-19 10:05 ` [PATCH 4/4] net: dsa: mv88e6xxx: guess number of g1 irqs Uwe Kleine-König
2018-03-19 12:01   ` Andrew Lunn
2018-03-19 12:24 ` [PATCH 0/4] net: dsa: mv88e6xxx: novice fixes and irq handling Andrew Lunn
2018-03-19 16:37 ` Andrew Lunn [this message]
2018-03-20  9:30   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319163713.GH26039@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=kernel@pengutronix.de \
    --cc=marc.zyngier@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.