From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH 3.18 33/68] drm/radeon: Fail fb creation from imported dma-bufs. Date: Mon, 19 Mar 2018 19:06:11 +0100 Message-ID: <20180319171832.433485054@linuxfoundation.org> References: <20180319171827.899658615@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180319171827.899658615-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Greg Kroah-Hartman , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Christopher James Halse Rogers , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sasha Levin , stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= My4xOC1zdGFibGUgcmV2aWV3IHBhdGNoLiAgSWYgYW55b25lIGhhcyBhbnkgb2JqZWN0aW9ucywg cGxlYXNlIGxldCBtZSBrbm93LgoKLS0tLS0tLS0tLS0tLS0tLS0tCgpGcm9tOiBDaHJpc3RvcGhl ciBKYW1lcyBIYWxzZSBSb2dlcnMgPGNocmlzdG9waGVyLmhhbHNlLnJvZ2Vyc0BjYW5vbmljYWwu Y29tPgoKClsgVXBzdHJlYW0gY29tbWl0IGEyOTQwNDNiMmZiZDhkZTY5ZDE2MTQ1N2VkMGM3YTQw MjZiYmZhNWEgXQoKQW55IHVzZSBvZiB0aGUgZnJhbWVidWZmZXIgd2lsbCBtaWdyYXRlIGl0IHRv IFZSQU0sIHdoaWNoIGlzIG5vdCBzZW5zaWJsZSBmb3IKYW4gaW1wb3J0ZWQgZG1hLWJ1Zi4KCnYy OiBVc2UgRFJNX0RFQlVHX0tNUyB0byBwcmV2ZW50IHVzZXJzcGFjZSBhY2NpZGVudGFsbHkgc3Bh bW1pbmcgZG1lc2cuCgpSZXZpZXdlZC1ieTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVy QGFtZC5jb20+ClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmln QGFtZC5jb20+ClNpZ25lZC1vZmYtYnk6IENocmlzdG9waGVyIEphbWVzIEhhbHNlIFJvZ2VycyA8 Y2hyaXN0b3BoZXIuaGFsc2Uucm9nZXJzQGNhbm9uaWNhbC5jb20+CkNDOiBhbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpTaWduZWQtb2ZmLWJ5OiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5k ZXVjaGVyQGFtZC5jb20+ClNpZ25lZC1vZmYtYnk6IFNhc2hhIExldmluIDxhbGV4YW5kZXIubGV2 aW5AbWljcm9zb2Z0LmNvbT4KU2lnbmVkLW9mZi1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVn a2hAbGludXhmb3VuZGF0aW9uLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVv bl9kaXNwbGF5LmMgfCAgICA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygr KQoKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGlzcGxheS5jCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rpc3BsYXkuYwpAQCAtMTMyMCw2ICsxMzIwLDEy IEBAIHJhZGVvbl91c2VyX2ZyYW1lYnVmZmVyX2NyZWF0ZShzdHJ1Y3QgZHIKIAkJcmV0dXJuIEVS Ul9QVFIoLUVOT0VOVCk7CiAJfQogCisJLyogSGFuZGxlIGlzIGltcG9ydGVkIGRtYS1idWYsIHNv IGNhbm5vdCBiZSBtaWdyYXRlZCB0byBWUkFNIGZvciBzY2Fub3V0ICovCisJaWYgKG9iai0+aW1w b3J0X2F0dGFjaCkgeworCQlEUk1fREVCVUdfS01TKCJDYW5ub3QgY3JlYXRlIGZyYW1lYnVmZmVy IGZyb20gaW1wb3J0ZWQgZG1hX2J1ZlxuIik7CisJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwor CX0KKwogCXJhZGVvbl9mYiA9IGt6YWxsb2Moc2l6ZW9mKCpyYWRlb25fZmIpLCBHRlBfS0VSTkVM KTsKIAlpZiAocmFkZW9uX2ZiID09IE5VTEwpIHsKIAkJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVu Y2VfdW5sb2NrZWQob2JqKTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELu7mVpvq2+eZAd/ZO9fRLAj/OqUvEntC2ArDfbNVjlse+7PWQHMG4mJ6uRdZhF0KUdPc3lj ARC-Seal: i=1; a=rsa-sha256; t=1521483010; cv=none; d=google.com; s=arc-20160816; b=nrMXdbOySXt60viTfFFW0qcJzbxQ41vqPk35vRONGoyE7OcVCZZj4c4yGPjy3sdszh AtO86XByzmNpLsm6K7nKavVz568zuYJhBVOX2Q9gj18rNu0tomKyXjYoh91rJv7dpF+z MPGrkPq5YeunaN1LbkIWpeDRDaXtFHqKPSJELGDmQs+LD4Ph/eutUTo65kCubl53hbWT n/ij+BYqRb/FrzPSL4cVn0um17MlPul+cE236igeVbIbvFgdMsNVtYHSPIOqKHlVq0sU 5zrxhsxh1GDSLO1dmAR142urVAuxPnqMCq6ikkDLcvUU6PiWTl5LBIVfxFlFpx+lHZQe CSTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=APgrhFFnz5F/rKmynD7LhwNhl8qjoWwaEbObtmIuF2M=; b=Q1cQTJ9WgixCgg1Kq0iOA0xkSsrlUtrwSFuxd+WhjN940AciLdtqlKcqTeInAdRGFY /FQdNuiDIWGaHPO+fdowcW59D8A1+CArlPmmOEMHdlhktvrAjCpiNT0BBu3UJbAp92dR DiRgNlAisiDJU3GZHq2XegqMkNY8BdWlDjwh7xrpJbYao57OJOb8WslcCi1q09oKkPmC dc5BkCFlBvoPqKpJKye3egZGqn6oR/preGIaEoRWr8dIKimAAvmyW4MaPIudgz9BOQfR ZqnY1AZmFoV5l7GKTHSvomDOUB1ae/mB5yz08si8lnJfX7YbH6a5gAkZc/GP9JoGSDJc 1GmA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Michel=20D=C3=A4nzer?= , =?UTF-8?q?Christian=20K=C3=B6nig?= , Christopher James Halse Rogers , amd-gfx@lists.freedesktop.org, Alex Deucher , Sasha Levin Subject: [PATCH 3.18 33/68] drm/radeon: Fail fb creation from imported dma-bufs. Date: Mon, 19 Mar 2018 19:06:11 +0100 Message-Id: <20180319171832.433485054@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319171827.899658615@linuxfoundation.org> References: <20180319171827.899658615@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1595390568975323259?= X-GMAIL-MSGID: =?utf-8?q?1595390568975323259?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christopher James Halse Rogers [ Upstream commit a294043b2fbd8de69d161457ed0c7a4026bbfa5a ] Any use of the framebuffer will migrate it to VRAM, which is not sensible for an imported dma-buf. v2: Use DRM_DEBUG_KMS to prevent userspace accidentally spamming dmesg. Reviewed-by: Michel Dänzer Reviewed-by: Christian König Signed-off-by: Christopher James Halse Rogers CC: amd-gfx@lists.freedesktop.org Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/radeon/radeon_display.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -1320,6 +1320,12 @@ radeon_user_framebuffer_create(struct dr return ERR_PTR(-ENOENT); } + /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */ + if (obj->import_attach) { + DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n"); + return ERR_PTR(-EINVAL); + } + radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL); if (radeon_fb == NULL) { drm_gem_object_unreference_unlocked(obj);