From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELs24n96mtOSQOwGiPzgiNEUcS5Nof7gMzOVQxX2dVwA/bK9dPz7Z9YuFGe1ETOlNy5i9RR7 ARC-Seal: i=1; a=rsa-sha256; t=1521484211; cv=none; d=google.com; s=arc-20160816; b=Nzu4QOJ1jx5Da4gdoNeCeLIqOFxHy9W+HVGgIN77EKV/8yR+q0KCcTlv5M2UoF/F5B HDpgMu/ey7utd2UWT76Rz8aD01nkbPYWkR54JAiAzbMAj9UMBgJ7fFDvp4UoOsX2viHg cEoiIGuH74ohed4I9NthujIpK2z5Hlu1g12TddO4IYwNcN4B78CvzNNe8UQqPOOQjB+8 UVqiI0ncyzUgT38X6eyX9PHNVm2d6bvTZrSIVVk7Ymn72TS++TVkKhPADcmLEpdZduBo AXzKj3kkwCRJgp+B8yVJDggihHZcHws5Nowg9nXU7zTOKEz3Tq+1ovpYHTWYEYXxByYu F3aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=IOkMM7z5M840wjg3ekGCxu2y6E+XhlkggwLVEftVGyk=; b=ZzuJ/W3B69F2qvwgAg64duJgInw6fKnYvnNo+tH6+orpB0xlVzQuwAY1/oCq3hpa7J NY2cvUSyAu5JmQo+ihAzJocI5FHZVRsOYI+iKpZvIQW2p2gt+Ov+Ll8qsOuDOLFGEz/g f8gjPb641H6+h0v4H8MsqLszqXQy6JxooCjCxdKIK4KNehOTEs4skMT9kTuGkkiF1cu5 4k0esXYeM/l4FQznW/yupbp4MwzlMRassI+N/uKG9n4b6FTRW54ACflKtoBtB2mFA1NM I4bBycSOaxuNQUdJz6zy1zDssR7Xp177vyqjJoQ1V3DrHDyQVlNQS+E9BvUKfgVftzrI C6iw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Will Deacon , Christoffer Dall , Ard Biesheuvel , Marc Zyngier Subject: [PATCH 4.14 22/41] KVM: arm/arm64: Reduce verbosity of KVM init log Date: Mon, 19 Mar 2018 19:08:22 +0100 Message-Id: <20180319180733.701035078@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180732.195217948@linuxfoundation.org> References: <20180319180732.195217948@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1595391829188994151?= X-GMAIL-MSGID: =?utf-8?q?1595391829188994151?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ard Biesheuvel commit 76600428c3677659e3c3633bb4f2ea302220a275 upstream. On my GICv3 system, the following is printed to the kernel log at boot: kvm [1]: 8-bit VMID kvm [1]: IDMAP page: d20e35000 kvm [1]: HYP VA range: 800000000000:ffffffffffff kvm [1]: vgic-v2@2c020000 kvm [1]: GIC system register CPU interface enabled kvm [1]: vgic interrupt IRQ1 kvm [1]: virtual timer IRQ4 kvm [1]: Hyp mode initialized successfully The KVM IDMAP is a mapping of a statically allocated kernel structure, and so printing its physical address leaks the physical placement of the kernel when physical KASLR in effect. So change the kvm_info() to kvm_debug() to remove it from the log output. While at it, trim the output a bit more: IRQ numbers can be found in /proc/interrupts, and the HYP VA and vgic-v2 lines are not highly informational either. Cc: Acked-by: Will Deacon Acked-by: Christoffer Dall Signed-off-by: Ard Biesheuvel Signed-off-by: Marc Zyngier Signed-off-by: Greg Kroah-Hartman --- virt/kvm/arm/arch_timer.c | 2 +- virt/kvm/arm/mmu.c | 6 +++--- virt/kvm/arm/vgic/vgic-v2.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) --- a/virt/kvm/arm/arch_timer.c +++ b/virt/kvm/arm/arch_timer.c @@ -602,7 +602,7 @@ int kvm_timer_hyp_init(void) return err; } - kvm_info("virtual timer IRQ%d\n", host_vtimer_irq); + kvm_debug("virtual timer IRQ%d\n", host_vtimer_irq); cpuhp_setup_state(CPUHP_AP_KVM_ARM_TIMER_STARTING, "kvm/arm/timer:starting", kvm_timer_starting_cpu, --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -1760,9 +1760,9 @@ int kvm_mmu_init(void) */ BUG_ON((hyp_idmap_start ^ (hyp_idmap_end - 1)) & PAGE_MASK); - kvm_info("IDMAP page: %lx\n", hyp_idmap_start); - kvm_info("HYP VA range: %lx:%lx\n", - kern_hyp_va(PAGE_OFFSET), kern_hyp_va(~0UL)); + kvm_debug("IDMAP page: %lx\n", hyp_idmap_start); + kvm_debug("HYP VA range: %lx:%lx\n", + kern_hyp_va(PAGE_OFFSET), kern_hyp_va(~0UL)); if (hyp_idmap_start >= kern_hyp_va(PAGE_OFFSET) && hyp_idmap_start < kern_hyp_va(~0UL) && --- a/virt/kvm/arm/vgic/vgic-v2.c +++ b/virt/kvm/arm/vgic/vgic-v2.c @@ -380,7 +380,7 @@ int vgic_v2_probe(const struct gic_kvm_i kvm_vgic_global_state.type = VGIC_V2; kvm_vgic_global_state.max_gic_vcpus = VGIC_V2_MAX_CPUS; - kvm_info("vgic-v2@%llx\n", info->vctrl.start); + kvm_debug("vgic-v2@%llx\n", info->vctrl.start); return 0; out: