From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH 4.9 121/241] drm/radeon: Fail fb creation from imported dma-bufs. Date: Mon, 19 Mar 2018 19:06:26 +0100 Message-ID: <20180319180756.211122225@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180319180751.172155436-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Greg Kroah-Hartman , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Christopher James Halse Rogers , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sasha Levin , stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= NC45LXN0YWJsZSByZXZpZXcgcGF0Y2guICBJZiBhbnlvbmUgaGFzIGFueSBvYmplY3Rpb25zLCBw bGVhc2UgbGV0IG1lIGtub3cuCgotLS0tLS0tLS0tLS0tLS0tLS0KCkZyb206IENocmlzdG9waGVy IEphbWVzIEhhbHNlIFJvZ2VycyA8Y2hyaXN0b3BoZXIuaGFsc2Uucm9nZXJzQGNhbm9uaWNhbC5j b20+CgoKWyBVcHN0cmVhbSBjb21taXQgYTI5NDA0M2IyZmJkOGRlNjlkMTYxNDU3ZWQwYzdhNDAy NmJiZmE1YSBdCgpBbnkgdXNlIG9mIHRoZSBmcmFtZWJ1ZmZlciB3aWxsIG1pZ3JhdGUgaXQgdG8g VlJBTSwgd2hpY2ggaXMgbm90IHNlbnNpYmxlIGZvcgphbiBpbXBvcnRlZCBkbWEtYnVmLgoKdjI6 IFVzZSBEUk1fREVCVUdfS01TIHRvIHByZXZlbnQgdXNlcnNwYWNlIGFjY2lkZW50YWxseSBzcGFt bWluZyBkbWVzZy4KClJldmlld2VkLWJ5OiBNaWNoZWwgRMOkbnplciA8bWljaGVsLmRhZW56ZXJA YW1kLmNvbT4KUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoZXIgSmFtZXMgSGFsc2UgUm9nZXJzIDxj aHJpc3RvcGhlci5oYWxzZS5yb2dlcnNAY2Fub25pY2FsLmNvbT4KQ0M6IGFtZC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnClNpZ25lZC1vZmYtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRl dWNoZXJAYW1kLmNvbT4KU2lnbmVkLW9mZi1ieTogU2FzaGEgTGV2aW4gPGFsZXhhbmRlci5sZXZp bkBtaWNyb3NvZnQuY29tPgpTaWduZWQtb2ZmLWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdr aEBsaW51eGZvdW5kYXRpb24ub3JnPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9u X2Rpc3BsYXkuYyB8ICAgIDYgKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCsp CgotLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kaXNwbGF5LmMKKysrIGIvZHJp dmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGlzcGxheS5jCkBAIC0xMzUyLDYgKzEzNTIsMTIg QEAgcmFkZW9uX3VzZXJfZnJhbWVidWZmZXJfY3JlYXRlKHN0cnVjdCBkcgogCQlyZXR1cm4gRVJS X1BUUigtRU5PRU5UKTsKIAl9CiAKKwkvKiBIYW5kbGUgaXMgaW1wb3J0ZWQgZG1hLWJ1Ziwgc28g Y2Fubm90IGJlIG1pZ3JhdGVkIHRvIFZSQU0gZm9yIHNjYW5vdXQgKi8KKwlpZiAob2JqLT5pbXBv cnRfYXR0YWNoKSB7CisJCURSTV9ERUJVR19LTVMoIkNhbm5vdCBjcmVhdGUgZnJhbWVidWZmZXIg ZnJvbSBpbXBvcnRlZCBkbWFfYnVmXG4iKTsKKwkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7CisJ fQorCiAJcmFkZW9uX2ZiID0ga3phbGxvYyhzaXplb2YoKnJhZGVvbl9mYiksIEdGUF9LRVJORUwp OwogCWlmIChyYWRlb25fZmIgPT0gTlVMTCkgewogCQlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5j ZV91bmxvY2tlZChvYmopOwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdm eAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELuq/z29NtjqvI09Kf+MjJcwIfK+uDvXKwyB5PQCwn7I1Se+5old00QJo0gjL6i1Q7eSTkGt ARC-Seal: i=1; a=rsa-sha256; t=1521483799; cv=none; d=google.com; s=arc-20160816; b=onVwQrfOfrz0623V1K90p6R1U6BJiyD892Tp2OBfy0V9dHw8zQl8iM5QCdK8HfHQRV Z1Pe/UrqGRsP3Nk9ZIMX4pH/MxMbNL0l9sKUKYPe8dRgD+XLHS8VU+3DH1W7CBjGgvwv faOgrVR4AVU5OOLTKkFMEh546G8svwzzMaJiT8dF8YeUbXCX2Oz9lFup1Fz6W6IPQGfh MVDEXWGDE/aRF358scYXHs58M1GTb/n1Xu3PlS2WEwLzwt+RUQkiNDU6ZE7xNaGvMDLF Bm2qGMyzTWKNeTI0yBH1k1qvEcti67ok5pvTo6WozD4DPTidgm2bjI2YUzrXKPyMKQdj 8XVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=whYHpsAcbCHlX/uDBv5u1NtWlK/cH3LRVM2QYguc2qA=; b=mIRca4Y/3ti9IiAK8BMiQSGnpk2YfPk1Cs4X5E6NlsTG3uhwkupUJqjc2EnXqWok07 45BmWYVDkVH7m3SLv3hyb/i1NCWZg1/hrng77m9jWJGUPJpsAzR6/10OlmKym6YPz3J6 EisqQ6kiGTqOwAzYvLPbhL8Y6om3uFHRNsIqDoXpCooA+yXnUjP92XiofFS9rQVUskEd lJEkYX8+qRbaXVTe0Y/kNGQyzTSsh1Df4chFa7Xz1vsvIdGyeUgmDZ3LsDwPfxRvy2O/ uTBdt9F3vjjk5ErfWd+fYcEyu4q0NpXMI3Aow2m+SR8D5YfUH8pur61UnCMY71TNnzPs Mi4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Michel=20D=C3=A4nzer?= , =?UTF-8?q?Christian=20K=C3=B6nig?= , Christopher James Halse Rogers , amd-gfx@lists.freedesktop.org, Alex Deucher , Sasha Levin Subject: [PATCH 4.9 121/241] drm/radeon: Fail fb creation from imported dma-bufs. Date: Mon, 19 Mar 2018 19:06:26 +0100 Message-Id: <20180319180756.211122225@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319180751.172155436@linuxfoundation.org> References: <20180319180751.172155436@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1595390568975323259?= X-GMAIL-MSGID: =?utf-8?q?1595391397114607257?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christopher James Halse Rogers [ Upstream commit a294043b2fbd8de69d161457ed0c7a4026bbfa5a ] Any use of the framebuffer will migrate it to VRAM, which is not sensible for an imported dma-buf. v2: Use DRM_DEBUG_KMS to prevent userspace accidentally spamming dmesg. Reviewed-by: Michel Dänzer Reviewed-by: Christian König Signed-off-by: Christopher James Halse Rogers CC: amd-gfx@lists.freedesktop.org Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/radeon/radeon_display.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -1352,6 +1352,12 @@ radeon_user_framebuffer_create(struct dr return ERR_PTR(-ENOENT); } + /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */ + if (obj->import_attach) { + DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n"); + return ERR_PTR(-EINVAL); + } + radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL); if (radeon_fb == NULL) { drm_gem_object_unreference_unlocked(obj);