From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] New Defects reported by Coverity Scan for batctl
Date: Tue, 20 Mar 2018 02:09:35 +0100 [thread overview]
Message-ID: <20180320010935.GE1798@otheros> (raw)
In-Reply-To: <5aaf0fb1c41b_2bda2abf4cb1af68668dc@node1.mail>
On Mon, Mar 19, 2018 at 01:17:37AM +0000, scan-admin@coverity.com wrote:
[...]
> ________________________________________________________________________________________________________
> *** CID 174547: Incorrect expression (COPY_PASTE_ERROR)
> /netlink.c: 255 in info_callback()
> 249 else
> 250 mcast_flags = -EOPNOTSUPP;
> 251
> 252 if (attrs[BATADV_ATTR_MCAST_FLAGS_PRIV])
> 253 mcast_flags_priv = nla_get_u32(attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]);
> 254 else
> >>> CID 174547: Incorrect expression (COPY_PASTE_ERROR)
> >>> "mcast_flags" in "mcast_flags = -95L" looks like a copy-paste error.
> 255 mcast_flags = -EOPNOTSUPP;
[...]
Now this is officially the second time a code/patch reviewing
algorithm creeps me out :D.
"Looks like", yeah... and even worse, the AI is actually right...
I will send a fix :).
Cheers
parent reply other threads:[~2018-03-20 1:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5aaf0fb1c41b_2bda2abf4cb1af68668dc@node1.mail>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320010935.GE1798@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.