From: Al Viro <viro@ZenIV.linux.org.uk>
To: sparclinux@vger.kernel.org
Subject: Re: sparc_pipe(2)
Date: Tue, 20 Mar 2018 03:42:00 +0000 [thread overview]
Message-ID: <20180320034200.GZ30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180319.211125.314781796727440151.davem@davemloft.net>
On Mon, Mar 19, 2018 at 09:11:25PM -0400, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Tue, 20 Mar 2018 00:12:24 +0000
>
> > Am I missing something here, or is it simply that the thing predates
> > current_pt_regs()?
>
> It probably just predates current_pt_regs(), yes.
OK... Another fun question in the same area:
asmlinkage long sys32_ftruncate64(unsigned int fd, unsigned long high, unsigned long low)
{
if ((int)high < 0)
return -EINVAL;
else
return sys_ftruncate(fd, (high << 32) | low);
}
Is there any reason we want to check high right there? After all,
sys_ftruncate() will produce exactly that on MSB of its second
argument set... The same goes for sys32_truncate() - sys_truncate()
will yield -EINVAL on negative loff_t.
next prev parent reply other threads:[~2018-03-20 3:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 1:11 sparc_pipe(2) David Miller
2018-03-20 3:42 ` Al Viro [this message]
2018-03-20 14:13 ` sparc_pipe(2) David Miller
2018-03-20 17:02 ` sparc_pipe(2) Al Viro
2018-03-20 18:22 ` sparc_pipe(2) David Miller
2018-03-20 23:02 ` sparc_pipe(2) Al Viro
2018-03-22 17:07 ` sparc_pipe(2) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320034200.GZ30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.