From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v8,01/12] drivers: base: Unified device connection lookup From: Greg Kroah-Hartman Message-Id: <20180320092004.GA21081@kroah.com> Date: Tue, 20 Mar 2018 10:20:04 +0100 To: Heikki Krogerus Cc: Hans de Goede , Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Guenter Roeck , Jun Li , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gV2VkLCBNYXIgMTQsIDIwMTggYXQgMDQ6MTI6MDRQTSArMDMwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IFNldmVyYWwgZnJhbWV3b3JrcyAtIGNsaywgZ3BpbywgcGh5LCBwbXcsIGV0Yy4g LSBtYWludGFpbgo+IGxvb2t1cCB0YWJsZXMgZm9yIGRlc2NyaWJpbmcgY29ubmVjdGlvbnMgYW5k IHByb3ZpZGUgY3VzdG9tCj4gQVBJIGZvciBoYW5kbGluZyB0aGVtLiBUaGlzIGludHJvZHVjZXMg YSBzaW5nbGUgZ2VuZXJpYwo+IGxvb2t1cCB0YWJsZSBhbmQgQVBJIGZvciB0aGUgY29ubmVjdGlv bnMuCj4gCj4gVGhlIG1vdGl2YXRpb24gZm9yIHRoaXMgY29tbWl0IGlzIGNlbnRyYWxpemluZyB0 aGUKPiBjb25uZWN0aW9uIGxvb2t1cCwgYnV0IHRoZSBnb2FsIGlzIHRvIHVsdGltYXRlbHkgZXh0 cmFjdCB0aGUKPiBjb25uZWN0aW9uIGRlc2NyaXB0aW9ucyBhbHNvIGZyb20gZmlybXdhcmUgYnkg dXNpbmcgdGhlCj4gZndub2RlX2dyYXBoXyogZnVuY3Rpb25zIGFuZCBvdGhlciBtZWNoYW5pc21z IHRoYXQgYXJlCj4gYXZhaWxhYmxlLgo+IAo+IFJldmlld2VkLWJ5OiBIYW5zIGRlIEdvZWRlIDxo ZGVnb2VkZUByZWRoYXQuY29tPgo+IFJldmlld2VkLWJ5OiBBbmR5IFNoZXZjaGVua28gPGFuZHku c2hldmNoZW5rb0BnbWFpbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSGVpa2tpIEtyb2dlcnVzIDxo ZWlra2kua3JvZ2VydXNAbGludXguaW50ZWwuY29tPgo+IC0tLQo+IENoYW5nZXMgaW4gdjg6Cj4g LSBObyBsb25nZXIgdXNpbmcgcmN1LgoKT2ssIGJ1dCB0aGVuOgoKPiArdm9pZCAqZGV2aWNlX2Nv bm5lY3Rpb25fZmluZF9tYXRjaChzdHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0IGNoYXIgKmNvbl9p ZCwKPiArCQkJICAgICAgIHZvaWQgKmRhdGEsCj4gKwkJCSAgICAgICB2b2lkICooKm1hdGNoKShz dHJ1Y3QgZGV2aWNlX2Nvbm5lY3Rpb24gKmNvbiwKPiArCQkJCQkgICAgICBpbnQgZXAsIHZvaWQg KmRhdGEpKQo+ICt7Cj4gKwljb25zdCBjaGFyICpkZXZuYW1lID0gZGV2X25hbWUoZGV2KTsKPiAr CXN0cnVjdCBkZXZpY2VfY29ubmVjdGlvbiAqY29uOwo+ICsJdm9pZCAqcmV0ID0gTlVMTDsKPiAr CWludCBlcDsKPiArCj4gKwlpZiAoIW1hdGNoKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKPiArCW11 dGV4X2xvY2soJmRldmNvbl9sb2NrKTsKPiArCj4gKwlsaXN0X2Zvcl9lYWNoX2VudHJ5X3JjdShj b24sICZkZXZjb25fbGlzdCwgbGlzdCkgewoKX3JjdSBjYWxscyBldmVyeXdoZXJlIDooCgpEaWQg eW91IHNlbmQgb3V0IHRoZSByaWdodCB2ZXJzaW9uIG9mIHRoaXMgcGF0Y2g/CgpBbHNvLCBmdXJ0 aGVyIGRvd24geW91IGRvOgoKPiArI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ ICsjaW5jbHVkZSA8bGludXgvc3BpL3NwaS5oPgo+ICsjaW5jbHVkZSA8bGludXgvaTJjLmg+Cj4g KyNpbmNsdWRlIDxsaW51eC9wY2kuaD4KCkVlZWssICNpbmNsdWRlIGluIHRoZSBtaWRkbGUgb2Yg YSBmaWxlLCBub3QgZ29vZC4KCj4gKwo+ICtzdGF0aWMgc3RydWN0IGJ1c190eXBlICpnZW5lcmlj X21hdGNoX2J1c2VzW10gPSB7Cj4gKwkmcGxhdGZvcm1fYnVzX3R5cGUsCj4gKyNpZmRlZiBDT05G SUdfUENJCj4gKwkmcGNpX2J1c190eXBlLAo+ICsjZW5kaWYKPiArI2lmZGVmIENPTkZJR19JMkMK PiArCSZpMmNfYnVzX3R5cGUsCj4gKyNlbmRpZgo+ICsjaWZkZWYgQ09ORklHX1NQSV9NQVNURVIK PiArCSZzcGlfYnVzX3R5cGUsCj4gKyNlbmRpZgo+ICsJTlVMTCwKPiArfTsKCkNhbid0IHlvdSBq dXN0IGRlY2xhcmUgdGhlIGFib3ZlIGFzICJleHRlcm4iIHZhcmlhYmxlcyBhbmQgbm90IG5lZWQg dGhlCiNpbmNsdWRlPyAgWWVhaCwgY2hlY2twYXRjaCB3aWxsIGNvbXBsYWluLCBidXQgaXQgc2hv dWxkIGJlIGZpbmUgaGVyZSBhcwp3ZSByZWFsbHkgZG9uJ3Qgd2FudCB0aGUgZnVsbCAuaCBmaWxl cyBoZXJlIChvciBuZWVkIHRoZW0uKQoKPiArdm9pZCBkZXZpY2VfY29ubmVjdGlvbl9yZW1vdmUo c3RydWN0IGRldmljZV9jb25uZWN0aW9uICpjb24pCj4gK3sKPiArCW11dGV4X2xvY2soJmRldmNv bl9sb2NrKTsKPiArCWxpc3RfZGVsX3JjdSgmY29uLT5saXN0KTsKClNlZSwgcmN1PwoKdGhhbmtz LAoKZ3JlZyBrLWgKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBs aW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBt YWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92 Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup Date: Tue, 20 Mar 2018 10:20:04 +0100 Message-ID: <20180320092004.GA21081@kroah.com> References: <20180314131215.70833-1-heikki.krogerus@linux.intel.com> <20180314131215.70833-2-heikki.krogerus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180314131215.70833-2-heikki.krogerus@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Heikki Krogerus Cc: Hans de Goede , Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Guenter Roeck , Jun Li , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Wed, Mar 14, 2018 at 04:12:04PM +0300, Heikki Krogerus wrote: > Several frameworks - clk, gpio, phy, pmw, etc. - maintain > lookup tables for describing connections and provide custom > API for handling them. This introduces a single generic > lookup table and API for the connections. > > The motivation for this commit is centralizing the > connection lookup, but the goal is to ultimately extract the > connection descriptions also from firmware by using the > fwnode_graph_* functions and other mechanisms that are > available. > > Reviewed-by: Hans de Goede > Reviewed-by: Andy Shevchenko > Signed-off-by: Heikki Krogerus > --- > Changes in v8: > - No longer using rcu. Ok, but then: > +void *device_connection_find_match(struct device *dev, const char *con_id, > + void *data, > + void *(*match)(struct device_connection *con, > + int ep, void *data)) > +{ > + const char *devname = dev_name(dev); > + struct device_connection *con; > + void *ret = NULL; > + int ep; > + > + if (!match) > + return NULL; > + > + mutex_lock(&devcon_lock); > + > + list_for_each_entry_rcu(con, &devcon_list, list) { _rcu calls everywhere :( Did you send out the right version of this patch? Also, further down you do: > +#include > +#include > +#include > +#include Eeek, #include in the middle of a file, not good. > + > +static struct bus_type *generic_match_buses[] = { > + &platform_bus_type, > +#ifdef CONFIG_PCI > + &pci_bus_type, > +#endif > +#ifdef CONFIG_I2C > + &i2c_bus_type, > +#endif > +#ifdef CONFIG_SPI_MASTER > + &spi_bus_type, > +#endif > + NULL, > +}; Can't you just declare the above as "extern" variables and not need the #include? Yeah, checkpatch will complain, but it should be fine here as we really don't want the full .h files here (or need them.) > +void device_connection_remove(struct device_connection *con) > +{ > + mutex_lock(&devcon_lock); > + list_del_rcu(&con->list); See, rcu? thanks, greg k-h