From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] net: fec: sharing MDIO for two enet controllers
Date: Tue, 20 Mar 2018 09:51:50 +0100 [thread overview]
Message-ID: <20180320095150.6d1b2f62@karo-electronics.de> (raw)
In-Reply-To: <20180310011957.21801-4-peng.fan@nxp.com>
Hi,
On Sat, 10 Mar 2018 09:19:56 +0800 Peng Fan wrote:
> On i.MX6SX, 6UL and 7D, there are two enet controllers each has a
> MDIO port. But Some boards share one MDIO port for the two enets. So
> introduce a configuration CONFIG_FEC_MXC_MDIO_BASE to indicate
> the MDIO port for sharing.
>
This is already the case for i.MX28. There is no need to implement a
second mechanism to achieve the same result.
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/net/Kconfig | 7 +++++++
> drivers/net/fec_mxc.c | 9 +++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index de1947ccc1..3a468a7c59 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -147,6 +147,13 @@ config ETHOC
> help
> This MAC is present in OpenRISC and Xtensa XTFPGA boards.
>
> +config FEC_MXC_MDIO_BASE
> + hex "MDIO base address for the FEC controller"
> + depends on FEC_MXC
> + help
> + This specifies the MDIO registers base address. It is used when
> + two FEC controllers share MDIO bus.
> +
> config FEC_MXC
> bool "FEC Ethernet controller"
> depends on MX5 || MX6
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 2c3171ecc9..e8f8fef66a 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -1161,8 +1161,12 @@ int fecmxc_initialize_multi(bd_t *bd, int dev_id, int phy_id, uint32_t addr)
> * Only the first one can access the MDIO bus.
> */
> base_mii = MXS_ENET0_BASE;
> +#else
> +#ifdef CONFIG_FEC_MXC_MDIO_BASE
> + base_mii = CONFIG_FEC_MXC_MDIO_BASE;
> #else
> base_mii = addr;
> +#endif
> #endif
> debug("eth_init: fec_probe(bd, %i, %i) @ %08x\n", dev_id, phy_id, addr);
> bus = fec_get_miibus(base_mii, dev_id);
> @@ -1274,7 +1278,12 @@ static int fecmxc_probe(struct udevice *dev)
> fec_reg_setup(priv);
>
> priv->dev_id = dev->seq;
> +
> +#ifdef CONFIG_FEC_MXC_MDIO_BASE
> + bus = fec_get_miibus((ulong)CONFIG_FEC_MXC_MDIO_BASE, dev->seq);
> +#else
> bus = fec_get_miibus((ulong)priv->eth, dev->seq);
> +#endif
> if (!bus) {
> ret = -ENOMEM;
> goto err_mii;
Lothar Waßmann
next prev parent reply other threads:[~2018-03-20 8:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 1:19 [U-Boot] [PATCH 1/5] net: fec_mxc: Fix DM driver issue in recv Peng Fan
2018-03-10 1:19 ` [U-Boot] [PATCH 2/5] net: fec_mxc: simplify fec_get_miibus Peng Fan
2018-03-19 21:18 ` Joe Hershberger
2018-03-20 8:49 ` Lothar Waßmann
2018-03-20 9:29 ` Peng Fan
2018-03-21 19:13 ` Joe Hershberger
2018-03-21 19:20 ` Joe Hershberger
2018-03-10 1:19 ` [U-Boot] [PATCH 3/5] net: fec: set dev->seq to priv->dev_id Peng Fan
2018-03-19 21:19 ` Joe Hershberger
2018-03-10 1:19 ` [U-Boot] [PATCH 4/5] net: fec: sharing MDIO for two enet controllers Peng Fan
2018-03-19 21:21 ` Joe Hershberger
2018-03-20 8:51 ` Lothar Waßmann [this message]
2018-03-21 1:59 ` Peng Fan
2018-03-10 1:19 ` [U-Boot] [PATCH 5/5] net: fex_mxc: add i.MX6UL/SX/SL compatible Peng Fan
2018-03-19 21:21 ` Joe Hershberger
2018-03-19 21:17 ` [U-Boot] [PATCH 1/5] net: fec_mxc: Fix DM driver issue in recv Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320095150.6d1b2f62@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.