From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v8,01/12] drivers: base: Unified device connection lookup From: Heikki Krogerus Message-Id: <20180320100412.GI11689@kuha.fi.intel.com> Date: Tue, 20 Mar 2018 12:04:12 +0200 To: Greg Kroah-Hartman Cc: Hans de Goede , Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Guenter Roeck , Jun Li , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTA6MjA6MDRBTSArMDEwMCwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+IE9uIFdlZCwgTWFyIDE0LCAyMDE4IGF0IDA0OjEyOjA0UE0gKzAzMDAsIEhl aWtraSBLcm9nZXJ1cyB3cm90ZToKPiA+IFNldmVyYWwgZnJhbWV3b3JrcyAtIGNsaywgZ3Bpbywg cGh5LCBwbXcsIGV0Yy4gLSBtYWludGFpbgo+ID4gbG9va3VwIHRhYmxlcyBmb3IgZGVzY3JpYmlu ZyBjb25uZWN0aW9ucyBhbmQgcHJvdmlkZSBjdXN0b20KPiA+IEFQSSBmb3IgaGFuZGxpbmcgdGhl bS4gVGhpcyBpbnRyb2R1Y2VzIGEgc2luZ2xlIGdlbmVyaWMKPiA+IGxvb2t1cCB0YWJsZSBhbmQg QVBJIGZvciB0aGUgY29ubmVjdGlvbnMuCj4gPiAKPiA+IFRoZSBtb3RpdmF0aW9uIGZvciB0aGlz IGNvbW1pdCBpcyBjZW50cmFsaXppbmcgdGhlCj4gPiBjb25uZWN0aW9uIGxvb2t1cCwgYnV0IHRo ZSBnb2FsIGlzIHRvIHVsdGltYXRlbHkgZXh0cmFjdCB0aGUKPiA+IGNvbm5lY3Rpb24gZGVzY3Jp cHRpb25zIGFsc28gZnJvbSBmaXJtd2FyZSBieSB1c2luZyB0aGUKPiA+IGZ3bm9kZV9ncmFwaF8q IGZ1bmN0aW9ucyBhbmQgb3RoZXIgbWVjaGFuaXNtcyB0aGF0IGFyZQo+ID4gYXZhaWxhYmxlLgo+ ID4gCj4gPiBSZXZpZXdlZC1ieTogSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4K PiA+IFJldmlld2VkLWJ5OiBBbmR5IFNoZXZjaGVua28gPGFuZHkuc2hldmNoZW5rb0BnbWFpbC5j b20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBIZWlra2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0Bs aW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+IENoYW5nZXMgaW4gdjg6Cj4gPiAtIE5vIGxvbmdl ciB1c2luZyByY3UuCj4gCj4gT2ssIGJ1dCB0aGVuOgo+IAo+ID4gK3ZvaWQgKmRldmljZV9jb25u ZWN0aW9uX2ZpbmRfbWF0Y2goc3RydWN0IGRldmljZSAqZGV2LCBjb25zdCBjaGFyICpjb25faWQs Cj4gPiArCQkJICAgICAgIHZvaWQgKmRhdGEsCj4gPiArCQkJICAgICAgIHZvaWQgKigqbWF0Y2gp KHN0cnVjdCBkZXZpY2VfY29ubmVjdGlvbiAqY29uLAo+ID4gKwkJCQkJICAgICAgaW50IGVwLCB2 b2lkICpkYXRhKSkKPiA+ICt7Cj4gPiArCWNvbnN0IGNoYXIgKmRldm5hbWUgPSBkZXZfbmFtZShk ZXYpOwo+ID4gKwlzdHJ1Y3QgZGV2aWNlX2Nvbm5lY3Rpb24gKmNvbjsKPiA+ICsJdm9pZCAqcmV0 ID0gTlVMTDsKPiA+ICsJaW50IGVwOwo+ID4gKwo+ID4gKwlpZiAoIW1hdGNoKQo+ID4gKwkJcmV0 dXJuIE5VTEw7Cj4gPiArCj4gPiArCW11dGV4X2xvY2soJmRldmNvbl9sb2NrKTsKPiA+ICsKPiA+ ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9yY3UoY29uLCAmZGV2Y29uX2xpc3QsIGxpc3QpIHsKPiAK PiBfcmN1IGNhbGxzIGV2ZXJ5d2hlcmUgOigKPiAKPiBEaWQgeW91IHNlbmQgb3V0IHRoZSByaWdo dCB2ZXJzaW9uIG9mIHRoaXMgcGF0Y2g/Cj4gCj4gQWxzbywgZnVydGhlciBkb3duIHlvdSBkbzoK PiAKPiA+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+Cj4gPiArI2luY2x1ZGUg PGxpbnV4L3NwaS9zcGkuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvaTJjLmg+Cj4gPiArI2luY2x1 ZGUgPGxpbnV4L3BjaS5oPgo+IAo+IEVlZWssICNpbmNsdWRlIGluIHRoZSBtaWRkbGUgb2YgYSBm aWxlLCBub3QgZ29vZC4KPiAKPiA+ICsKPiA+ICtzdGF0aWMgc3RydWN0IGJ1c190eXBlICpnZW5l cmljX21hdGNoX2J1c2VzW10gPSB7Cj4gPiArCSZwbGF0Zm9ybV9idXNfdHlwZSwKPiA+ICsjaWZk ZWYgQ09ORklHX1BDSQo+ID4gKwkmcGNpX2J1c190eXBlLAo+ID4gKyNlbmRpZgo+ID4gKyNpZmRl ZiBDT05GSUdfSTJDCj4gPiArCSZpMmNfYnVzX3R5cGUsCj4gPiArI2VuZGlmCj4gPiArI2lmZGVm IENPTkZJR19TUElfTUFTVEVSCj4gPiArCSZzcGlfYnVzX3R5cGUsCj4gPiArI2VuZGlmCj4gPiAr CU5VTEwsCj4gPiArfTsKPiAKPiBDYW4ndCB5b3UganVzdCBkZWNsYXJlIHRoZSBhYm92ZSBhcyAi ZXh0ZXJuIiB2YXJpYWJsZXMgYW5kIG5vdCBuZWVkIHRoZQo+ICNpbmNsdWRlPyAgWWVhaCwgY2hl Y2twYXRjaCB3aWxsIGNvbXBsYWluLCBidXQgaXQgc2hvdWxkIGJlIGZpbmUgaGVyZSBhcwo+IHdl IHJlYWxseSBkb24ndCB3YW50IHRoZSBmdWxsIC5oIGZpbGVzIGhlcmUgKG9yIG5lZWQgdGhlbS4p CgpPSy4gSSdsbCBkZWNsYXJlIHRoZW0gYXMgZXh0ZXJuLgoKPiA+ICt2b2lkIGRldmljZV9jb25u ZWN0aW9uX3JlbW92ZShzdHJ1Y3QgZGV2aWNlX2Nvbm5lY3Rpb24gKmNvbikKPiA+ICt7Cj4gPiAr CW11dGV4X2xvY2soJmRldmNvbl9sb2NrKTsKPiA+ICsJbGlzdF9kZWxfcmN1KCZjb24tPmxpc3Qp Owo+IAo+IFNlZSwgcmN1PwoKVHJ1ZS4gSSdsbCBzZW5kIG9uZSBtb3JlIHZlcnNpb24uCgoKVGhh bmtzLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup Date: Tue, 20 Mar 2018 12:04:12 +0200 Message-ID: <20180320100412.GI11689@kuha.fi.intel.com> References: <20180314131215.70833-1-heikki.krogerus@linux.intel.com> <20180314131215.70833-2-heikki.krogerus@linux.intel.com> <20180320092004.GA21081@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180320092004.GA21081@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Hans de Goede , Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Guenter Roeck , Jun Li , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Tue, Mar 20, 2018 at 10:20:04AM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 14, 2018 at 04:12:04PM +0300, Heikki Krogerus wrote: > > Several frameworks - clk, gpio, phy, pmw, etc. - maintain > > lookup tables for describing connections and provide custom > > API for handling them. This introduces a single generic > > lookup table and API for the connections. > > > > The motivation for this commit is centralizing the > > connection lookup, but the goal is to ultimately extract the > > connection descriptions also from firmware by using the > > fwnode_graph_* functions and other mechanisms that are > > available. > > > > Reviewed-by: Hans de Goede > > Reviewed-by: Andy Shevchenko > > Signed-off-by: Heikki Krogerus > > --- > > Changes in v8: > > - No longer using rcu. > > Ok, but then: > > > +void *device_connection_find_match(struct device *dev, const char *con_id, > > + void *data, > > + void *(*match)(struct device_connection *con, > > + int ep, void *data)) > > +{ > > + const char *devname = dev_name(dev); > > + struct device_connection *con; > > + void *ret = NULL; > > + int ep; > > + > > + if (!match) > > + return NULL; > > + > > + mutex_lock(&devcon_lock); > > + > > + list_for_each_entry_rcu(con, &devcon_list, list) { > > _rcu calls everywhere :( > > Did you send out the right version of this patch? > > Also, further down you do: > > > +#include > > +#include > > +#include > > +#include > > Eeek, #include in the middle of a file, not good. > > > + > > +static struct bus_type *generic_match_buses[] = { > > + &platform_bus_type, > > +#ifdef CONFIG_PCI > > + &pci_bus_type, > > +#endif > > +#ifdef CONFIG_I2C > > + &i2c_bus_type, > > +#endif > > +#ifdef CONFIG_SPI_MASTER > > + &spi_bus_type, > > +#endif > > + NULL, > > +}; > > Can't you just declare the above as "extern" variables and not need the > #include? Yeah, checkpatch will complain, but it should be fine here as > we really don't want the full .h files here (or need them.) OK. I'll declare them as extern. > > +void device_connection_remove(struct device_connection *con) > > +{ > > + mutex_lock(&devcon_lock); > > + list_del_rcu(&con->list); > > See, rcu? True. I'll send one more version. Thanks, -- heikki