From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp3841300wmb; Tue, 20 Mar 2018 06:34:44 -0700 (PDT) X-Google-Smtp-Source: AG47ELvEoaqQxQPSbWWaeIWHFdlY2Eb+rAcTA4KjKXJSP6+P+WyKRSTTDTRhkaZNgD37VYY4N5i0 X-Received: by 10.55.149.135 with SMTP id x129mr24216151qkd.279.1521552884074; Tue, 20 Mar 2018 06:34:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521552884; cv=none; d=google.com; s=arc-20160816; b=zA0q34D6iju9Bb6dmlLfcbCT+kQeejKWJiYPuFlJ/Zd6u4yx1WyXV2+AJK/c7xhIAw w2ogLKE4yXIPBO333G6wQMFWFcO93uAAOGfmDy2JRpdZss8Kf/ZWHM3KqdrGpk7GrXTw dF5BzGov9FUzceHcilGfY89tBzFBqSnU8mIfCjDJ0ZPgmBZdMcDJrHEISUCHan/QyCHL yXmIJ8UQPJz1YZGPwl3W/Tlw5G5mzlyN8kxE+P8bhotMx9AFho25hkJT4fi4HkedLuhV MS1w37Hsd+WsqOI5LEX/JWBR9ZTucFU3m7x4HZAe0jsafvROm94ouLvK64nPC+iJvlrO wRzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date :arc-authentication-results; bh=JgRQKn/EwS2+i9jP/nWLHzUWNiE8sg/I+OLyUI5LEf4=; b=cJTttSrycqBrChgtaPnHR13+Vic7Q7VTrEQML0f87VOTo7i08p+9kiU2ld4z543nV0 etPWs9ApXzEEjU5d2JPTdHVH1kdxRwxS6l51rNlEZdLY5dwyc0T10ExrL31KQAIN8HQZ ZWLwM1Auupxnp8NWz9V555XL2178Cqwk/aIDzlSLWQAWYnoW0HrXpjZXdm8IurMkOhDY RPzTh3O/OiNXZD3oYx6MW5SgBlOEC6Xx5NRXHU25Ka+wWAUROestLe/9jfudLIlKOe0F ovnraFB8B0CXoN/eDSbMlGELnaPyhou+QAmHb+FwWbBmLiHRxTHzENSclCmzuV3aLrEr b/Hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v188si2776713qkc.226.2018.03.20.06.34.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Mar 2018 06:34:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHPX-0005YO-Hj for alex.bennee@linaro.org; Tue, 20 Mar 2018 09:34:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyEUg-0004uH-UY for qemu-devel@nongnu.org; Tue, 20 Mar 2018 06:27:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyEUf-0005ty-Of for qemu-devel@nongnu.org; Tue, 20 Mar 2018 06:27:50 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34642 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyEUX-0005jO-Kn; Tue, 20 Mar 2018 06:27:41 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A34CF40267D5; Tue, 20 Mar 2018 10:27:36 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 579772026609; Tue, 20 Mar 2018 10:27:21 +0000 (UTC) Date: Tue, 20 Mar 2018 10:27:19 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Message-ID: <20180320102719.GF4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 20 Mar 2018 10:27:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 20 Mar 2018 10:27:37 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'berrange@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 X-Mailman-Approved-At: Tue, 20 Mar 2018 09:27:42 -0400 Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , QEMU Developers , "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , David Hildenbrand , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm-devel , =?utf-8?B?SGVydsOp?= Poussineau , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Jason Wang , Artyom Tarasenko , Thomas Huth , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Fabien Chouteau , Greg Kurz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Alex Williamson , qemu-arm , Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , "open list:X86" , John Snow , Richard Henderson , Kevin Wolf , Alexander Graf , Qemu-block , Peter Crosthwaite , Hitoshi Mitake , Wen Congyang , qemu-s390x , Cornelia Huck , Laurent Vivier , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= , Igor Mammedov , Hannes Reinecke , Aurelien Jarno , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: XKOausZvQcTs On Tue, Mar 20, 2018 at 10:01:24AM +0000, Peter Maydell wrote: > On 20 March 2018 at 09:44, Daniel P. Berrang=C3=A9 wrote: > > We can follow what autoconf does, and add a check to configure to see= if > > there are generated files left in the source dir, when configuring wi= th > > builddir !=3D srcdir, and exit with error, telling user to clean thei= r > > src dir first. >=20 > We already do this in our makefile...it just doesn't check every > single generated file. Ah yes, indeed: $ make Makefile:59: *** This is an out of tree build but your source tree (/home/berrange/src/virt/qemu) seems to have been used for an in-tree build. You can fix this by running "make distclean && rm -rf *-linux-user *-softmmu" in your source tree. Stop. It is checking for existance of config-host.mak. We have a convenient list of generated files in $(GENERATED_FILES), so I wonder if there's a practical way to check all of those too. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 10:27:19 +0000 Message-ID: <20180320102719.GF4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyEUU-00013Y-Tc for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 10:27:38 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Peter Maydell Cc: Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , QEMU Developers , "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTA6MDE6MjRBTSArMDAwMCwgUGV0ZXIgTWF5ZGVsbCB3 cm90ZToKPiBPbiAyMCBNYXJjaCAyMDE4IGF0IDA5OjQ0LCBEYW5pZWwgUC4gQmVycmFuZ8OpIDxi ZXJyYW5nZUByZWRoYXQuY29tPiB3cm90ZToKPiA+IFdlIGNhbiBmb2xsb3cgd2hhdCBhdXRvY29u ZiBkb2VzLCBhbmQgYWRkIGEgY2hlY2sgdG8gY29uZmlndXJlIHRvIHNlZSBpZgo+ID4gdGhlcmUg YXJlIGdlbmVyYXRlZCBmaWxlcyBsZWZ0IGluIHRoZSBzb3VyY2UgZGlyLCB3aGVuIGNvbmZpZ3Vy aW5nIHdpdGgKPiA+IGJ1aWxkZGlyICE9IHNyY2RpciwgYW5kIGV4aXQgd2l0aCBlcnJvciwgdGVs bGluZyB1c2VyIHRvIGNsZWFuIHRoZWlyCj4gPiBzcmMgZGlyIGZpcnN0Lgo+IAo+IFdlIGFscmVh ZHkgZG8gdGhpcyBpbiBvdXIgbWFrZWZpbGUuLi5pdCBqdXN0IGRvZXNuJ3QgY2hlY2sgZXZlcnkK PiBzaW5nbGUgZ2VuZXJhdGVkIGZpbGUuCgpBaCB5ZXMsIGluZGVlZDoKCiQgbWFrZQpNYWtlZmls ZTo1OTogKioqIFRoaXMgaXMgYW4gb3V0IG9mIHRyZWUgYnVpbGQgYnV0IHlvdXIgc291cmNlIHRy ZWUKKC9ob21lL2JlcnJhbmdlL3NyYy92aXJ0L3FlbXUpIHNlZW1zIHRvIGhhdmUgYmVlbiB1c2Vk IGZvciBhbiBpbi10cmVlCmJ1aWxkLiBZb3UgY2FuIGZpeCB0aGlzIGJ5IHJ1bm5pbmcgIm1ha2Ug ZGlzdGNsZWFuICYmIHJtIC1yZiAqLWxpbnV4LXVzZXIKICotc29mdG1tdSIgaW4geW91ciBzb3Vy Y2UgdHJlZS4gIFN0b3AuCgoKSXQgaXMgY2hlY2tpbmcgZm9yIGV4aXN0YW5jZSBvZiBjb25maWct aG9zdC5tYWsuCgpXZSBoYXZlIGEgY29udmVuaWVudCBsaXN0IG9mIGdlbmVyYXRlZCBmaWxlcyBp biAkKEdFTkVSQVRFRF9GSUxFUyksIHNvCkkgd29uZGVyIGlmIHRoZXJlJ3MgYSBwcmFjdGljYWwg d2F5IHRvIGNoZWNrIGFsbCBvZiB0aG9zZSB0b28uCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6IGh0 dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20vcGhv dG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAgICAg ICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRhbmds ZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJhbmdl IDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 10:27:19 +0000 Message-ID: <20180320102719.GF4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , QEMU Developers , "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTA6MDE6MjRBTSArMDAwMCwgUGV0ZXIgTWF5ZGVsbCB3 cm90ZToKPiBPbiAyMCBNYXJjaCAyMDE4IGF0IDA5OjQ0LCBEYW5pZWwgUC4gQmVycmFuZ8OpIDxi ZXJyYW5nZUByZWRoYXQuY29tPiB3cm90ZToKPiA+IFdlIGNhbiBmb2xsb3cgd2hhdCBhdXRvY29u ZiBkb2VzLCBhbmQgYWRkIGEgY2hlY2sgdG8gY29uZmlndXJlIHRvIHNlZSBpZgo+ID4gdGhlcmUg YXJlIGdlbmVyYXRlZCBmaWxlcyBsZWZ0IGluIHRoZSBzb3VyY2UgZGlyLCB3aGVuIGNvbmZpZ3Vy aW5nIHdpdGgKPiA+IGJ1aWxkZGlyICE9IHNyY2RpciwgYW5kIGV4aXQgd2l0aCBlcnJvciwgdGVs bGluZyB1c2VyIHRvIGNsZWFuIHRoZWlyCj4gPiBzcmMgZGlyIGZpcnN0Lgo+IAo+IFdlIGFscmVh ZHkgZG8gdGhpcyBpbiBvdXIgbWFrZWZpbGUuLi5pdCBqdXN0IGRvZXNuJ3QgY2hlY2sgZXZlcnkK PiBzaW5nbGUgZ2VuZXJhdGVkIGZpbGUuCgpBaCB5ZXMsIGluZGVlZDoKCiQgbWFrZQpNYWtlZmls ZTo1OTogKioqIFRoaXMgaXMgYW4gb3V0IG9mIHRyZWUgYnVpbGQgYnV0IHlvdXIgc291cmNlIHRy ZWUKKC9ob21lL2JlcnJhbmdlL3NyYy92aXJ0L3FlbXUpIHNlZW1zIHRvIGhhdmUgYmVlbiB1c2Vk IGZvciBhbiBpbi10cmVlCmJ1aWxkLiBZb3UgY2FuIGZpeCB0aGlzIGJ5IHJ1bm5pbmcgIm1ha2Ug ZGlzdGNsZWFuICYmIHJtIC1yZiAqLWxpbnV4LXVzZXIKICotc29mdG1tdSIgaW4geW91ciBzb3Vy Y2UgdHJlZS4gIFN0b3AuCgoKSXQgaXMgY2hlY2tpbmcgZm9yIGV4aXN0YW5jZSBvZiBjb25maWct aG9zdC5tYWsuCgpXZSBoYXZlIGEgY29udmVuaWVudCBsaXN0IG9mIGdlbmVyYXRlZCBmaWxlcyBp biAkKEdFTkVSQVRFRF9GSUxFUyksIHNvCkkgd29uZGVyIGlmIHRoZXJlJ3MgYSBwcmFjdGljYWwg d2F5IHRvIGNoZWNrIGFsbCBvZiB0aG9zZSB0b28uCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6IGh0 dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20vcGhv dG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAgICAg ICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRhbmds ZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJhbmdl IDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs