From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v8,01/12] drivers: base: Unified device connection lookup From: Heikki Krogerus Message-Id: <20180320125240.GA25137@kuha.fi.intel.com> Date: Tue, 20 Mar 2018 14:52:40 +0200 To: Hans de Goede Cc: Greg Kroah-Hartman , Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Guenter Roeck , Jun Li , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDE6MjE6NTdQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBPbiAyMC0wMy0xOCAxMTozMiwgSGVpa2tpIEtyb2dlcnVzIHdyb3RlOgo+ID4gT24g VHVlLCBNYXIgMjAsIDIwMTggYXQgMTI6MDQ6MTJQTSArMDIwMCwgSGVpa2tpIEtyb2dlcnVzIHdy b3RlOgo+ID4gPiA+ID4gK3ZvaWQgZGV2aWNlX2Nvbm5lY3Rpb25fcmVtb3ZlKHN0cnVjdCBkZXZp Y2VfY29ubmVjdGlvbiAqY29uKQo+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ICsJbXV0ZXhfbG9jaygm ZGV2Y29uX2xvY2spOwo+ID4gPiA+ID4gKwlsaXN0X2RlbF9yY3UoJmNvbi0+bGlzdCk7Cj4gPiA+ ID4gCj4gPiA+ID4gU2VlLCByY3U/Cj4gPiA+IAo+ID4gPiBUcnVlLiBJJ2xsIHNlbmQgb25lIG1v cmUgdmVyc2lvbi4KPiA+IAo+ID4gQmVmb3JlIEkgZG8gdGhhdCwgSGFucywgY2FuIHlvdSBxdWlj a2x5IGNoZWNrIHRoaXMgYW5kIHNlZSB0aGF0IEkKPiA+IGhhdmUgbm90IG1hZGUgYW55IG1vcmUg bWlzdGFrZXM/IEkgZG9uJ3QgdHJ1c3QgbXlzZWxmIGFueW1vcmUgd2l0aAo+ID4gdGhlc2UuCj4g Cj4gVGhpcyBsb29rcyBnb29kIHRvIG1lIChub3RlIEkgZGlkIG5vdCB0ZXN0IG9ubHkgcmV2aWV3 ZWQpLgoKVGhhbmtzLiBJJ2xsIHNlbmQgdjkuCgpCciwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup Date: Tue, 20 Mar 2018 14:52:40 +0200 Message-ID: <20180320125240.GA25137@kuha.fi.intel.com> References: <20180314131215.70833-1-heikki.krogerus@linux.intel.com> <20180314131215.70833-2-heikki.krogerus@linux.intel.com> <20180320092004.GA21081@kroah.com> <20180320100412.GI11689@kuha.fi.intel.com> <20180320103259.GJ11689@kuha.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede Cc: Greg Kroah-Hartman , Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Guenter Roeck , Jun Li , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Tue, Mar 20, 2018 at 01:21:57PM +0100, Hans de Goede wrote: > On 20-03-18 11:32, Heikki Krogerus wrote: > > On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote: > > > > > +void device_connection_remove(struct device_connection *con) > > > > > +{ > > > > > + mutex_lock(&devcon_lock); > > > > > + list_del_rcu(&con->list); > > > > > > > > See, rcu? > > > > > > True. I'll send one more version. > > > > Before I do that, Hans, can you quickly check this and see that I > > have not made any more mistakes? I don't trust myself anymore with > > these. > > This looks good to me (note I did not test only reviewed). Thanks. I'll send v9. Br, -- heikki