From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp3867748wmb; Tue, 20 Mar 2018 06:59:25 -0700 (PDT) X-Google-Smtp-Source: AG47ELse8M1s6RyusZRyr/H7MLYo2MM1A6Vt9n+VsrXZXLdHhX1ez1TUsYKZA3yAFV4TOLqxtiAY X-Received: by 10.237.52.228 with SMTP id x91mr24794312qtd.152.1521554365042; Tue, 20 Mar 2018 06:59:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521554365; cv=none; d=google.com; s=arc-20160816; b=HJ7DXj32qvZ1siJDB7adV5RYQtcJSns9FykzJB1/VQ9uePZxZLUNWkVxHXqBNVvh0E peKn2kAf/sUELS53SwPoU1RO1p9vat2YgCoteopre4y1G0gU0v0p9dCXzBCV3qEGe4oX 9vnHHkxo9m/AhUez+Rt/l72dAL58ZX5P5bK5iT7JbMOXCCL5jBKRwuoX4UB/UeD4eRzV K1iEgwFClc4QAgq4JTB2DiPVpClHABwEzrkz84HIOTUKDOSn/ZJJVgGXl/V61Sq3Qzl7 qkf1+o8woYAU7S5dHmPA7ESXi/L7ZqLbWiOnNWALXoNIU2/k3J8kBiPr+w9CJ4JD7FRl t5pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :to:from:date:arc-authentication-results; bh=HRiHnMx09+s4xF/G5/GM/tiB/Y0CzdSQSy7Bt9RM2wA=; b=rvjy1C8ulgaqNrH+eLgqmBZJ0CZtdZf/meX0dhRl7s2a4beLolM9i3dWdye/JZlZCv qNtlAx9Nb+JXrkOXLf9OgEo/+UxbOUVP3WYlZZGn6uY3zy/pOIeYGwptUlRUgkaHZsZf Z9RYIlGUzOf+kjPG/qwLXFmlyg9FmPTTXhgWMuaQksHGadl9fe/tWZK4vHEr/BLsEfx0 etUqMhfVJkB3VBgTafNhTC6BiwqG4TnroZMBWZ/omLBNS7WRAJrsAGi636KauyF6vInv EAQgD97R9HiODIP7jETWgt51wu6TjGGBh6ioEzzoQXlUSWt5q9b1t+oM+k7BaIIwmPcK hmiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id m66si1702830qkf.457.2018.03.20.06.59.24 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Mar 2018 06:59:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHnQ-0006Vp-Gy for alex.bennee@linaro.org; Tue, 20 Mar 2018 09:59:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHWm-0003kC-G4 for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:42:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyHWe-0004Vc-65 for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:42:12 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55420 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyHWd-0004Uc-Vp; Tue, 20 Mar 2018 09:42:04 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A49B1A1BD3; Tue, 20 Mar 2018 13:42:02 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26C296B41B; Tue, 20 Mar 2018 13:41:19 +0000 (UTC) Date: Tue, 20 Mar 2018 13:41:17 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Message-ID: <20180320134117.GS4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 20 Mar 2018 13:42:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 20 Mar 2018 13:42:03 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'berrange@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 X-Mailman-Approved-At: Tue, 20 Mar 2018 09:59:16 -0400 Subject: Re: [Qemu-arm] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , David Hildenbrand , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?utf-8?B?SGVydsOp?= Poussineau , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Thomas Huth , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Fabien Chouteau , Greg Kurz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , xen-devel@lists.xenproject.org, BALATON Zoltan , John Snow , Richard Henderson , Kevin Wolf , Alexander Graf , qemu-block@nongnu.org, Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , Laurent Vivier , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= , Igor Mammedov , Hannes Reinecke , Aurelien Jarno , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: qjflbNSl+I26 On Tue, Mar 20, 2018 at 02:32:16PM +0100, Gerd Hoffmann wrote: > Hi, > > > > So for these, we should use "". None of these are generated files though. > > > > That leads to crazy inconsistent message for developers where 50% of QEMU > > header files must use <> and the other 50% of header files must use "". > > The rules are pretty simple though: > > (1) Headers which are generated use <>. > (2) Headers which are in include/ use <>. > (3) Headers sitting in the same directory as the source files use "". We have 1200 header files in QEMU - a developer might just reasonably remember which header file is a QEMU header, vs which is a 3rd party system header. Expecting devs to remember which of those 3 buckets each QEMU header falls under is unreasonable IMHO. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 13:41:17 +0000 Message-ID: <20180320134117.GS4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyHWf-0001fZ-Aw for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 13:42:05 +0000 Content-Disposition: inline In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Gerd Hoffmann Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDI6MzI6MTZQTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiAgIEhpLAo+IAo+ID4gPiBTbyBmb3IgdGhlc2UsIHdlIHNob3VsZCB1c2UgIiIuICBO b25lIG9mIHRoZXNlIGFyZSBnZW5lcmF0ZWQgZmlsZXMgdGhvdWdoLgo+ID4gCj4gPiBUaGF0IGxl YWRzIHRvIGNyYXp5IGluY29uc2lzdGVudCBtZXNzYWdlIGZvciBkZXZlbG9wZXJzIHdoZXJlIDUw JSBvZiBRRU1VCj4gPiBoZWFkZXIgZmlsZXMgbXVzdCB1c2UgPD4gYW5kIHRoZSBvdGhlciA1MCUg b2YgaGVhZGVyIGZpbGVzIG11c3QgdXNlICIiLgo+IAo+IFRoZSBydWxlcyBhcmUgcHJldHR5IHNp bXBsZSB0aG91Z2g6Cj4gCj4gICAgKDEpIEhlYWRlcnMgd2hpY2ggYXJlIGdlbmVyYXRlZCB1c2Ug PD4uCj4gICAgKDIpIEhlYWRlcnMgd2hpY2ggYXJlIGluIGluY2x1ZGUvIHVzZSA8Pi4KPiAgICAo MykgSGVhZGVycyBzaXR0aW5nIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNlIGZp bGVzIHVzZSAiIi4KCldlIGhhdmUgMTIwMCBoZWFkZXIgZmlsZXMgaW4gUUVNVSAtIGEgZGV2ZWxv cGVyIG1pZ2h0IGp1c3QgcmVhc29uYWJseSByZW1lbWJlcgp3aGljaCBoZWFkZXIgZmlsZSBpcyBh IFFFTVUgaGVhZGVyLCB2cyB3aGljaCBpcyBhIDNyZCBwYXJ0eSBzeXN0ZW0gaGVhZGVyLgpFeHBl Y3RpbmcgZGV2cyB0byByZW1lbWJlciB3aGljaCBvZiB0aG9zZSAzIGJ1Y2tldHMgZWFjaCBRRU1V IGhlYWRlciBmYWxscwp1bmRlciBpcyB1bnJlYXNvbmFibGUgSU1ITy4gCgpSZWdhcmRzLApEYW5p ZWwKLS0gCnw6IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZs aWNrci5jb20vcGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAg ICAgLW8tICAgICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0 cHM6Ly9lbnRhbmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5j b20vZGJlcnJhbmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 13:41:17 +0000 Message-ID: <20180320134117.GS4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , To: Gerd Hoffmann Return-path: Content-Disposition: inline In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDI6MzI6MTZQTSArMDEwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiAgIEhpLAo+IAo+ID4gPiBTbyBmb3IgdGhlc2UsIHdlIHNob3VsZCB1c2UgIiIuICBO b25lIG9mIHRoZXNlIGFyZSBnZW5lcmF0ZWQgZmlsZXMgdGhvdWdoLgo+ID4gCj4gPiBUaGF0IGxl YWRzIHRvIGNyYXp5IGluY29uc2lzdGVudCBtZXNzYWdlIGZvciBkZXZlbG9wZXJzIHdoZXJlIDUw JSBvZiBRRU1VCj4gPiBoZWFkZXIgZmlsZXMgbXVzdCB1c2UgPD4gYW5kIHRoZSBvdGhlciA1MCUg b2YgaGVhZGVyIGZpbGVzIG11c3QgdXNlICIiLgo+IAo+IFRoZSBydWxlcyBhcmUgcHJldHR5IHNp bXBsZSB0aG91Z2g6Cj4gCj4gICAgKDEpIEhlYWRlcnMgd2hpY2ggYXJlIGdlbmVyYXRlZCB1c2Ug PD4uCj4gICAgKDIpIEhlYWRlcnMgd2hpY2ggYXJlIGluIGluY2x1ZGUvIHVzZSA8Pi4KPiAgICAo MykgSGVhZGVycyBzaXR0aW5nIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNlIGZp bGVzIHVzZSAiIi4KCldlIGhhdmUgMTIwMCBoZWFkZXIgZmlsZXMgaW4gUUVNVSAtIGEgZGV2ZWxv cGVyIG1pZ2h0IGp1c3QgcmVhc29uYWJseSByZW1lbWJlcgp3aGljaCBoZWFkZXIgZmlsZSBpcyBh IFFFTVUgaGVhZGVyLCB2cyB3aGljaCBpcyBhIDNyZCBwYXJ0eSBzeXN0ZW0gaGVhZGVyLgpFeHBl Y3RpbmcgZGV2cyB0byByZW1lbWJlciB3aGljaCBvZiB0aG9zZSAzIGJ1Y2tldHMgZWFjaCBRRU1V IGhlYWRlciBmYWxscwp1bmRlciBpcyB1bnJlYXNvbmFibGUgSU1ITy4gCgpSZWdhcmRzLApEYW5p ZWwKLS0gCnw6IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZs aWNrci5jb20vcGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAg ICAgLW8tICAgICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0 cHM6Ly9lbnRhbmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5j b20vZGJlcnJhbmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs