From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp3835647wmb; Tue, 20 Mar 2018 06:30:00 -0700 (PDT) X-Google-Smtp-Source: AG47ELuyCJoMtA5xw+k5Mrc8T4Y7PsKClLbmIxIgA+maEXk3dGyMmMnbXFsFVn78dkB/ewjY9vSW X-Received: by 10.237.33.228 with SMTP id m33mr24521190qtc.30.1521552600147; Tue, 20 Mar 2018 06:30:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521552600; cv=none; d=google.com; s=arc-20160816; b=hAVdW17MeV/MMFxBoHwSDEo4SOJRYWq0f9+70A6d0krZOQ9ePG96sAsE3KCRSZ+VRg uA2DG9Y9J0hGp+buhDq+dIvC6c9Wpx+JkR47RkNANb9RaXsER+4CxYPma12aCFvE1tZp OGe3KXRVu2WGtj3NvgNk3zKND/zTL8hefp6FGpgutyT3uWHoi7U84yGl63YmryFtpNaV rroeeGiJoOgMLlAxgQdSKCdpgFyKsNmyme7GSAfeKjDCRRQqPQH/eMncm/SWj8F1UlCV ig/n+KS1Or6R82KLfCEbA6Xwjpv0qXAj+hnY9ENim+hX1uNYDKKBVTYsx+o8TAmlKzcy 907w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:in-reply-to:content-disposition :mime-version:references:message-id:to:from:date :arc-authentication-results; bh=udDGuv4JE08fhnEr85rJRHA4av/IRtC48RDH9In/QCE=; b=nsos1bMq3AZ620fZjQLHQmVxZnQ+Na3/pDrNRwVPNvc+rRaKkQZ7RCS05Bq0GfukMS ZEcryfDv4z1u2gnbPg+S68SjNB/k3iIviA5C7npVRwohnWw/IeP+7ZJ4dcMhd45aHk8/ li13b4Kv6aewAKKOqyvq7jh7j+du7gWkj8LAhyVYEhqGy51AFQpM2Zy1GqTQLZDwd96q gY/gngKIBDeVREuxggu5visImxFWN49Us13/tQFVVUpnrNFNfUEnsId5mvjEt4OBj0Ey YalCVJbJuPCvXNXlUkxuwj/cWk5NU2JfU1SIoUJ8/EvrbPwXHMzn4ah1H3w/pDVKB63t 081g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id w202si2948213qkb.19.2018.03.20.06.29.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Mar 2018 06:30:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHKx-00015K-HC for alex.bennee@linaro.org; Tue, 20 Mar 2018 09:29:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyG28-0007Vi-KI for qemu-devel@nongnu.org; Tue, 20 Mar 2018 08:06:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyG23-0005D7-KQ for qemu-devel@nongnu.org; Tue, 20 Mar 2018 08:06:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38202 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyG1p-00053M-IJ; Tue, 20 Mar 2018 08:06:09 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EDFE640006E6; Tue, 20 Mar 2018 12:06:03 +0000 (UTC) Received: from redhat.com (ovpn-121-0.rdu2.redhat.com [10.10.121.0]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F7292022C02; Tue, 20 Mar 2018 12:05:56 +0000 (UTC) Date: Tue, 20 Mar 2018 14:05:56 +0200 From: "Michael S. Tsirkin" To: Laurent Vivier Message-ID: <20180320135548-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 20 Mar 2018 12:06:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 20 Mar 2018 12:06:04 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 X-Mailman-Approved-At: Tue, 20 Mar 2018 09:27:42 -0400 Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Jason Wang , Artyom Tarasenko , Thomas Huth , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Fabien Chouteau , Greg Kurz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , xen-devel@lists.xenproject.org, John Snow , Richard Henderson , Kevin Wolf , Alexander Graf , qemu-block@nongnu.org, Peter Crosthwaite , Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , "Richard W.M. Jones" , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Igor Mammedov , Hannes Reinecke , Aurelien Jarno , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: ri2a2Bdy20Qj On Tue, Mar 20, 2018 at 09:58:23AM +0100, Laurent Vivier wrote: > Le 20/03/2018 =E0 02:54, Michael S. Tsirkin a =E9crit=A0: > > QEMU coding style at the moment asks for all non-system > > include files to be used with #include "foo.h". > > However this rule actually does not make sense and > > creates issues for when the included file is generated. >=20 > If you change that, we can have issue when a system include has the sam= e > name as our local include. With "", system header are taken first= . Are you sure? I just tested and that is not the case with either gcc or clang. > > In C, include "file" means look in current directory, > > then on include search path. Current directory here > > means the source file directory. > > By comparison include means look on include search path. >=20 > Not exactly, there is the notion of "system header" too. >=20 > https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html >=20 > #include > This variant is used for system header files. It searches for a file > named file in a standard list of system directories. You can prepend > directories to this list with the -I option (see Invocation). This is exactly what we do. > #include "file" > This variant is used for header files of your own program. It searches > for a file named file first in the directory containing the current > file, then in the quote directories and then the same directories used > for . You can prepend directories to the list of quote directorie= s > with the -iquote option. Since we do not use -iquote, "" just adds the current directory. > > As generated files are not in the search directory (unless the build > > directory happens to match the source directory), it does not make se= nse > > to include them with "" - doing so is merely more work for preprocess= or > > and a source or errors if a stale file happens to exist in the source > > directory. >=20 > I agree there is a problem with stale files. But linux, for instance, > asks for a "make mrproper" to avoid this. Using <> we avoid the problem completely and create slightly less work for the preprocessor. > > This changes include directives for all generated files, across the > > tree. The idea is to avoid sending a huge amount of email. But when > > merging, the changes will be split with one commit per file, e.g. for > > ease of bisect in case of build failures, and to ease merging. > >=20 > > Note that should some generated files be missed by this tree-wide > > refactoring, it isn't a big deal - this merely maintains the status q= uo, > > and this can be addressed by a separate patch on top. > >=20 > > Signed-off-by: Michael S. Tsirkin >=20 > I think your idea conflicts with what Markus has started to do: >=20 > commit d8e39b70625d4ba1e998439d1a077b4b978930e7 > Author: Markus Armbruster > Date: Thu Feb 1 12:18:28 2018 +0100 >=20 > Use #include "..." for our own headers, <...> for others >=20 > System headers should be included with <...>, our own headers with > "...". Offenders tracked down with an ugly, brittle and probably > buggy Perl script. Previous iteration was commit a9c94277f0. >=20 > Delete inclusions of "string.h" and "strings.h" instead of fixing t= hem > to and , because we always include these via > osdep.h. >=20 > Put the cleaned up system header includes first. >=20 > While there, separate #include from file comment with exactly one > blank line. >=20 > commit a9c94277f07d19d3eb14f199c3e93491aa3eae0e > Author: Markus Armbruster > Date: Wed Jun 22 19:11:19 2016 +0200 >=20 > Use #include "..." for our own headers, <...> for others >=20 > Tracked down with an ugly, brittle and probably buggy Perl script. >=20 > Also move includes converted to <...> up so they get included befor= e > ours where that's obviously okay. >=20 > Thanks, > Laurent I suspect we previously actually did have headers in the same directory as source so it was somewhat helpful. They all have been moved out to include now. --=20 MST From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 14:05:56 +0200 Message-ID: <20180320135548-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyG1l-000174-Ru for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 12:06:05 +0000 Content-Disposition: inline In-Reply-To: <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Laurent Vivier Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDk6NTg6MjNBTSArMDEwMCwgTGF1cmVudCBWaXZpZXIg d3JvdGU6Cj4gTGUgMjAvMDMvMjAxOCDDoCAwMjo1NCwgTWljaGFlbCBTLiBUc2lya2luIGEgw6lj cml0wqA6Cj4gPiBRRU1VIGNvZGluZyBzdHlsZSBhdCB0aGUgbW9tZW50IGFza3MgZm9yIGFsbCBu b24tc3lzdGVtCj4gPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9v LmgiLgo+ID4gSG93ZXZlciB0aGlzIHJ1bGUgYWN0dWFsbHkgZG9lcyBub3QgbWFrZSBzZW5zZSBh bmQKPiA+IGNyZWF0ZXMgaXNzdWVzIGZvciB3aGVuIHRoZSBpbmNsdWRlZCBmaWxlIGlzIGdlbmVy YXRlZC4KPiAKPiBJZiB5b3UgY2hhbmdlIHRoYXQsIHdlIGNhbiBoYXZlIGlzc3VlIHdoZW4gYSBz eXN0ZW0gaW5jbHVkZSBoYXMgdGhlIHNhbWUKPiBuYW1lIGFzIG91ciBsb2NhbCBpbmNsdWRlLiBX aXRoICI8RklMRT4iLCBzeXN0ZW0gaGVhZGVyIGFyZSB0YWtlbiBmaXJzdC4KCkFyZSB5b3Ugc3Vy ZT8gSSBqdXN0IHRlc3RlZCBhbmQgdGhhdCBpcyBub3QgdGhlIGNhc2Ugd2l0aAplaXRoZXIgZ2Nj IG9yIGNsYW5nLgoKPiA+IEluIEMsIGluY2x1ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVu dCBkaXJlY3RvcnksCj4gPiB0aGVuIG9uIGluY2x1ZGUgc2VhcmNoIHBhdGguIEN1cnJlbnQgZGly ZWN0b3J5IGhlcmUKPiA+IG1lYW5zIHRoZSBzb3VyY2UgZmlsZSBkaXJlY3RvcnkuCj4gPiBCeSBj b21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1lYW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0 aC4KPiAKPiBOb3QgZXhhY3RseSwgdGhlcmUgaXMgdGhlIG5vdGlvbiBvZiAic3lzdGVtIGhlYWRl ciIgdG9vLgo+IAo+IGh0dHBzOi8vZ2NjLmdudS5vcmcvb25saW5lZG9jcy9jcHAvSW5jbHVkZS1T eW50YXguaHRtbAo+IAo+ICNpbmNsdWRlIDxmaWxlPgo+IFRoaXMgdmFyaWFudCBpcyB1c2VkIGZv ciBzeXN0ZW0gaGVhZGVyIGZpbGVzLiBJdCBzZWFyY2hlcyBmb3IgYSBmaWxlCj4gbmFtZWQgZmls ZSBpbiBhIHN0YW5kYXJkIGxpc3Qgb2Ygc3lzdGVtIGRpcmVjdG9yaWVzLiBZb3UgY2FuIHByZXBl bmQKPiBkaXJlY3RvcmllcyB0byB0aGlzIGxpc3Qgd2l0aCB0aGUgLUkgb3B0aW9uIChzZWUgSW52 b2NhdGlvbikuCgpUaGlzIGlzIGV4YWN0bHkgd2hhdCB3ZSBkby4KCj4gI2luY2x1ZGUgImZpbGUi Cj4gVGhpcyB2YXJpYW50IGlzIHVzZWQgZm9yIGhlYWRlciBmaWxlcyBvZiB5b3VyIG93biBwcm9n cmFtLiBJdCBzZWFyY2hlcwo+IGZvciBhIGZpbGUgbmFtZWQgZmlsZSBmaXJzdCBpbiB0aGUgZGly ZWN0b3J5IGNvbnRhaW5pbmcgdGhlIGN1cnJlbnQKPiBmaWxlLCB0aGVuIGluIHRoZSBxdW90ZSBk aXJlY3RvcmllcyBhbmQgdGhlbiB0aGUgc2FtZSBkaXJlY3RvcmllcyB1c2VkCj4gZm9yIDxmaWxl Pi4gWW91IGNhbiBwcmVwZW5kIGRpcmVjdG9yaWVzIHRvIHRoZSBsaXN0IG9mIHF1b3RlIGRpcmVj dG9yaWVzCj4gd2l0aCB0aGUgLWlxdW90ZSBvcHRpb24uCgpTaW5jZSB3ZSBkbyBub3QgdXNlIC1p cXVvdGUsICIiIGp1c3QgYWRkcyB0aGUgY3VycmVudCBkaXJlY3RvcnkuCgoKPiA+IEFzIGdlbmVy YXRlZCBmaWxlcyBhcmUgbm90IGluIHRoZSBzZWFyY2ggZGlyZWN0b3J5ICh1bmxlc3MgdGhlIGJ1 aWxkCj4gPiBkaXJlY3RvcnkgaGFwcGVucyB0byBtYXRjaCB0aGUgc291cmNlIGRpcmVjdG9yeSks IGl0IGRvZXMgbm90IG1ha2Ugc2Vuc2UKPiA+IHRvIGluY2x1ZGUgdGhlbSB3aXRoICIiIC0gZG9p bmcgc28gaXMgbWVyZWx5IG1vcmUgd29yayBmb3IgcHJlcHJvY2Vzc29yCj4gPiBhbmQgYSBzb3Vy Y2Ugb3IgZXJyb3JzIGlmIGEgc3RhbGUgZmlsZSBoYXBwZW5zIHRvIGV4aXN0IGluIHRoZSBzb3Vy Y2UKPiA+IGRpcmVjdG9yeS4KPiAKPiBJIGFncmVlIHRoZXJlIGlzIGEgcHJvYmxlbSB3aXRoIHN0 YWxlIGZpbGVzLiBCdXQgbGludXgsIGZvciBpbnN0YW5jZSwKPiBhc2tzIGZvciBhICJtYWtlIG1y cHJvcGVyIiB0byBhdm9pZCB0aGlzLgoKVXNpbmcgPD4gd2UgYXZvaWQgdGhlIHByb2JsZW0gY29t cGxldGVseSBhbmQgY3JlYXRlIHNsaWdodGx5Cmxlc3Mgd29yayBmb3IgdGhlIHByZXByb2Nlc3Nv ci4KCj4gPiBUaGlzIGNoYW5nZXMgaW5jbHVkZSBkaXJlY3RpdmVzIGZvciBhbGwgZ2VuZXJhdGVk IGZpbGVzLCBhY3Jvc3MgdGhlCj4gPiB0cmVlLiBUaGUgaWRlYSBpcyB0byBhdm9pZCBzZW5kaW5n IGEgaHVnZSBhbW91bnQgb2YgZW1haWwuICBCdXQgd2hlbgo+ID4gbWVyZ2luZywgdGhlIGNoYW5n ZXMgd2lsbCBiZSBzcGxpdCB3aXRoIG9uZSBjb21taXQgcGVyIGZpbGUsIGUuZy4gZm9yCj4gPiBl YXNlIG9mIGJpc2VjdCBpbiBjYXNlIG9mIGJ1aWxkIGZhaWx1cmVzLCBhbmQgdG8gZWFzZSBtZXJn aW5nLgo+ID4gCj4gPiBOb3RlIHRoYXQgc2hvdWxkIHNvbWUgZ2VuZXJhdGVkIGZpbGVzIGJlIG1p c3NlZCBieSB0aGlzIHRyZWUtd2lkZQo+ID4gcmVmYWN0b3JpbmcsIGl0IGlzbid0IGEgYmlnIGRl YWwgLSB0aGlzIG1lcmVseSBtYWludGFpbnMgdGhlIHN0YXR1cyBxdW8sCj4gPiBhbmQgdGhpcyBj YW4gYmUgYWRkcmVzc2VkIGJ5IGEgc2VwYXJhdGUgcGF0Y2ggb24gdG9wLgo+ID4gCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPgo+IAo+IEkgdGhp bmsgeW91ciBpZGVhIGNvbmZsaWN0cyB3aXRoIHdoYXQgTWFya3VzIGhhcyBzdGFydGVkIHRvIGRv Ogo+IAo+IGNvbW1pdCBkOGUzOWI3MDYyNWQ0YmExZTk5ODQzOWQxYTA3N2I0Yjk3ODkzMGU3Cj4g QXV0aG9yOiBNYXJrdXMgQXJtYnJ1c3RlciA8YXJtYnJ1QHJlZGhhdC5jb20+Cj4gRGF0ZTogICBU aHUgRmViIDEgMTI6MTg6MjggMjAxOCArMDEwMAo+IAo+ICAgICBVc2UgI2luY2x1ZGUgIi4uLiIg Zm9yIG91ciBvd24gaGVhZGVycywgPC4uLj4gZm9yIG90aGVycwo+IAo+ICAgICBTeXN0ZW0gaGVh ZGVycyBzaG91bGQgYmUgaW5jbHVkZWQgd2l0aCA8Li4uPiwgb3VyIG93biBoZWFkZXJzIHdpdGgK PiAgICAgIi4uLiIuICBPZmZlbmRlcnMgdHJhY2tlZCBkb3duIHdpdGggYW4gdWdseSwgYnJpdHRs ZSBhbmQgcHJvYmFibHkKPiAgICAgYnVnZ3kgUGVybCBzY3JpcHQuICBQcmV2aW91cyBpdGVyYXRp b24gd2FzIGNvbW1pdCBhOWM5NDI3N2YwLgo+IAo+ICAgICBEZWxldGUgaW5jbHVzaW9ucyBvZiAi c3RyaW5nLmgiIGFuZCAic3RyaW5ncy5oIiBpbnN0ZWFkIG9mIGZpeGluZyB0aGVtCj4gICAgIHRv IDxzdHJpbmcuaD4gYW5kIDxzdHJpbmdzLmg+LCBiZWNhdXNlIHdlIGFsd2F5cyBpbmNsdWRlIHRo ZXNlIHZpYQo+ICAgICBvc2RlcC5oLgo+IAo+ICAgICBQdXQgdGhlIGNsZWFuZWQgdXAgc3lzdGVt IGhlYWRlciBpbmNsdWRlcyBmaXJzdC4KPiAKPiAgICAgV2hpbGUgdGhlcmUsIHNlcGFyYXRlICNp bmNsdWRlIGZyb20gZmlsZSBjb21tZW50IHdpdGggZXhhY3RseSBvbmUKPiAgICAgYmxhbmsgbGlu ZS4KPiAKPiBjb21taXQgYTljOTQyNzdmMDdkMTlkM2ViMTRmMTk5YzNlOTM0OTFhYTNlYWUwZQo+ IEF1dGhvcjogTWFya3VzIEFybWJydXN0ZXIgPGFybWJydUByZWRoYXQuY29tPgo+IERhdGU6ICAg V2VkIEp1biAyMiAxOToxMToxOSAyMDE2ICswMjAwCj4gCj4gICAgIFVzZSAjaW5jbHVkZSAiLi4u IiBmb3Igb3VyIG93biBoZWFkZXJzLCA8Li4uPiBmb3Igb3RoZXJzCj4gCj4gICAgIFRyYWNrZWQg ZG93biB3aXRoIGFuIHVnbHksIGJyaXR0bGUgYW5kIHByb2JhYmx5IGJ1Z2d5IFBlcmwgc2NyaXB0 Lgo+IAo+ICAgICBBbHNvIG1vdmUgaW5jbHVkZXMgY29udmVydGVkIHRvIDwuLi4+IHVwIHNvIHRo ZXkgZ2V0IGluY2x1ZGVkIGJlZm9yZQo+ICAgICBvdXJzIHdoZXJlIHRoYXQncyBvYnZpb3VzbHkg b2theS4KPiAKPiBUaGFua3MsCj4gTGF1cmVudAoKSSBzdXNwZWN0IHdlIHByZXZpb3VzbHkgYWN0 dWFsbHkgZGlkIGhhdmUgaGVhZGVycyBpbiB0aGUKc2FtZSBkaXJlY3RvcnkgYXMgc291cmNlIHNv IGl0IHdhcyBzb21ld2hhdCBoZWxwZnVsLgpUaGV5IGFsbCBoYXZlIGJlZW4gbW92ZWQgb3V0IHRv IGluY2x1ZGUgbm93LgoKLS0gCk1TVAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 14:05:56 +0200 Message-ID: <20180320135548-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang Return-path: Content-Disposition: inline In-Reply-To: <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDk6NTg6MjNBTSArMDEwMCwgTGF1cmVudCBWaXZpZXIg d3JvdGU6Cj4gTGUgMjAvMDMvMjAxOCDDoCAwMjo1NCwgTWljaGFlbCBTLiBUc2lya2luIGEgw6lj cml0wqA6Cj4gPiBRRU1VIGNvZGluZyBzdHlsZSBhdCB0aGUgbW9tZW50IGFza3MgZm9yIGFsbCBu b24tc3lzdGVtCj4gPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9v LmgiLgo+ID4gSG93ZXZlciB0aGlzIHJ1bGUgYWN0dWFsbHkgZG9lcyBub3QgbWFrZSBzZW5zZSBh bmQKPiA+IGNyZWF0ZXMgaXNzdWVzIGZvciB3aGVuIHRoZSBpbmNsdWRlZCBmaWxlIGlzIGdlbmVy YXRlZC4KPiAKPiBJZiB5b3UgY2hhbmdlIHRoYXQsIHdlIGNhbiBoYXZlIGlzc3VlIHdoZW4gYSBz eXN0ZW0gaW5jbHVkZSBoYXMgdGhlIHNhbWUKPiBuYW1lIGFzIG91ciBsb2NhbCBpbmNsdWRlLiBX aXRoICI8RklMRT4iLCBzeXN0ZW0gaGVhZGVyIGFyZSB0YWtlbiBmaXJzdC4KCkFyZSB5b3Ugc3Vy ZT8gSSBqdXN0IHRlc3RlZCBhbmQgdGhhdCBpcyBub3QgdGhlIGNhc2Ugd2l0aAplaXRoZXIgZ2Nj IG9yIGNsYW5nLgoKPiA+IEluIEMsIGluY2x1ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVu dCBkaXJlY3RvcnksCj4gPiB0aGVuIG9uIGluY2x1ZGUgc2VhcmNoIHBhdGguIEN1cnJlbnQgZGly ZWN0b3J5IGhlcmUKPiA+IG1lYW5zIHRoZSBzb3VyY2UgZmlsZSBkaXJlY3RvcnkuCj4gPiBCeSBj b21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1lYW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0 aC4KPiAKPiBOb3QgZXhhY3RseSwgdGhlcmUgaXMgdGhlIG5vdGlvbiBvZiAic3lzdGVtIGhlYWRl ciIgdG9vLgo+IAo+IGh0dHBzOi8vZ2NjLmdudS5vcmcvb25saW5lZG9jcy9jcHAvSW5jbHVkZS1T eW50YXguaHRtbAo+IAo+ICNpbmNsdWRlIDxmaWxlPgo+IFRoaXMgdmFyaWFudCBpcyB1c2VkIGZv ciBzeXN0ZW0gaGVhZGVyIGZpbGVzLiBJdCBzZWFyY2hlcyBmb3IgYSBmaWxlCj4gbmFtZWQgZmls ZSBpbiBhIHN0YW5kYXJkIGxpc3Qgb2Ygc3lzdGVtIGRpcmVjdG9yaWVzLiBZb3UgY2FuIHByZXBl bmQKPiBkaXJlY3RvcmllcyB0byB0aGlzIGxpc3Qgd2l0aCB0aGUgLUkgb3B0aW9uIChzZWUgSW52 b2NhdGlvbikuCgpUaGlzIGlzIGV4YWN0bHkgd2hhdCB3ZSBkby4KCj4gI2luY2x1ZGUgImZpbGUi Cj4gVGhpcyB2YXJpYW50IGlzIHVzZWQgZm9yIGhlYWRlciBmaWxlcyBvZiB5b3VyIG93biBwcm9n cmFtLiBJdCBzZWFyY2hlcwo+IGZvciBhIGZpbGUgbmFtZWQgZmlsZSBmaXJzdCBpbiB0aGUgZGly ZWN0b3J5IGNvbnRhaW5pbmcgdGhlIGN1cnJlbnQKPiBmaWxlLCB0aGVuIGluIHRoZSBxdW90ZSBk aXJlY3RvcmllcyBhbmQgdGhlbiB0aGUgc2FtZSBkaXJlY3RvcmllcyB1c2VkCj4gZm9yIDxmaWxl Pi4gWW91IGNhbiBwcmVwZW5kIGRpcmVjdG9yaWVzIHRvIHRoZSBsaXN0IG9mIHF1b3RlIGRpcmVj dG9yaWVzCj4gd2l0aCB0aGUgLWlxdW90ZSBvcHRpb24uCgpTaW5jZSB3ZSBkbyBub3QgdXNlIC1p cXVvdGUsICIiIGp1c3QgYWRkcyB0aGUgY3VycmVudCBkaXJlY3RvcnkuCgoKPiA+IEFzIGdlbmVy YXRlZCBmaWxlcyBhcmUgbm90IGluIHRoZSBzZWFyY2ggZGlyZWN0b3J5ICh1bmxlc3MgdGhlIGJ1 aWxkCj4gPiBkaXJlY3RvcnkgaGFwcGVucyB0byBtYXRjaCB0aGUgc291cmNlIGRpcmVjdG9yeSks IGl0IGRvZXMgbm90IG1ha2Ugc2Vuc2UKPiA+IHRvIGluY2x1ZGUgdGhlbSB3aXRoICIiIC0gZG9p bmcgc28gaXMgbWVyZWx5IG1vcmUgd29yayBmb3IgcHJlcHJvY2Vzc29yCj4gPiBhbmQgYSBzb3Vy Y2Ugb3IgZXJyb3JzIGlmIGEgc3RhbGUgZmlsZSBoYXBwZW5zIHRvIGV4aXN0IGluIHRoZSBzb3Vy Y2UKPiA+IGRpcmVjdG9yeS4KPiAKPiBJIGFncmVlIHRoZXJlIGlzIGEgcHJvYmxlbSB3aXRoIHN0 YWxlIGZpbGVzLiBCdXQgbGludXgsIGZvciBpbnN0YW5jZSwKPiBhc2tzIGZvciBhICJtYWtlIG1y cHJvcGVyIiB0byBhdm9pZCB0aGlzLgoKVXNpbmcgPD4gd2UgYXZvaWQgdGhlIHByb2JsZW0gY29t cGxldGVseSBhbmQgY3JlYXRlIHNsaWdodGx5Cmxlc3Mgd29yayBmb3IgdGhlIHByZXByb2Nlc3Nv ci4KCj4gPiBUaGlzIGNoYW5nZXMgaW5jbHVkZSBkaXJlY3RpdmVzIGZvciBhbGwgZ2VuZXJhdGVk IGZpbGVzLCBhY3Jvc3MgdGhlCj4gPiB0cmVlLiBUaGUgaWRlYSBpcyB0byBhdm9pZCBzZW5kaW5n IGEgaHVnZSBhbW91bnQgb2YgZW1haWwuICBCdXQgd2hlbgo+ID4gbWVyZ2luZywgdGhlIGNoYW5n ZXMgd2lsbCBiZSBzcGxpdCB3aXRoIG9uZSBjb21taXQgcGVyIGZpbGUsIGUuZy4gZm9yCj4gPiBl YXNlIG9mIGJpc2VjdCBpbiBjYXNlIG9mIGJ1aWxkIGZhaWx1cmVzLCBhbmQgdG8gZWFzZSBtZXJn aW5nLgo+ID4gCj4gPiBOb3RlIHRoYXQgc2hvdWxkIHNvbWUgZ2VuZXJhdGVkIGZpbGVzIGJlIG1p c3NlZCBieSB0aGlzIHRyZWUtd2lkZQo+ID4gcmVmYWN0b3JpbmcsIGl0IGlzbid0IGEgYmlnIGRl YWwgLSB0aGlzIG1lcmVseSBtYWludGFpbnMgdGhlIHN0YXR1cyBxdW8sCj4gPiBhbmQgdGhpcyBj YW4gYmUgYWRkcmVzc2VkIGJ5IGEgc2VwYXJhdGUgcGF0Y2ggb24gdG9wLgo+ID4gCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPgo+IAo+IEkgdGhp bmsgeW91ciBpZGVhIGNvbmZsaWN0cyB3aXRoIHdoYXQgTWFya3VzIGhhcyBzdGFydGVkIHRvIGRv Ogo+IAo+IGNvbW1pdCBkOGUzOWI3MDYyNWQ0YmExZTk5ODQzOWQxYTA3N2I0Yjk3ODkzMGU3Cj4g QXV0aG9yOiBNYXJrdXMgQXJtYnJ1c3RlciA8YXJtYnJ1QHJlZGhhdC5jb20+Cj4gRGF0ZTogICBU aHUgRmViIDEgMTI6MTg6MjggMjAxOCArMDEwMAo+IAo+ICAgICBVc2UgI2luY2x1ZGUgIi4uLiIg Zm9yIG91ciBvd24gaGVhZGVycywgPC4uLj4gZm9yIG90aGVycwo+IAo+ICAgICBTeXN0ZW0gaGVh ZGVycyBzaG91bGQgYmUgaW5jbHVkZWQgd2l0aCA8Li4uPiwgb3VyIG93biBoZWFkZXJzIHdpdGgK PiAgICAgIi4uLiIuICBPZmZlbmRlcnMgdHJhY2tlZCBkb3duIHdpdGggYW4gdWdseSwgYnJpdHRs ZSBhbmQgcHJvYmFibHkKPiAgICAgYnVnZ3kgUGVybCBzY3JpcHQuICBQcmV2aW91cyBpdGVyYXRp b24gd2FzIGNvbW1pdCBhOWM5NDI3N2YwLgo+IAo+ICAgICBEZWxldGUgaW5jbHVzaW9ucyBvZiAi c3RyaW5nLmgiIGFuZCAic3RyaW5ncy5oIiBpbnN0ZWFkIG9mIGZpeGluZyB0aGVtCj4gICAgIHRv IDxzdHJpbmcuaD4gYW5kIDxzdHJpbmdzLmg+LCBiZWNhdXNlIHdlIGFsd2F5cyBpbmNsdWRlIHRo ZXNlIHZpYQo+ICAgICBvc2RlcC5oLgo+IAo+ICAgICBQdXQgdGhlIGNsZWFuZWQgdXAgc3lzdGVt IGhlYWRlciBpbmNsdWRlcyBmaXJzdC4KPiAKPiAgICAgV2hpbGUgdGhlcmUsIHNlcGFyYXRlICNp bmNsdWRlIGZyb20gZmlsZSBjb21tZW50IHdpdGggZXhhY3RseSBvbmUKPiAgICAgYmxhbmsgbGlu ZS4KPiAKPiBjb21taXQgYTljOTQyNzdmMDdkMTlkM2ViMTRmMTk5YzNlOTM0OTFhYTNlYWUwZQo+ IEF1dGhvcjogTWFya3VzIEFybWJydXN0ZXIgPGFybWJydUByZWRoYXQuY29tPgo+IERhdGU6ICAg V2VkIEp1biAyMiAxOToxMToxOSAyMDE2ICswMjAwCj4gCj4gICAgIFVzZSAjaW5jbHVkZSAiLi4u IiBmb3Igb3VyIG93biBoZWFkZXJzLCA8Li4uPiBmb3Igb3RoZXJzCj4gCj4gICAgIFRyYWNrZWQg ZG93biB3aXRoIGFuIHVnbHksIGJyaXR0bGUgYW5kIHByb2JhYmx5IGJ1Z2d5IFBlcmwgc2NyaXB0 Lgo+IAo+ICAgICBBbHNvIG1vdmUgaW5jbHVkZXMgY29udmVydGVkIHRvIDwuLi4+IHVwIHNvIHRo ZXkgZ2V0IGluY2x1ZGVkIGJlZm9yZQo+ICAgICBvdXJzIHdoZXJlIHRoYXQncyBvYnZpb3VzbHkg b2theS4KPiAKPiBUaGFua3MsCj4gTGF1cmVudAoKSSBzdXNwZWN0IHdlIHByZXZpb3VzbHkgYWN0 dWFsbHkgZGlkIGhhdmUgaGVhZGVycyBpbiB0aGUKc2FtZSBkaXJlY3RvcnkgYXMgc291cmNlIHNv IGl0IHdhcyBzb21ld2hhdCBoZWxwZnVsLgpUaGV5IGFsbCBoYXZlIGJlZW4gbW92ZWQgb3V0IHRv IGluY2x1ZGUgbm93LgoKLS0gCk1TVAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L3hlbi1kZXZlbA==