From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp3843247wmb; Tue, 20 Mar 2018 06:36:25 -0700 (PDT) X-Google-Smtp-Source: AG47ELuP+hcWiR9liWjPl+ph2I3VWFDnkL/1DCW8n0kYS1u5D7sxOwZjv21MVdpe8vHOx5SCaVfK X-Received: by 10.55.188.69 with SMTP id m66mr23098449qkf.118.1521552985483; Tue, 20 Mar 2018 06:36:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521552985; cv=none; d=google.com; s=arc-20160816; b=inQfBss7CUeQ5oZKMmvWJxRYl4/neK/ssRQ9CvABPBHuobsZpEJF4YU12gKiFaEKcR edsj5O21pNfvjduN0VNBGnQPb2jN83hcU822fgkSt4s4BEoyxl5NTiYmZOFaPAL/20ju f9EGNfMqOZn2iGX3EqSxBjvYbmSJEK1gkAEHMUF20evILk01JlwV/MLnAa1L/urJO77v U0glfcwe/CBzlMElHJ7dpw4psNdm+Wq4PI45AF8v+7fEyI25Mwu4+KhHZHqeU36Ddw9V mfqKLXcLJAsVzlqpnKVtAfFawm/pxkSNRhSewu7dz4T+QpxjJDVz3Qio1vdzoQuKXdL0 VsSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date :arc-authentication-results; bh=athf0YLUjwv54BX2r9TEG4x+8rQIOixp05yLULZYar4=; b=qst+4zleNSLPwkRlU/8SN+Vd3pl+6XKbbiKVI/SjiRgvOKOS/j75LApuggsSwl/taV JvASCWhHk7pZKl+Siv3jPIKdJbgjo9marhd1+D3g7OW19m6IYvZa17ZSbS8oRGdOM4tb snwm9getayegOP1DTq+GL/42eSnaexJ0SSXPjrIocfSoNI/2YhiMAYHh7yGrMDJ3R1rV HPy/o362YUzC4zFM5Qd97OrKKYMhQXK8rNIQ0blcHPdL/cMgBJq13WTI2iTHN5c8tRH+ lAmafbpOXawMX1pd2pzjUTMzn00cppCUbbQbdX3xyxvYqTTRz7dlaXX+RPdP0PP6EW5d 27cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y33si2046420qtj.149.2018.03.20.06.36.25 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Mar 2018 06:36:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHRA-0007R8-UU for alex.bennee@linaro.org; Tue, 20 Mar 2018 09:36:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyGxE-0007Ml-Np for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:05:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyGxA-0000nh-LX for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:05:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45232 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyGxA-0000nN-D3; Tue, 20 Mar 2018 09:05:24 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE1C481A4395; Tue, 20 Mar 2018 13:05:22 +0000 (UTC) Received: from redhat.com (ovpn-121-0.rdu2.redhat.com [10.10.121.0]) by smtp.corp.redhat.com (Postfix) with SMTP id 4965F215CDB7; Tue, 20 Mar 2018 13:05:00 +0000 (UTC) Date: Tue, 20 Mar 2018 15:05:00 +0200 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20180320145402-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1521510562-529051-1-git-send-email-mst@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 20 Mar 2018 13:05:23 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 20 Mar 2018 13:05:23 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 X-Mailman-Approved-At: Tue, 20 Mar 2018 09:28:26 -0400 Subject: Re: [Qemu-arm] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Stefan Hajnoczi , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Fabien Chouteau , Greg Kurz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Ronnie Sahlberg , Paolo Bonzini , xen-devel@lists.xenproject.org, John Snow , Richard Henderson , Kevin Wolf , Alexander Graf , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-block@nongnu.org, Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , "Richard W.M. Jones" , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Igor Mammedov , Hannes Reinecke , Aurelien Jarno , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: jANqWuBUK7gT On Tue, Mar 20, 2018 at 03:54:36AM +0200, Michael S. Tsirkin wrote: > QEMU coding style at the moment asks for all non-system > include files to be used with #include "foo.h". > However this rule actually does not make sense and > creates issues for when the included file is generated. > > In C, include "file" means look in current directory, > then on include search path. Current directory here > means the source file directory. > By comparison include means look on include search path. > > As generated files are not in the search directory (unless the build > directory happens to match the source directory), it does not make sense > to include them with "" - doing so is merely more work for preprocessor > and a source or errors if a stale file happens to exist in the source > directory. > > This changes include directives for all generated files, across the > tree. The idea is to avoid sending a huge amount of email. But when > merging, the changes will be split with one commit per file, e.g. for > ease of bisect in case of build failures, and to ease merging. > > Note that should some generated files be missed by this tree-wide > refactoring, it isn't a big deal - this merely maintains the status quo, > and this can be addressed by a separate patch on top. > > Signed-off-by: Michael S. Tsirkin For the record, the stated advantage is that one can have a header file that happens to match the system header. To put it bluntly that does not work as designed. For example, if a system header foo.h somewhere has #include then the compiler will happily pull in our own version (since that is in the -I path) and completely ignore the system one, breaking things in the process. When does it make sense to use include ""? When the header is a directory-specific one, located with the source. This approach would both be enforced by the compiler and help people know where to find the header. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 15:05:00 +0200 Message-ID: <20180320145402-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyGxB-0006rA-Fp for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 13:05:25 +0000 Content-Disposition: inline In-Reply-To: <1521510562-529051-1-git-send-email-mst@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: qemu-devel@nongnu.org Cc: Peter Maydell , Dmitry Fleytman , Stefan Hajnoczi , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDM6NTQ6MzZBTSArMDIwMCwgTWljaGFlbCBTLiBUc2ly a2luIHdyb3RlOgo+IFFFTVUgY29kaW5nIHN0eWxlIGF0IHRoZSBtb21lbnQgYXNrcyBmb3IgYWxs IG5vbi1zeXN0ZW0KPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9v LmgiLgo+IEhvd2V2ZXIgdGhpcyBydWxlIGFjdHVhbGx5IGRvZXMgbm90IG1ha2Ugc2Vuc2UgYW5k Cj4gY3JlYXRlcyBpc3N1ZXMgZm9yIHdoZW4gdGhlIGluY2x1ZGVkIGZpbGUgaXMgZ2VuZXJhdGVk Lgo+IAo+IEluIEMsIGluY2x1ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVudCBkaXJlY3Rv cnksCj4gdGhlbiBvbiBpbmNsdWRlIHNlYXJjaCBwYXRoLiBDdXJyZW50IGRpcmVjdG9yeSBoZXJl Cj4gbWVhbnMgdGhlIHNvdXJjZSBmaWxlIGRpcmVjdG9yeS4KPiBCeSBjb21wYXJpc29uIGluY2x1 ZGUgPGZpbGU+IG1lYW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiAKPiBBcyBnZW5l cmF0ZWQgZmlsZXMgYXJlIG5vdCBpbiB0aGUgc2VhcmNoIGRpcmVjdG9yeSAodW5sZXNzIHRoZSBi dWlsZAo+IGRpcmVjdG9yeSBoYXBwZW5zIHRvIG1hdGNoIHRoZSBzb3VyY2UgZGlyZWN0b3J5KSwg aXQgZG9lcyBub3QgbWFrZSBzZW5zZQo+IHRvIGluY2x1ZGUgdGhlbSB3aXRoICIiIC0gZG9pbmcg c28gaXMgbWVyZWx5IG1vcmUgd29yayBmb3IgcHJlcHJvY2Vzc29yCj4gYW5kIGEgc291cmNlIG9y IGVycm9ycyBpZiBhIHN0YWxlIGZpbGUgaGFwcGVucyB0byBleGlzdCBpbiB0aGUgc291cmNlCj4g ZGlyZWN0b3J5Lgo+IAo+IFRoaXMgY2hhbmdlcyBpbmNsdWRlIGRpcmVjdGl2ZXMgZm9yIGFsbCBn ZW5lcmF0ZWQgZmlsZXMsIGFjcm9zcyB0aGUKPiB0cmVlLiBUaGUgaWRlYSBpcyB0byBhdm9pZCBz ZW5kaW5nIGEgaHVnZSBhbW91bnQgb2YgZW1haWwuICBCdXQgd2hlbgo+IG1lcmdpbmcsIHRoZSBj aGFuZ2VzIHdpbGwgYmUgc3BsaXQgd2l0aCBvbmUgY29tbWl0IHBlciBmaWxlLCBlLmcuIGZvcgo+ IGVhc2Ugb2YgYmlzZWN0IGluIGNhc2Ugb2YgYnVpbGQgZmFpbHVyZXMsIGFuZCB0byBlYXNlIG1l cmdpbmcuCj4gCj4gTm90ZSB0aGF0IHNob3VsZCBzb21lIGdlbmVyYXRlZCBmaWxlcyBiZSBtaXNz ZWQgYnkgdGhpcyB0cmVlLXdpZGUKPiByZWZhY3RvcmluZywgaXQgaXNuJ3QgYSBiaWcgZGVhbCAt IHRoaXMgbWVyZWx5IG1haW50YWlucyB0aGUgc3RhdHVzIHF1bywKPiBhbmQgdGhpcyBjYW4gYmUg YWRkcmVzc2VkIGJ5IGEgc2VwYXJhdGUgcGF0Y2ggb24gdG9wLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+CgoKRm9yIHRoZSByZWNvcmQsIHRo ZSBzdGF0ZWQgYWR2YW50YWdlIGlzIHRoYXQgb25lIGNhbgpoYXZlIGEgaGVhZGVyIGZpbGUgdGhh dCBoYXBwZW5zIHRvIG1hdGNoIHRoZSBzeXN0ZW0KaGVhZGVyLgoKVG8gcHV0IGl0IGJsdW50bHkg dGhhdCBkb2VzIG5vdCB3b3JrIGFzIGRlc2lnbmVkLgoKRm9yIGV4YW1wbGUsIGlmIGEgc3lzdGVt IGhlYWRlciBmb28uaCBzb21ld2hlcmUgaGFzICNpbmNsdWRlIDx0cmFjZS5oPgp0aGVuIHRoZSBj b21waWxlciB3aWxsIGhhcHBpbHkgcHVsbCBpbiBvdXIgb3duIHZlcnNpb24gKHNpbmNlIHRoYXQg aXMgaW4KdGhlIC1JIHBhdGgpIGFuZCBjb21wbGV0ZWx5IGlnbm9yZSB0aGUgc3lzdGVtIG9uZSwg YnJlYWtpbmcgdGhpbmdzIGluCnRoZSBwcm9jZXNzLgoKV2hlbiBkb2VzIGl0IG1ha2Ugc2Vuc2Ug dG8gdXNlIGluY2x1ZGUgIiI/IFdoZW4gdGhlIGhlYWRlciBpcwphIGRpcmVjdG9yeS1zcGVjaWZp YyBvbmUsIGxvY2F0ZWQgd2l0aCB0aGUgc291cmNlLgpUaGlzIGFwcHJvYWNoIHdvdWxkIGJvdGgg YmUgZW5mb3JjZWQgYnkgdGhlIGNvbXBpbGVyCmFuZCBoZWxwIHBlb3BsZSBrbm93IHdoZXJlIHRv IGZpbmQgdGhlIGhlYWRlci4KCi0tIApNU1QKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 15:05:00 +0200 Message-ID: <20180320145402-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , Stefan Hajnoczi , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang Content-Disposition: inline In-Reply-To: <1521510562-529051-1-git-send-email-mst@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDM6NTQ6MzZBTSArMDIwMCwgTWljaGFlbCBTLiBUc2ly a2luIHdyb3RlOgo+IFFFTVUgY29kaW5nIHN0eWxlIGF0IHRoZSBtb21lbnQgYXNrcyBmb3IgYWxs IG5vbi1zeXN0ZW0KPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9v LmgiLgo+IEhvd2V2ZXIgdGhpcyBydWxlIGFjdHVhbGx5IGRvZXMgbm90IG1ha2Ugc2Vuc2UgYW5k Cj4gY3JlYXRlcyBpc3N1ZXMgZm9yIHdoZW4gdGhlIGluY2x1ZGVkIGZpbGUgaXMgZ2VuZXJhdGVk Lgo+IAo+IEluIEMsIGluY2x1ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVudCBkaXJlY3Rv cnksCj4gdGhlbiBvbiBpbmNsdWRlIHNlYXJjaCBwYXRoLiBDdXJyZW50IGRpcmVjdG9yeSBoZXJl Cj4gbWVhbnMgdGhlIHNvdXJjZSBmaWxlIGRpcmVjdG9yeS4KPiBCeSBjb21wYXJpc29uIGluY2x1 ZGUgPGZpbGU+IG1lYW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiAKPiBBcyBnZW5l cmF0ZWQgZmlsZXMgYXJlIG5vdCBpbiB0aGUgc2VhcmNoIGRpcmVjdG9yeSAodW5sZXNzIHRoZSBi dWlsZAo+IGRpcmVjdG9yeSBoYXBwZW5zIHRvIG1hdGNoIHRoZSBzb3VyY2UgZGlyZWN0b3J5KSwg aXQgZG9lcyBub3QgbWFrZSBzZW5zZQo+IHRvIGluY2x1ZGUgdGhlbSB3aXRoICIiIC0gZG9pbmcg c28gaXMgbWVyZWx5IG1vcmUgd29yayBmb3IgcHJlcHJvY2Vzc29yCj4gYW5kIGEgc291cmNlIG9y IGVycm9ycyBpZiBhIHN0YWxlIGZpbGUgaGFwcGVucyB0byBleGlzdCBpbiB0aGUgc291cmNlCj4g ZGlyZWN0b3J5Lgo+IAo+IFRoaXMgY2hhbmdlcyBpbmNsdWRlIGRpcmVjdGl2ZXMgZm9yIGFsbCBn ZW5lcmF0ZWQgZmlsZXMsIGFjcm9zcyB0aGUKPiB0cmVlLiBUaGUgaWRlYSBpcyB0byBhdm9pZCBz ZW5kaW5nIGEgaHVnZSBhbW91bnQgb2YgZW1haWwuICBCdXQgd2hlbgo+IG1lcmdpbmcsIHRoZSBj aGFuZ2VzIHdpbGwgYmUgc3BsaXQgd2l0aCBvbmUgY29tbWl0IHBlciBmaWxlLCBlLmcuIGZvcgo+ IGVhc2Ugb2YgYmlzZWN0IGluIGNhc2Ugb2YgYnVpbGQgZmFpbHVyZXMsIGFuZCB0byBlYXNlIG1l cmdpbmcuCj4gCj4gTm90ZSB0aGF0IHNob3VsZCBzb21lIGdlbmVyYXRlZCBmaWxlcyBiZSBtaXNz ZWQgYnkgdGhpcyB0cmVlLXdpZGUKPiByZWZhY3RvcmluZywgaXQgaXNuJ3QgYSBiaWcgZGVhbCAt IHRoaXMgbWVyZWx5IG1haW50YWlucyB0aGUgc3RhdHVzIHF1bywKPiBhbmQgdGhpcyBjYW4gYmUg YWRkcmVzc2VkIGJ5IGEgc2VwYXJhdGUgcGF0Y2ggb24gdG9wLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+CgoKRm9yIHRoZSByZWNvcmQsIHRo ZSBzdGF0ZWQgYWR2YW50YWdlIGlzIHRoYXQgb25lIGNhbgpoYXZlIGEgaGVhZGVyIGZpbGUgdGhh dCBoYXBwZW5zIHRvIG1hdGNoIHRoZSBzeXN0ZW0KaGVhZGVyLgoKVG8gcHV0IGl0IGJsdW50bHkg dGhhdCBkb2VzIG5vdCB3b3JrIGFzIGRlc2lnbmVkLgoKRm9yIGV4YW1wbGUsIGlmIGEgc3lzdGVt IGhlYWRlciBmb28uaCBzb21ld2hlcmUgaGFzICNpbmNsdWRlIDx0cmFjZS5oPgp0aGVuIHRoZSBj b21waWxlciB3aWxsIGhhcHBpbHkgcHVsbCBpbiBvdXIgb3duIHZlcnNpb24gKHNpbmNlIHRoYXQg aXMgaW4KdGhlIC1JIHBhdGgpIGFuZCBjb21wbGV0ZWx5IGlnbm9yZSB0aGUgc3lzdGVtIG9uZSwg YnJlYWtpbmcgdGhpbmdzIGluCnRoZSBwcm9jZXNzLgoKV2hlbiBkb2VzIGl0IG1ha2Ugc2Vuc2Ug dG8gdXNlIGluY2x1ZGUgIiI/IFdoZW4gdGhlIGhlYWRlciBpcwphIGRpcmVjdG9yeS1zcGVjaWZp YyBvbmUsIGxvY2F0ZWQgd2l0aCB0aGUgc291cmNlLgpUaGlzIGFwcHJvYWNoIHdvdWxkIGJvdGgg YmUgZW5mb3JjZWQgYnkgdGhlIGNvbXBpbGVyCmFuZCBoZWxwIHBlb3BsZSBrbm93IHdoZXJlIHRv IGZpbmQgdGhlIGhlYWRlci4KCi0tIApNU1QKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby94ZW4tZGV2ZWw=