From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp3868086wmb; Tue, 20 Mar 2018 06:59:45 -0700 (PDT) X-Google-Smtp-Source: AG47ELvI/InA0z9r/+BsWGuyvLZqaIxaJ3NgoXSw8Mk7W71xqK6XQQcajaV10F/lc/iAyb/KxUcc X-Received: by 10.200.18.198 with SMTP id b6mr24111791qtj.34.1521554385748; Tue, 20 Mar 2018 06:59:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521554385; cv=none; d=google.com; s=arc-20160816; b=fOPSlS5q2cnNHoJxaPWlYsYmWhFSYz6dUEDa2H9BESMzyQ/aGmup/4l+O3tVpU5+dd P7NNhAv6IwWJ80bFf/L34KhtGVUQM4B5vC9p03CYG2Vqv3+CyVgh7Lr2akA8t9b/RFnd JnK1cPETbOIP5K9evy3oj14m/OzRLICqgOvEzYSWufrXwHngn0CCorMfv5qjqfJKLVdX 2UvLa3f1x51BK5dGLexcpI3FHWL1cdBghIlCa1M9A4BvJwi6Z6asbuaPz8PR2pVmucmG azXZh68yfccuwtY1Hn0+bVZDKDfrpAjQKcB4KlClH3qHrDYJoRnfHVafvkzIgpiCXvWr TGGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:in-reply-to:content-disposition :mime-version:references:message-id:to:from:date :arc-authentication-results; bh=PdfaaeEDzBdkk3MFmtWIu82XKcQwxo3UZLu9PxkmGzU=; b=XxqECXyT+bPZXDDOd8i0i73mlJuK7SmRuhRUfsJRQSBM/jTlRNdsGadp3/hFD3LYjc OdK+McO1cgxLeNFJvoKqL/keMSJLeiNn273xcz7E/bF1JEeEOQwCsKZ3aDbk4urChJrc k/yraXawuKIEJn8G7Pxed8tLDV6g3+LN3O65fH4I1dkJhvoVqIbL297nR6NSXWw7mnMJ fXUVbs/k87Frei+A4tgNOyfvYe8w80XsQWd9Ooyg74gX7UpyJPdfQjEcBMs0ppJvuMMF zXUXG3l88AE46lYkcVFW5feynWNuZYxENst2tFhqFvcFfYvkpnue+2K4vuCYzl5baxxl ipBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id l92si2066072qte.301.2018.03.20.06.59.45 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Mar 2018 06:59:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHnl-0006qZ-A3 for alex.bennee@linaro.org; Tue, 20 Mar 2018 09:59:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHeu-0001zw-AO for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:50:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyHeq-0001PX-7S for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:50:36 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40828 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyHep-0001PK-Tc; Tue, 20 Mar 2018 09:50:32 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B342940267D7; Tue, 20 Mar 2018 13:50:30 +0000 (UTC) Received: from redhat.com (ovpn-125-54.rdu2.redhat.com [10.10.125.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id A193011701C4; Tue, 20 Mar 2018 13:50:02 +0000 (UTC) Date: Tue, 20 Mar 2018 15:50:02 +0200 From: "Michael S. Tsirkin" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Message-ID: <20180320154703-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> <20180320134117.GS4530@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180320134117.GS4530@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 20 Mar 2018 13:50:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 20 Mar 2018 13:50:31 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 X-Mailman-Approved-At: Tue, 20 Mar 2018 09:59:16 -0400 Subject: Re: [Qemu-arm] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Thomas Huth , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Fabien Chouteau , Greg Kurz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , xen-devel@lists.xenproject.org, BALATON Zoltan , John Snow , Richard Henderson , Kevin Wolf , Alexander Graf , qemu-block@nongnu.org, Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , Laurent Vivier , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Igor Mammedov , Hannes Reinecke , Aurelien Jarno , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: Vh+EAtpvzRT2 On Tue, Mar 20, 2018 at 01:41:17PM +0000, Daniel P. Berrang=E9 wrote: > On Tue, Mar 20, 2018 at 02:32:16PM +0100, Gerd Hoffmann wrote: > > Hi, > >=20 > > > > So for these, we should use "". None of these are generated file= s though. > > >=20 > > > That leads to crazy inconsistent message for developers where 50% o= f QEMU > > > header files must use <> and the other 50% of header files must use= "". > >=20 > > The rules are pretty simple though: > >=20 > > (1) Headers which are generated use <>. > > (2) Headers which are in include/ use <>. > > (3) Headers sitting in the same directory as the source files use = "". >=20 > We have 1200 header files in QEMU - a developer might just reasonably r= emember > which header file is a QEMU header, vs which is a 3rd party system head= er. > Expecting devs to remember which of those 3 buckets each QEMU header fa= lls > under is unreasonable IMHO.=20 >=20 > Regards, > Daniel That's the C language for you though. For better or worse, these are the rules that K&R came up with. > --=20 > |: https://berrange.com -o- https://www.flickr.com/photos/dberr= ange :| > |: https://libvirt.org -o- https://fstop138.berrange= .com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberr= ange :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 15:50:02 +0200 Message-ID: <20180320154703-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> <20180320134117.GS4530@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyHeq-0002dW-NO for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 13:50:32 +0000 Content-Disposition: inline In-Reply-To: <20180320134117.GS4530@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDE6NDE6MTdQTSArMDAwMCwgRGFuaWVsIFAuIEJlcnJh bmfDqSB3cm90ZToKPiBPbiBUdWUsIE1hciAyMCwgMjAxOCBhdCAwMjozMjoxNlBNICswMTAwLCBH ZXJkIEhvZmZtYW5uIHdyb3RlOgo+ID4gICBIaSwKPiA+IAo+ID4gPiA+IFNvIGZvciB0aGVzZSwg d2Ugc2hvdWxkIHVzZSAiIi4gIE5vbmUgb2YgdGhlc2UgYXJlIGdlbmVyYXRlZCBmaWxlcyB0aG91 Z2guCj4gPiA+IAo+ID4gPiBUaGF0IGxlYWRzIHRvIGNyYXp5IGluY29uc2lzdGVudCBtZXNzYWdl IGZvciBkZXZlbG9wZXJzIHdoZXJlIDUwJSBvZiBRRU1VCj4gPiA+IGhlYWRlciBmaWxlcyBtdXN0 IHVzZSA8PiBhbmQgdGhlIG90aGVyIDUwJSBvZiBoZWFkZXIgZmlsZXMgbXVzdCB1c2UgIiIuCj4g PiAKPiA+IFRoZSBydWxlcyBhcmUgcHJldHR5IHNpbXBsZSB0aG91Z2g6Cj4gPiAKPiA+ICAgICgx KSBIZWFkZXJzIHdoaWNoIGFyZSBnZW5lcmF0ZWQgdXNlIDw+Lgo+ID4gICAgKDIpIEhlYWRlcnMg d2hpY2ggYXJlIGluIGluY2x1ZGUvIHVzZSA8Pi4KPiA+ICAgICgzKSBIZWFkZXJzIHNpdHRpbmcg aW4gdGhlIHNhbWUgZGlyZWN0b3J5IGFzIHRoZSBzb3VyY2UgZmlsZXMgdXNlICIiLgo+IAo+IFdl IGhhdmUgMTIwMCBoZWFkZXIgZmlsZXMgaW4gUUVNVSAtIGEgZGV2ZWxvcGVyIG1pZ2h0IGp1c3Qg cmVhc29uYWJseSByZW1lbWJlcgo+IHdoaWNoIGhlYWRlciBmaWxlIGlzIGEgUUVNVSBoZWFkZXIs IHZzIHdoaWNoIGlzIGEgM3JkIHBhcnR5IHN5c3RlbSBoZWFkZXIuCj4gRXhwZWN0aW5nIGRldnMg dG8gcmVtZW1iZXIgd2hpY2ggb2YgdGhvc2UgMyBidWNrZXRzIGVhY2ggUUVNVSBoZWFkZXIgZmFs bHMKPiB1bmRlciBpcyB1bnJlYXNvbmFibGUgSU1ITy4gCj4gCj4gUmVnYXJkcywKPiBEYW5pZWwK ClRoYXQncyB0aGUgQyBsYW5ndWFnZSBmb3IgeW91IHRob3VnaC4gIEZvciBiZXR0ZXIgb3Igd29y c2UsIHRoZXNlIGFyZQp0aGUgcnVsZXMgdGhhdCBLJlIgY2FtZSB1cCB3aXRoLgoKCj4gLS0gCj4g fDogaHR0cHM6Ly9iZXJyYW5nZS5jb20gICAgICAtby0gICAgaHR0cHM6Ly93d3cuZmxpY2tyLmNv bS9waG90b3MvZGJlcnJhbmdlIDp8Cj4gfDogaHR0cHM6Ly9saWJ2aXJ0Lm9yZyAgICAgICAgIC1v LSAgICAgICAgICAgIGh0dHBzOi8vZnN0b3AxMzguYmVycmFuZ2UuY29tIDp8Cj4gfDogaHR0cHM6 Ly9lbnRhbmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20v ZGJlcnJhbmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y ZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs