From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp4049427wmb; Tue, 20 Mar 2018 09:41:58 -0700 (PDT) X-Google-Smtp-Source: AG47ELtfs3tt6biPttu1OlbrmJad8cxPGUUOTOV4ehtRuBOnHdsJLq6ckZCl5dL3N4ZlNulvNW/m X-Received: by 10.55.87.6 with SMTP id l6mr22594987qkb.261.1521564117886; Tue, 20 Mar 2018 09:41:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521564117; cv=none; d=google.com; s=arc-20160816; b=QyuRrisS6QOl5IFNmreP+AsS33VaONqEKi1Y7Js4qVqSxxOZkGxwo/m2ZFJ4NBxtgz qAdXdX4uojBsPbqHWUDbr0ZTEtD4AqrL+HQtB0s11zYQPNrKrFfo5wEQIeEADH8qjpgn i+zHtb54mYLm/f/DJ0m7iiuBBY5tl1Z1NBzB1NQXc9h6eu4SotBD5TR9yIorbBWgHvhY QWpzYuurb00w4PzISKGPRhE0cw5xGuMxkI3B7lXmpgY+sWMr+E75jaJRZ6/zX2qXWwmM ycScoC3E8hWotqCldh3W1NtfP/taHsT5MKim/Adtq3xkVKcyAhxcijwrCWHqO2tBN2hq I/CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :to:from:date:arc-authentication-results; bh=YFMYElx04pML2nfUEVFHFgbYtVmnqf2kgXAVTTc6I9U=; b=EY4C4MKGxvPNtBYZGp0jEOTn05MCBlXI3xd9i3kAQ5Np4FV+hvzWvpWKd9gjo8Iu5M Uv8ir2A6ma9NOUDQpDxu33EjbRgU5dZL6Y0lZ1DJGXItnVY9mvoOdp1sp3hkkvDM2OKp xN4HM5BCCifgH6XIlcZJgWYKxEF1AdUwFpUy6IX04epshtwMBWGJqEgyh/FaL8OI4Ulb NIcDAQhQfbphCspLZqTO1+CyJe12EVZ3c2uIF1lh2PXvxl3pOQJ+mua6Q5lZpJZyfCfO so46TA6/k8Qef1rJNvS9ufpygFW3GUKQka2o5EK11F2j78bWlBClwQAruEW7kIR30AXk S5xQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 63si534029qth.453.2018.03.20.09.41.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Mar 2018 09:41:57 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:50611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyKKj-00073m-AJ for alex.bennee@linaro.org; Tue, 20 Mar 2018 12:41:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyKKY-00071w-6A for qemu-arm@nongnu.org; Tue, 20 Mar 2018 12:41:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyKKU-0006h6-CO for qemu-arm@nongnu.org; Tue, 20 Mar 2018 12:41:46 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37942 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyKKU-0006fh-5Y; Tue, 20 Mar 2018 12:41:42 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0FA44075392; Tue, 20 Mar 2018 16:41:30 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F292710B0F4D; Tue, 20 Mar 2018 16:40:50 +0000 (UTC) Date: Tue, 20 Mar 2018 16:40:48 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eric Blake Message-ID: <20180320164048.GB4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 20 Mar 2018 16:41:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 20 Mar 2018 16:41:31 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'berrange@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-arm] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , Jiri Pirko , Subbaraya Sundeep , Yongbok Kim , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , David Hildenbrand , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?utf-8?B?SGVydsOp?= Poussineau , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Fabien Chouteau , Greg Kurz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , xen-devel@lists.xenproject.org, John Snow , Richard Henderson , Kevin Wolf , Alexander Graf , qemu-block@nongnu.org, Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , "Richard W.M. Jones" , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= , Igor Mammedov , Hannes Reinecke , Aurelien Jarno , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: NUgwwcmIDIcK On Tue, Mar 20, 2018 at 11:12:00AM -0500, Eric Blake wrote: > On 03/19/2018 08:54 PM, Michael S. Tsirkin wrote: > > QEMU coding style at the moment asks for all non-system > > include files to be used with #include "foo.h". > > [I'm replying without having read the rest of the thread, so bear with me if > I repeat some of the other comments that have already been made] > > And Markus even just did a cleanup along those lines. > > > However this rule actually does not make sense and > > creates issues for when the included file is generated. > > > > In C, include "file" means look in current directory, > > then on include search path. Current directory here > > means the source file directory. > > By comparison include means look on include search path. > > It's also nice when "file" means file belonging to our project, and > means 3rd-party file. So we have to choose which semantics are easier; > perhaps better Makefile rules that prevent us from seeing stale files is a > better solution than figuring out which files are generated. That's what I've attempted here: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05421.html Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 16:40:48 +0000 Message-ID: <20180320164048.GB4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyKKK-0002Fw-VU for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 16:41:33 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Eric Blake Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Yongbok Kim , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTE6MTI6MDBBTSAtMDUwMCwgRXJpYyBCbGFrZSB3cm90 ZToKPiBPbiAwMy8xOS8yMDE4IDA4OjU0IFBNLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4g PiBRRU1VIGNvZGluZyBzdHlsZSBhdCB0aGUgbW9tZW50IGFza3MgZm9yIGFsbCBub24tc3lzdGVt Cj4gPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9vLmgiLgo+IAo+ IFtJJ20gcmVwbHlpbmcgd2l0aG91dCBoYXZpbmcgcmVhZCB0aGUgcmVzdCBvZiB0aGUgdGhyZWFk LCBzbyBiZWFyIHdpdGggbWUgaWYKPiBJIHJlcGVhdCBzb21lIG9mIHRoZSBvdGhlciBjb21tZW50 cyB0aGF0IGhhdmUgYWxyZWFkeSBiZWVuIG1hZGVdCj4gCj4gQW5kIE1hcmt1cyBldmVuIGp1c3Qg ZGlkIGEgY2xlYW51cCBhbG9uZyB0aG9zZSBsaW5lcy4KPiAKPiA+IEhvd2V2ZXIgdGhpcyBydWxl IGFjdHVhbGx5IGRvZXMgbm90IG1ha2Ugc2Vuc2UgYW5kCj4gPiBjcmVhdGVzIGlzc3VlcyBmb3Ig d2hlbiB0aGUgaW5jbHVkZWQgZmlsZSBpcyBnZW5lcmF0ZWQuCj4gPiAKPiA+IEluIEMsIGluY2x1 ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVudCBkaXJlY3RvcnksCj4gPiB0aGVuIG9uIGlu Y2x1ZGUgc2VhcmNoIHBhdGguIEN1cnJlbnQgZGlyZWN0b3J5IGhlcmUKPiA+IG1lYW5zIHRoZSBz b3VyY2UgZmlsZSBkaXJlY3RvcnkuCj4gPiBCeSBjb21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1l YW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiAKPiBJdCdzIGFsc28gbmljZSB3aGVu ICJmaWxlIiBtZWFucyBmaWxlIGJlbG9uZ2luZyB0byBvdXIgcHJvamVjdCwgYW5kIDxmaWxlPgo+ IG1lYW5zIDNyZC1wYXJ0eSBmaWxlLiAgU28gd2UgaGF2ZSB0byBjaG9vc2Ugd2hpY2ggc2VtYW50 aWNzIGFyZSBlYXNpZXI7Cj4gcGVyaGFwcyBiZXR0ZXIgTWFrZWZpbGUgcnVsZXMgdGhhdCBwcmV2 ZW50IHVzIGZyb20gc2VlaW5nIHN0YWxlIGZpbGVzIGlzIGEKPiBiZXR0ZXIgc29sdXRpb24gdGhh biBmaWd1cmluZyBvdXQgd2hpY2ggZmlsZXMgYXJlIGdlbmVyYXRlZC4KClRoYXQncyB3aGF0IEkn dmUgYXR0ZW1wdGVkIGhlcmU6CgogIGh0dHBzOi8vbGlzdHMuZ251Lm9yZy9hcmNoaXZlL2h0bWwv cWVtdS1kZXZlbC8yMDE4LTAzL21zZzA1NDIxLmh0bWwKCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6 IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20v cGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAg ICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRh bmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJh bmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 16:40:48 +0000 Message-ID: <20180320164048.GB4530@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Laurent Vivier , Gerd Hoffmann , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Yongbok Kim , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garci To: Eric Blake Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMTE6MTI6MDBBTSAtMDUwMCwgRXJpYyBCbGFrZSB3cm90 ZToKPiBPbiAwMy8xOS8yMDE4IDA4OjU0IFBNLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4g PiBRRU1VIGNvZGluZyBzdHlsZSBhdCB0aGUgbW9tZW50IGFza3MgZm9yIGFsbCBub24tc3lzdGVt Cj4gPiBpbmNsdWRlIGZpbGVzIHRvIGJlIHVzZWQgd2l0aCAjaW5jbHVkZSAiZm9vLmgiLgo+IAo+ IFtJJ20gcmVwbHlpbmcgd2l0aG91dCBoYXZpbmcgcmVhZCB0aGUgcmVzdCBvZiB0aGUgdGhyZWFk LCBzbyBiZWFyIHdpdGggbWUgaWYKPiBJIHJlcGVhdCBzb21lIG9mIHRoZSBvdGhlciBjb21tZW50 cyB0aGF0IGhhdmUgYWxyZWFkeSBiZWVuIG1hZGVdCj4gCj4gQW5kIE1hcmt1cyBldmVuIGp1c3Qg ZGlkIGEgY2xlYW51cCBhbG9uZyB0aG9zZSBsaW5lcy4KPiAKPiA+IEhvd2V2ZXIgdGhpcyBydWxl IGFjdHVhbGx5IGRvZXMgbm90IG1ha2Ugc2Vuc2UgYW5kCj4gPiBjcmVhdGVzIGlzc3VlcyBmb3Ig d2hlbiB0aGUgaW5jbHVkZWQgZmlsZSBpcyBnZW5lcmF0ZWQuCj4gPiAKPiA+IEluIEMsIGluY2x1 ZGUgImZpbGUiIG1lYW5zIGxvb2sgaW4gY3VycmVudCBkaXJlY3RvcnksCj4gPiB0aGVuIG9uIGlu Y2x1ZGUgc2VhcmNoIHBhdGguIEN1cnJlbnQgZGlyZWN0b3J5IGhlcmUKPiA+IG1lYW5zIHRoZSBz b3VyY2UgZmlsZSBkaXJlY3RvcnkuCj4gPiBCeSBjb21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1l YW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiAKPiBJdCdzIGFsc28gbmljZSB3aGVu ICJmaWxlIiBtZWFucyBmaWxlIGJlbG9uZ2luZyB0byBvdXIgcHJvamVjdCwgYW5kIDxmaWxlPgo+ IG1lYW5zIDNyZC1wYXJ0eSBmaWxlLiAgU28gd2UgaGF2ZSB0byBjaG9vc2Ugd2hpY2ggc2VtYW50 aWNzIGFyZSBlYXNpZXI7Cj4gcGVyaGFwcyBiZXR0ZXIgTWFrZWZpbGUgcnVsZXMgdGhhdCBwcmV2 ZW50IHVzIGZyb20gc2VlaW5nIHN0YWxlIGZpbGVzIGlzIGEKPiBiZXR0ZXIgc29sdXRpb24gdGhh biBmaWd1cmluZyBvdXQgd2hpY2ggZmlsZXMgYXJlIGdlbmVyYXRlZC4KClRoYXQncyB3aGF0IEkn dmUgYXR0ZW1wdGVkIGhlcmU6CgogIGh0dHBzOi8vbGlzdHMuZ251Lm9yZy9hcmNoaXZlL2h0bWwv cWVtdS1kZXZlbC8yMDE4LTAzL21zZzA1NDIxLmh0bWwKCgpSZWdhcmRzLApEYW5pZWwKLS0gCnw6 IGh0dHBzOi8vYmVycmFuZ2UuY29tICAgICAgLW8tICAgIGh0dHBzOi8vd3d3LmZsaWNrci5jb20v cGhvdG9zL2RiZXJyYW5nZSA6fAp8OiBodHRwczovL2xpYnZpcnQub3JnICAgICAgICAgLW8tICAg ICAgICAgICAgaHR0cHM6Ly9mc3RvcDEzOC5iZXJyYW5nZS5jb20gOnwKfDogaHR0cHM6Ly9lbnRh bmdsZS1waG90by5vcmcgICAgLW8tICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJh bmdlIDp8CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs