From: Tony Lindgren <tony@atomide.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-bluetooth@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
robh@kernel.org
Subject: Re: [RFC] Bluetooth: hci_ll: Convert to use h4_recv_buf helper
Date: Tue, 20 Mar 2018 14:11:51 -0700 [thread overview]
Message-ID: <20180320211151.GW5796@atomide.com> (raw)
In-Reply-To: <E7257152-583E-4BCC-B366-2627E62F1FE1@holtmann.org>
* Marcel Holtmann <marcel@holtmann.org> [180320 21:01]:
> Hi Tony,
>
> >>>> The HCILL or eHCILL protocol from TI is actually an H:4 protocol with a
> >>>> few extra events and thus can also use the h4_recv_buf helper. Instead
> >>>> of open coding the same funtionality add the extra events to the packet
> >>>> description table and use h4_recv_buf.
> >>>>
> >>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> >>>> ---
> >>>> drivers/bluetooth/Kconfig | 1 +
> >>>> drivers/bluetooth/hci_ll.c | 214 +++++++++++++++------------------------------
> >>>> 2 files changed, 70 insertions(+), 145 deletions(-)
> >>>
> >>> is anybody able to test this change for me and verify that it doesn’t break things.
> >>
> >> The diffstat looks nice :) I can give it a test on Motorola Droid 4
> >> later this week. If you want feedback a bit earlier, maybe Tony
> >> can give it a try (added to cc).
> >
> > I tried applying it from the mailing list archive against
> > current Linux next and -rc6 but it failed:
> >
> > patching file drivers/bluetooth/Kconfig
> > Hunk #1 succeeded at 147 with fuzz 2 (offset -13 lines).
> > patching file drivers/bluetooth/hci_ll.c
> > Hunk #2 succeeded at 88 (offset 4 lines).
> > Hunk #3 FAILED at 364.
> >
> > Any ideas which patch(es) I might be missing?
>
> that might be a git am issue and it being rather strict.
Or the patch not being correct copied from the archive.
Do you have a patchwork url for it or care to bounce the
patch to me?
Regards,
Tony
next prev parent reply other threads:[~2018-03-20 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 8:37 [RFC] Bluetooth: hci_ll: Convert to use h4_recv_buf helper Marcel Holtmann
2018-03-20 15:50 ` Marcel Holtmann
2018-03-20 17:28 ` Sebastian Reichel
2018-03-20 20:14 ` Tony Lindgren
2018-03-20 21:00 ` Marcel Holtmann
2018-03-20 21:11 ` Tony Lindgren [this message]
2018-03-20 23:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320211151.GW5796@atomide.com \
--to=tony@atomide.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.