From: "Michael S. Tsirkin" <mst@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
dgilbert@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] postcopy-ram: add a stub for postcopy_request_shared_page
Date: Wed, 21 Mar 2018 04:03:00 +0200 [thread overview]
Message-ID: <20180321040251-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180321012530.GB12771@lemon.usersys.redhat.com>
On Wed, Mar 21, 2018 at 09:25:30AM +0800, Fam Zheng wrote:
> On Tue, 03/20 12:34, no-reply@patchew.org wrote:
> > /tmp/qemu-test/src/migration/postcopy-ram.c:787:41: error: 'struct PostCopyFD' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb,
> > ^~~~~~~~~~
> > /tmp/qemu-test/src/migration/postcopy-ram.c:787:5: error: no previous prototype for 'postcopy_request_shared_page' [-Werror=missing-prototypes]
> > int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb,
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
>
> Is a "#include ..." line missing?
>
> Fam
This patch isn't against mainline.
next prev parent reply other threads:[~2018-03-21 2:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 14:39 [Qemu-devel] [PATCH] postcopy-ram: add a stub for postcopy_request_shared_page Michael S. Tsirkin
2018-03-20 16:08 ` Dr. David Alan Gilbert
2018-03-20 19:34 ` no-reply
2018-03-21 1:25 ` Fam Zheng
2018-03-21 2:03 ` Michael S. Tsirkin [this message]
2018-03-21 2:22 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321040251-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.