From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:50539 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbeCUIhr (ORCPT ); Wed, 21 Mar 2018 04:37:47 -0400 Received: by mail-wm0-f42.google.com with SMTP id f19so8132761wmc.0 for ; Wed, 21 Mar 2018 01:37:46 -0700 (PDT) Date: Wed, 21 Mar 2018 09:37:42 +0100 From: Daniel Vetter To: Laurent Pinchart Cc: Ulrich Hecht , Daniel Vetter , intel-gfx@lists.freedesktop.org, Linux-Renesas Subject: Re: [Intel-gfx] [PATCH igt 0/8] Non-Intel test suite fixes Message-ID: <20180321083742.GC14155@phenom.ffwll.local> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <20180316085551.GG14155@phenom.ffwll.local> <1868096.KLcM8ItYGk@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1868096.KLcM8ItYGk@avalon> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Tue, Mar 20, 2018 at 01:32:17PM +0200, Laurent Pinchart wrote: > Hello, > > On Monday, 19 March 2018 18:41:05 EET Ulrich Hecht wrote: > > On Fri, Mar 16, 2018 at 9:55 AM, Daniel Vetter wrote: > > > On Thu, Mar 15, 2018 at 03:45:36PM +0100, Ulrich Hecht wrote: > > >> Hi! > > >> > > >> I have run the tests on a Renesas R-Car M3-W's DU device, and have found > > >> a number of false negatives that mostly stem from use of Intel-specifics > > >> without checking if that makes sense first. So here's a bunch of fixes > > >> for those, hope they are generic enough for upstreaming. > > > > > > Nice, other people using this! Do you plan to maintain this actively going > > > forward, or is this more a one-off effort? > > > > For now, this is just an attempt at evaluating if this works for us. > > It has caught a few things that look like legitimate bugs to me, > > though... > > That's good news ! (Not that I'm happy that we have bugs, but catching them > shows that igt is useful for us). I hope this will help convincing management > that we should keep contributing to igt going forward. Yeah I'm really hoping other vendors could join the fun, and long-term we'd have a real kms validation suite. There's always going to be a need for vendor-specific tests (and we're happy to merge them, see e.g. vc4), but having a test suite that tries to be generic as much as possible, for an uapi that tries to be generic too, seems like a really good idea. Very much welcome on board! Aside: If there's anything we can do to help convince your management that this is good idea (like the rename from intel-gpu-tools to igt gpu tests we've done), please bring it up. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH igt 0/8] Non-Intel test suite fixes Date: Wed, 21 Mar 2018 09:37:42 +0100 Message-ID: <20180321083742.GC14155@phenom.ffwll.local> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <20180316085551.GG14155@phenom.ffwll.local> <1868096.KLcM8ItYGk@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C8766E906 for ; Wed, 21 Mar 2018 08:37:47 +0000 (UTC) Received: by mail-wm0-x22c.google.com with SMTP id e194so8055751wmd.3 for ; Wed, 21 Mar 2018 01:37:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1868096.KLcM8ItYGk@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Laurent Pinchart Cc: Ulrich Hecht , Linux-Renesas , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDE6MzI6MTdQTSArMDIwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBIZWxsbywKPiAKPiBPbiBNb25kYXksIDE5IE1hcmNoIDIwMTggMTg6NDE6MDUg RUVUIFVscmljaCBIZWNodCB3cm90ZToKPiA+IE9uIEZyaSwgTWFyIDE2LCAyMDE4IGF0IDk6NTUg QU0sIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiA+IE9uIFRodSwg TWFyIDE1LCAyMDE4IGF0IDAzOjQ1OjM2UE0gKzAxMDAsIFVscmljaCBIZWNodCB3cm90ZToKPiA+ ID4+IEhpIQo+ID4gPj4gCj4gPiA+PiBJIGhhdmUgcnVuIHRoZSB0ZXN0cyBvbiBhIFJlbmVzYXMg Ui1DYXIgTTMtVydzIERVIGRldmljZSwgYW5kIGhhdmUgZm91bmQKPiA+ID4+IGEgbnVtYmVyIG9m IGZhbHNlIG5lZ2F0aXZlcyB0aGF0IG1vc3RseSBzdGVtIGZyb20gdXNlIG9mIEludGVsLXNwZWNp Zmljcwo+ID4gPj4gd2l0aG91dCBjaGVja2luZyBpZiB0aGF0IG1ha2VzIHNlbnNlIGZpcnN0LiBT byBoZXJlJ3MgYSBidW5jaCBvZiBmaXhlcwo+ID4gPj4gZm9yIHRob3NlLCBob3BlIHRoZXkgYXJl IGdlbmVyaWMgZW5vdWdoIGZvciB1cHN0cmVhbWluZy4KPiA+ID4gCj4gPiA+IE5pY2UsIG90aGVy IHBlb3BsZSB1c2luZyB0aGlzISBEbyB5b3UgcGxhbiB0byBtYWludGFpbiB0aGlzIGFjdGl2ZWx5 IGdvaW5nCj4gPiA+IGZvcndhcmQsIG9yIGlzIHRoaXMgbW9yZSBhIG9uZS1vZmYgZWZmb3J0Pwo+ ID4gCj4gPiBGb3Igbm93LCB0aGlzIGlzIGp1c3QgYW4gYXR0ZW1wdCBhdCBldmFsdWF0aW5nIGlm IHRoaXMgd29ya3MgZm9yIHVzLgo+ID4gSXQgaGFzIGNhdWdodCBhIGZldyB0aGluZ3MgdGhhdCBs b29rIGxpa2UgbGVnaXRpbWF0ZSBidWdzIHRvIG1lLAo+ID4gdGhvdWdoLi4uCj4gCj4gVGhhdCdz IGdvb2QgbmV3cyAhIChOb3QgdGhhdCBJJ20gaGFwcHkgdGhhdCB3ZSBoYXZlIGJ1Z3MsIGJ1dCBj YXRjaGluZyB0aGVtIAo+IHNob3dzIHRoYXQgaWd0IGlzIHVzZWZ1bCBmb3IgdXMpLiBJIGhvcGUg dGhpcyB3aWxsIGhlbHAgY29udmluY2luZyBtYW5hZ2VtZW50IAo+IHRoYXQgd2Ugc2hvdWxkIGtl ZXAgY29udHJpYnV0aW5nIHRvIGlndCBnb2luZyBmb3J3YXJkLgoKWWVhaCBJJ20gcmVhbGx5IGhv cGluZyBvdGhlciB2ZW5kb3JzIGNvdWxkIGpvaW4gdGhlIGZ1biwgYW5kIGxvbmctdGVybQp3ZSdk IGhhdmUgYSByZWFsIGttcyB2YWxpZGF0aW9uIHN1aXRlLiBUaGVyZSdzIGFsd2F5cyBnb2luZyB0 byBiZSBhIG5lZWQKZm9yIHZlbmRvci1zcGVjaWZpYyB0ZXN0cyAoYW5kIHdlJ3JlIGhhcHB5IHRv IG1lcmdlIHRoZW0sIHNlZSBlLmcuIHZjNCksCmJ1dCBoYXZpbmcgYSB0ZXN0IHN1aXRlIHRoYXQg dHJpZXMgdG8gYmUgZ2VuZXJpYyBhcyBtdWNoIGFzIHBvc3NpYmxlLCBmb3IKYW4gdWFwaSB0aGF0 IHRyaWVzIHRvIGJlIGdlbmVyaWMgdG9vLCBzZWVtcyBsaWtlIGEgcmVhbGx5IGdvb2QgaWRlYS4K ClZlcnkgbXVjaCB3ZWxjb21lIG9uIGJvYXJkIQoKQXNpZGU6IElmIHRoZXJlJ3MgYW55dGhpbmcg d2UgY2FuIGRvIHRvIGhlbHAgY29udmluY2UgeW91ciBtYW5hZ2VtZW50IHRoYXQKdGhpcyBpcyBn b29kIGlkZWEgKGxpa2UgdGhlIHJlbmFtZSBmcm9tIGludGVsLWdwdS10b29scyB0byBpZ3QgZ3B1 IHRlc3RzCndlJ3ZlIGRvbmUpLCBwbGVhc2UgYnJpbmcgaXQgdXAuCgpDaGVlcnMsIERhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==