From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp5208164wmb; Wed, 21 Mar 2018 08:36:50 -0700 (PDT) X-Google-Smtp-Source: AG47ELsxKPsubfjkhA+2VITFOalNInTPjkIvGTQX+/Dcr0GB47XwIJXO9+tsoRn9g8Qsq+le9sbb X-Received: by 10.237.55.193 with SMTP id j59mr8203598qtb.110.1521646610093; Wed, 21 Mar 2018 08:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521646610; cv=none; d=google.com; s=arc-20160816; b=PyIOOfSKSHZcYW/X8u8W41y/202OnO9GH/mNX8bPBqmIFMqj2kiwQ78X0g4lKKb+tP UuDPJ6et4CmrjH8xwCf2ZuhbjRy9bKsb7Ff/Cdz7152i++n+ENuu3KhUEHBHuzbFMs0X fSJ00Cp3gNF5x6PSp5fA4SjktcT3nf5qJ+j/RgH6NHX0214VZtyUoXCrmtPBmPZaKLhm hmhgsrVc6TknO4OfUr3XdvwJZhJMlGBydX8m0pQ8UpAXhail84fITikMQwwb5scO5ZY3 lI40JjTZs15Q6yxVZDo9IBUoFSYFB+zboIEFrRuvhQgFxR8lvfhhNrvr+ZGonOBE44Jn TH7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date :arc-authentication-results; bh=rMI+0AHao3TXiOzMNOa7qwbt142WvSF0OMpWUvWT4pE=; b=m+jpX07+byWuG+nUS2+UH01u5Q84RMxaFj4slODtevMXQw271b+c4BHWj0/GzqUCSD /ssdFlpjSbEElHY4ujTts5YbymbZv8CUW7b2vOHAByr0SuSHv/X6tR3zx9MnGn0pEo0z UF1Rp1JtUN5DFpMuMVtbU9m5n/ImRs3KM7vEz2u6N2mAi5MBCO72J9WgQ0V35JMHxPkm zRiRWf7geNwyW7satqNsxsztT4/EXAhG+9Odhd6YmHPSZ/FZ5aA2ISM2t1QLewEkG03G 2bXpdB5LvvCEsGNKIGLYNXrDbIuJ4E907a7mq5GZqiuBCQMevOl++Kui+k0vbFHxSpbr lEhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c84si5985954qkh.117.2018.03.21.08.36.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Mar 2018 08:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:55819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyfnF-0003g6-Ij for alex.bennee@linaro.org; Wed, 21 Mar 2018 11:36:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyflU-0002QH-Vr for qemu-devel@nongnu.org; Wed, 21 Mar 2018 11:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyflT-0001Sa-Vp for qemu-devel@nongnu.org; Wed, 21 Mar 2018 11:35:01 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42866 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyflN-0001OB-4A; Wed, 21 Mar 2018 11:34:53 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFFABEAEB3; Wed, 21 Mar 2018 15:34:51 +0000 (UTC) Received: from localhost.localdomain (ovpn-117-20.ams2.redhat.com [10.36.117.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B43272166BDA; Wed, 21 Mar 2018 15:34:40 +0000 (UTC) Date: Wed, 21 Mar 2018 16:34:39 +0100 From: Kevin Wolf To: "Michael S. Tsirkin" Message-ID: <20180321153439.GC3898@localhost.localdomain> References: <1521642402-197739-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1521642402-197739-1-git-send-email-mst@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 21 Mar 2018 15:34:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 21 Mar 2018 15:34:52 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'kwolf@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-devel] [PATCH v2] qemu: replace "" with <> in headers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Pavel Dovgalyuk , Li Zhijian , David Hildenbrand , Jeff Cody , Stefan Hajnoczi , qemu-devel@nongnu.org, Keith Busch , Max Filippov , Hannes Reinecke , Gerd Hoffmann , Fam Zheng , Max Reitz , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Stefan Berger , Yongbok Kim , Michael Roth , "Richard W.M. Jones" , Christian Borntraeger , =?iso-8859-1?Q?Herv=E9?= Poussineau , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Shannon Zhao , Marcel Apfelbaum , Liu Yuan , Richard Henderson , Jason Wang , Artyom Tarasenko , Thomas Huth , Alistair Francis , Jiri Pirko , Eduardo Habkost , Corey Minyard , Amit Shah , Stefan Weil , Xie Changlong , Riku Voipio , Peter Lieven , "Dr. David Alan Gilbert" , Yuval Shaia , Greg Kurz , Anthony Perard , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Ronnie Sahlberg , Zhang Chen , xen-devel@lists.xenproject.org, John Snow , David Gibson , kvm@vger.kernel.org, qemu-block@nongnu.org, Peter Crosthwaite , Hitoshi Mitake , Markus Armbruster , qemu-s390x@nongnu.org, Marcelo Tosatti , Laurent Vivier , Juan Quintela , Subbaraya Sundeep , Michael Walle , Igor Mammedov , qemu-ppc@nongnu.org, Wen Congyang , Cornelia Huck , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: FBXAO01Vnqmj Am 21.03.2018 um 15:46 hat Michael S. Tsirkin geschrieben: > Our current scheme is to use > #include "" > for internal headers, and > #include <> > for external ones. > > Unfortunately this is not based on compiler support: from C point of > view, the "" form merely looks up headers in the current directory > and then falls back on <> directories. > > Thus, for example, a system header trace.h - should it be present - will > conflict with our local trace.h You're right that there is a conflict, even though only in one direction: "trace.h" is unambiguously the local trace.h in our source tree, but refers to the same local header rather than the system header as you would expect. An easy way to resolve this conflict would be using -iquote rather than -I for directories in the source tree, so that unambiguously refers to the system header and "trace.h" unambiguously refers to the QEMU header. > As another example of problems, a header by the same name in the source > directory will always be picked up first - before any headers in > the include directory. > > Let's change the scheme: make sure all headers that are not > in the source directory are included through a path > starting with qemu/ , thus: > > #include <> > > headers in the same directory as source are included with > > #include "" > > as per standard. > > This (untested) patch is just to start the discussion and does not > change all of the codebase. If there's agreement, this will be > run on all code to converting code to this scheme. Renaming files is always painful. If that's the fix, the cure might be worse than the disease. As far as I know, the conflict is only theoretical, so in that case I'd say: If it ain't broke, don't fix it. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH v2] qemu: replace "" with <> in headers Date: Wed, 21 Mar 2018 16:34:39 +0100 Message-ID: <20180321153439.GC3898@localhost.localdomain> References: <1521642402-197739-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyflO-00045V-N9 for xen-devel@lists.xenproject.org; Wed, 21 Mar 2018 15:34:54 +0000 Content-Disposition: inline In-Reply-To: <1521642402-197739-1-git-send-email-mst@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "Michael S. Tsirkin" Cc: Peter Maydell , Dmitry Fleytman , Pavel Dovgalyuk , Li Zhijian , David Hildenbrand , Jeff Cody , Stefan Hajnoczi , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Hannes Reinecke , Gerd Hoffmann , Fam Zheng , Max Reitz , Eric Blake , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Stefan Berger , Yongbok Kim , Michael Roth List-Id: xen-devel@lists.xenproject.org QW0gMjEuMDMuMjAxOCB1bSAxNTo0NiBoYXQgTWljaGFlbCBTLiBUc2lya2luIGdlc2NocmllYmVu Ogo+IE91ciBjdXJyZW50IHNjaGVtZSBpcyB0byB1c2UKPiAgI2luY2x1ZGUgIiIKPiBmb3IgaW50 ZXJuYWwgaGVhZGVycywgYW5kCj4gICNpbmNsdWRlIDw+Cj4gZm9yIGV4dGVybmFsIG9uZXMuCj4g Cj4gVW5mb3J0dW5hdGVseSB0aGlzIGlzIG5vdCBiYXNlZCBvbiBjb21waWxlciBzdXBwb3J0OiBm cm9tIEMgcG9pbnQgb2YKPiB2aWV3LCB0aGUgIiIgZm9ybSBtZXJlbHkgbG9va3MgdXAgaGVhZGVy cyBpbiB0aGUgY3VycmVudCBkaXJlY3RvcnkKPiBhbmQgdGhlbiBmYWxscyBiYWNrIG9uIDw+IGRp cmVjdG9yaWVzLgo+IAo+IFRodXMsIGZvciBleGFtcGxlLCBhIHN5c3RlbSBoZWFkZXIgdHJhY2Uu aCAtIHNob3VsZCBpdCBiZSBwcmVzZW50IC0gd2lsbAo+IGNvbmZsaWN0IHdpdGggb3VyIGxvY2Fs IHRyYWNlLmgKCllvdSdyZSByaWdodCB0aGF0IHRoZXJlIGlzIGEgY29uZmxpY3QsIGV2ZW4gdGhv dWdoIG9ubHkgaW4gb25lCmRpcmVjdGlvbjogInRyYWNlLmgiIGlzIHVuYW1iaWd1b3VzbHkgdGhl IGxvY2FsIHRyYWNlLmggaW4gb3VyIHNvdXJjZQp0cmVlLCBidXQgPHRyYWNlLmg+IHJlZmVycyB0 byB0aGUgc2FtZSBsb2NhbCBoZWFkZXIgcmF0aGVyIHRoYW4gdGhlCnN5c3RlbSBoZWFkZXIgYXMg eW91IHdvdWxkIGV4cGVjdC4KCkFuIGVhc3kgd2F5IHRvIHJlc29sdmUgdGhpcyBjb25mbGljdCB3 b3VsZCBiZSB1c2luZyAtaXF1b3RlIHJhdGhlciB0aGFuCi1JIGZvciBkaXJlY3RvcmllcyBpbiB0 aGUgc291cmNlIHRyZWUsIHNvIHRoYXQgPHRyYWNlLmg+IHVuYW1iaWd1b3VzbHkKcmVmZXJzIHRv IHRoZSBzeXN0ZW0gaGVhZGVyIGFuZCAidHJhY2UuaCIgdW5hbWJpZ3VvdXNseSByZWZlcnMgdG8g dGhlClFFTVUgaGVhZGVyLgoKPiBBcyBhbm90aGVyIGV4YW1wbGUgb2YgcHJvYmxlbXMsIGEgaGVh ZGVyIGJ5IHRoZSBzYW1lIG5hbWUgaW4gdGhlIHNvdXJjZQo+IGRpcmVjdG9yeSB3aWxsIGFsd2F5 cyBiZSBwaWNrZWQgdXAgZmlyc3QgLSBiZWZvcmUgYW55IGhlYWRlcnMgaW4KPiB0aGUgaW5jbHVk ZSBkaXJlY3RvcnkuCj4gCj4gTGV0J3MgY2hhbmdlIHRoZSBzY2hlbWU6IG1ha2Ugc3VyZSBhbGwg aGVhZGVycyB0aGF0IGFyZSBub3QKPiBpbiB0aGUgc291cmNlIGRpcmVjdG9yeSBhcmUgaW5jbHVk ZWQgdGhyb3VnaCBhIHBhdGgKPiBzdGFydGluZyB3aXRoIHFlbXUvICwgdGh1czoKPiAKPiAgI2lu Y2x1ZGUgPD4KPiAKPiBoZWFkZXJzIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyBzb3VyY2UgYXJl IGluY2x1ZGVkIHdpdGgKPiAKPiAgI2luY2x1ZGUgIiIKPiAKPiBhcyBwZXIgc3RhbmRhcmQuCj4g Cj4gVGhpcyAodW50ZXN0ZWQpIHBhdGNoIGlzIGp1c3QgdG8gc3RhcnQgdGhlIGRpc2N1c3Npb24g YW5kIGRvZXMgbm90Cj4gY2hhbmdlIGFsbCBvZiB0aGUgY29kZWJhc2UuIElmIHRoZXJlJ3MgYWdy ZWVtZW50LCB0aGlzIHdpbGwgYmUKPiBydW4gb24gYWxsIGNvZGUgdG8gY29udmVydGluZyBjb2Rl IHRvIHRoaXMgc2NoZW1lLgoKUmVuYW1pbmcgZmlsZXMgaXMgYWx3YXlzIHBhaW5mdWwuIElmIHRo YXQncyB0aGUgZml4LCB0aGUgY3VyZSBtaWdodCBiZQp3b3JzZSB0aGFuIHRoZSBkaXNlYXNlLiBB cyBmYXIgYXMgSSBrbm93LCB0aGUgY29uZmxpY3QgaXMgb25seQp0aGVvcmV0aWNhbCwgc28gaW4g dGhhdCBjYXNlIEknZCBzYXk6IElmIGl0IGFpbid0IGJyb2tlLCBkb24ndCBmaXggaXQuCgpLZXZp bgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9s aXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH v2] qemu: replace "" with <> in headers Date: Wed, 21 Mar 2018 16:34:39 +0100 Message-ID: <20180321153439.GC3898@localhost.localdomain> References: <1521642402-197739-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , Pavel Dovgalyuk , Li Zhijian , David Hildenbrand , Jeff Cody , Stefan Hajnoczi , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Hannes Reinecke , Gerd Hoffmann , Fam Zheng , Max Reitz , Eric Blake , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Stefan Berger , Yongbok Kim , Michael Roth Return-path: Content-Disposition: inline In-Reply-To: <1521642402-197739-1-git-send-email-mst@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org QW0gMjEuMDMuMjAxOCB1bSAxNTo0NiBoYXQgTWljaGFlbCBTLiBUc2lya2luIGdlc2NocmllYmVu Ogo+IE91ciBjdXJyZW50IHNjaGVtZSBpcyB0byB1c2UKPiAgI2luY2x1ZGUgIiIKPiBmb3IgaW50 ZXJuYWwgaGVhZGVycywgYW5kCj4gICNpbmNsdWRlIDw+Cj4gZm9yIGV4dGVybmFsIG9uZXMuCj4g Cj4gVW5mb3J0dW5hdGVseSB0aGlzIGlzIG5vdCBiYXNlZCBvbiBjb21waWxlciBzdXBwb3J0OiBm cm9tIEMgcG9pbnQgb2YKPiB2aWV3LCB0aGUgIiIgZm9ybSBtZXJlbHkgbG9va3MgdXAgaGVhZGVy cyBpbiB0aGUgY3VycmVudCBkaXJlY3RvcnkKPiBhbmQgdGhlbiBmYWxscyBiYWNrIG9uIDw+IGRp cmVjdG9yaWVzLgo+IAo+IFRodXMsIGZvciBleGFtcGxlLCBhIHN5c3RlbSBoZWFkZXIgdHJhY2Uu aCAtIHNob3VsZCBpdCBiZSBwcmVzZW50IC0gd2lsbAo+IGNvbmZsaWN0IHdpdGggb3VyIGxvY2Fs IHRyYWNlLmgKCllvdSdyZSByaWdodCB0aGF0IHRoZXJlIGlzIGEgY29uZmxpY3QsIGV2ZW4gdGhv dWdoIG9ubHkgaW4gb25lCmRpcmVjdGlvbjogInRyYWNlLmgiIGlzIHVuYW1iaWd1b3VzbHkgdGhl IGxvY2FsIHRyYWNlLmggaW4gb3VyIHNvdXJjZQp0cmVlLCBidXQgPHRyYWNlLmg+IHJlZmVycyB0 byB0aGUgc2FtZSBsb2NhbCBoZWFkZXIgcmF0aGVyIHRoYW4gdGhlCnN5c3RlbSBoZWFkZXIgYXMg eW91IHdvdWxkIGV4cGVjdC4KCkFuIGVhc3kgd2F5IHRvIHJlc29sdmUgdGhpcyBjb25mbGljdCB3 b3VsZCBiZSB1c2luZyAtaXF1b3RlIHJhdGhlciB0aGFuCi1JIGZvciBkaXJlY3RvcmllcyBpbiB0 aGUgc291cmNlIHRyZWUsIHNvIHRoYXQgPHRyYWNlLmg+IHVuYW1iaWd1b3VzbHkKcmVmZXJzIHRv IHRoZSBzeXN0ZW0gaGVhZGVyIGFuZCAidHJhY2UuaCIgdW5hbWJpZ3VvdXNseSByZWZlcnMgdG8g dGhlClFFTVUgaGVhZGVyLgoKPiBBcyBhbm90aGVyIGV4YW1wbGUgb2YgcHJvYmxlbXMsIGEgaGVh ZGVyIGJ5IHRoZSBzYW1lIG5hbWUgaW4gdGhlIHNvdXJjZQo+IGRpcmVjdG9yeSB3aWxsIGFsd2F5 cyBiZSBwaWNrZWQgdXAgZmlyc3QgLSBiZWZvcmUgYW55IGhlYWRlcnMgaW4KPiB0aGUgaW5jbHVk ZSBkaXJlY3RvcnkuCj4gCj4gTGV0J3MgY2hhbmdlIHRoZSBzY2hlbWU6IG1ha2Ugc3VyZSBhbGwg aGVhZGVycyB0aGF0IGFyZSBub3QKPiBpbiB0aGUgc291cmNlIGRpcmVjdG9yeSBhcmUgaW5jbHVk ZWQgdGhyb3VnaCBhIHBhdGgKPiBzdGFydGluZyB3aXRoIHFlbXUvICwgdGh1czoKPiAKPiAgI2lu Y2x1ZGUgPD4KPiAKPiBoZWFkZXJzIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyBzb3VyY2UgYXJl IGluY2x1ZGVkIHdpdGgKPiAKPiAgI2luY2x1ZGUgIiIKPiAKPiBhcyBwZXIgc3RhbmRhcmQuCj4g Cj4gVGhpcyAodW50ZXN0ZWQpIHBhdGNoIGlzIGp1c3QgdG8gc3RhcnQgdGhlIGRpc2N1c3Npb24g YW5kIGRvZXMgbm90Cj4gY2hhbmdlIGFsbCBvZiB0aGUgY29kZWJhc2UuIElmIHRoZXJlJ3MgYWdy ZWVtZW50LCB0aGlzIHdpbGwgYmUKPiBydW4gb24gYWxsIGNvZGUgdG8gY29udmVydGluZyBjb2Rl IHRvIHRoaXMgc2NoZW1lLgoKUmVuYW1pbmcgZmlsZXMgaXMgYWx3YXlzIHBhaW5mdWwuIElmIHRo YXQncyB0aGUgZml4LCB0aGUgY3VyZSBtaWdodCBiZQp3b3JzZSB0aGFuIHRoZSBkaXNlYXNlLiBB cyBmYXIgYXMgSSBrbm93LCB0aGUgY29uZmxpY3QgaXMgb25seQp0aGVvcmV0aWNhbCwgc28gaW4g dGhhdCBjYXNlIEknZCBzYXk6IElmIGl0IGFpbid0IGJyb2tlLCBkb24ndCBmaXggaXQuCgpLZXZp bgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9s aXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyflU-0002QH-Vr for qemu-devel@nongnu.org; Wed, 21 Mar 2018 11:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyflT-0001Sa-Vp for qemu-devel@nongnu.org; Wed, 21 Mar 2018 11:35:01 -0400 Date: Wed, 21 Mar 2018 16:34:39 +0100 From: Kevin Wolf Message-ID: <20180321153439.GC3898@localhost.localdomain> References: <1521642402-197739-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1521642402-197739-1-git-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qemu: replace "" with <> in headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Thomas Huth , Laurent Vivier , Peter Maydell , Dmitry Fleytman , Ronnie Sahlberg , Li Zhijian , David Hildenbrand , Jeff Cody , Zhang Chen , BALATON Zoltan , Keith Busch , Max Filippov , Gerd Hoffmann , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Greg Kurz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , xen-devel@lists.xenproject.org, John Snow , Richard Henderson , qemu-block@nongnu.org, Peter Crosthwaite , Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , "Richard W.M. Jones" , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Igor Mammedov , Hannes Reinecke , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Am 21.03.2018 um 15:46 hat Michael S. Tsirkin geschrieben: > Our current scheme is to use > #include "" > for internal headers, and > #include <> > for external ones. > > Unfortunately this is not based on compiler support: from C point of > view, the "" form merely looks up headers in the current directory > and then falls back on <> directories. > > Thus, for example, a system header trace.h - should it be present - will > conflict with our local trace.h You're right that there is a conflict, even though only in one direction: "trace.h" is unambiguously the local trace.h in our source tree, but refers to the same local header rather than the system header as you would expect. An easy way to resolve this conflict would be using -iquote rather than -I for directories in the source tree, so that unambiguously refers to the system header and "trace.h" unambiguously refers to the QEMU header. > As another example of problems, a header by the same name in the source > directory will always be picked up first - before any headers in > the include directory. > > Let's change the scheme: make sure all headers that are not > in the source directory are included through a path > starting with qemu/ , thus: > > #include <> > > headers in the same directory as source are included with > > #include "" > > as per standard. > > This (untested) patch is just to start the discussion and does not > change all of the codebase. If there's agreement, this will be > run on all code to converting code to this scheme. Renaming files is always painful. If that's the fix, the cure might be worse than the disease. As far as I know, the conflict is only theoretical, so in that case I'd say: If it ain't broke, don't fix it. Kevin