From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp5082704wmb; Wed, 21 Mar 2018 06:43:13 -0700 (PDT) X-Google-Smtp-Source: AG47ELvo4O4DnbIBSvfni+jk17XnM0D5TZAYNolGRzxZok5K2McONmd+tiKpf1N4oqFOtLgWmtVg X-Received: by 10.233.216.65 with SMTP id u62mr30199440qkf.133.1521639793397; Wed, 21 Mar 2018 06:43:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521639793; cv=none; d=google.com; s=arc-20160816; b=p0UFw+JKQpYn5kMmJoC1VwmCH/U6syjl+y1tnbWIbkBey6J2LX3w3HXI2dc44HGWxW n9+8ve2SeFF/+8htpz0mg0jBsiwVfMmtGB3Pt/ATxT0npX6ZD3hNtyKSBNoigpd5gABH A8deYCzKxtu1PXFj1kG1WgF+GBkSG2c2jApni+2lI9/zxdUFiUbeyveMOjMqhP5pRdc4 c7RbpCpV2e7hsrMe8PjXxvJ0o37DPxxGq2ZRYo+CamVZJhL4TMjO/vooneaKxIYJYhLQ izGPFdc62q4xvDfohkf99nVUyTNpmx/X8FKhb9vjpgKjOI1CxwkPSzHnEibiJoWSwzH5 FoZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:in-reply-to:content-disposition :mime-version:references:message-id:to:from:date :arc-authentication-results; bh=9venW47e/Ax7tVcHEsrFJOGPm7KhMLsIjw+MEUpdrp0=; b=qke7XidV0ZmaDAeRYtEgPUazCvMn4mO540Mw+Rj1+bae3eR8HSD6BWl5fNohfCdM0g jKjTlj4kKkUfHeRhC1ZlqhXTAYwKA9gUQKEGU0D+/ppWnXb7lVRu2izAQTpGgt8XK8tf 55h/TDWlY6AaLqCw+KBNlIM5QQwuHWvVGeby6G3Ng0KgZMmI/Xt0CxyG+fehHeRJQIdF a6kgoO3Dv9xfY2X/dPqdSd26/MBnym2R97RenDQJVNh6eSG/F1xb9Mp47PTUNw0dBdC0 swUE4AZLClwX4aL8R2cqYXeTa7R6zwmpNFMNcRS8meGaURFIm6sL+N/oNwoxtyFzjiI8 6ztw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id p41si268100qta.315.2018.03.21.06.43.13 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Mar 2018 06:43:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:55193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eye1I-0001ZE-TV for alex.bennee@linaro.org; Wed, 21 Mar 2018 09:43:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eye14-0001XG-NW for qemu-arm@nongnu.org; Wed, 21 Mar 2018 09:43:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eye13-0002Ud-Df for qemu-arm@nongnu.org; Wed, 21 Mar 2018 09:42:58 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:32994 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eye13-0002U1-71; Wed, 21 Mar 2018 09:42:57 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B4E26813F73E; Wed, 21 Mar 2018 13:42:47 +0000 (UTC) Received: from redhat.com (ovpn-124-179.rdu2.redhat.com [10.10.124.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D70A10B009A; Wed, 21 Mar 2018 13:42:22 +0000 (UTC) Date: Wed, 21 Mar 2018 15:42:22 +0200 From: "Michael S. Tsirkin" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Message-ID: <20180321153510-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320135548-mutt-send-email-mst@kernel.org> <459fa95d-8f0a-22fa-80fb-4af22ccf49b3@redhat.com> <20180321150543-mutt-send-email-mst@kernel.org> <20180321132953.GK8551@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180321132953.GK8551@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 21 Mar 2018 13:42:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 21 Mar 2018 13:42:48 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-arm] [Qemu-ppc] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Pavel Dovgalyuk , Li Zhijian , David Hildenbrand , Jeff Cody , Stefan Hajnoczi , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Hannes Reinecke , Gerd Hoffmann , Fam Zheng , Max Reitz , Eric Blake , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Stefan Berger , Yongbok Kim , Michael Roth , "Richard W.M. Jones" , Christian Borntraeger , =?iso-8859-1?Q?Herv=E9?= Poussineau , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Shannon Zhao , Marcel Apfelbaum , Liu Yuan , Richard Henderson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Thomas Huth , Alistair Francis , Jiri Pirko , Eduardo Habkost , Corey Minyard , Amit Shah , Stefan Weil , Xie Changlong , Riku Voipio , Peter Lieven , "Dr. David Alan Gilbert" , Yuval Shaia , Greg Kurz , Anthony Perard , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Ronnie Sahlberg , Zhang Chen , xen-devel@lists.xenproject.org, John Snow , David Gibson , Kevin Wolf , kvm@vger.kernel.org, qemu-block@nongnu.org, Hitoshi Mitake , Markus Armbruster , qemu-s390x@nongnu.org, Marcelo Tosatti , Laurent Vivier , Juan Quintela , Subbaraya Sundeep , Michael Walle , Igor Mammedov , qemu-ppc@nongnu.org, Wen Congyang , Cornelia Huck , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 74KOvaFrppMs On Wed, Mar 21, 2018 at 01:29:53PM +0000, Daniel P. Berrang=E9 wrote: > On Wed, Mar 21, 2018 at 03:08:36PM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 21, 2018 at 08:16:00AM +0100, Thomas Huth wrote: > > > On 20.03.2018 13:05, Michael S. Tsirkin wrote: > > > > On Tue, Mar 20, 2018 at 09:58:23AM +0100, Laurent Vivier wrote: > > > >> Le 20/03/2018 =E0 02:54, Michael S. Tsirkin a =E9crit=A0: > > > >>> QEMU coding style at the moment asks for all non-system > > > >>> include files to be used with #include "foo.h". > > > >>> However this rule actually does not make sense and > > > >>> creates issues for when the included file is generated. > > > >> > > > >> If you change that, we can have issue when a system include has = the same > > > >> name as our local include. With "", system header are take= n first. > > > >=20 > > > > Are you sure? I just tested and that is not the case with > > > > either gcc or clang. > > > >=20 > > > >>> In C, include "file" means look in current directory, > > > >>> then on include search path. Current directory here > > > >>> means the source file directory. > > > >>> By comparison include means look on include search path. > > > >> > > > >> Not exactly, there is the notion of "system header" too. > > > >> > > > >> https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html > > > >> > > > >> #include > > > >> This variant is used for system header files. It searches for a = file > > > >> named file in a standard list of system directories. You can pre= pend > > > >> directories to this list with the -I option (see Invocation). > > > >=20 > > > > This is exactly what we do. > > > >=20 > > > >> #include "file" > > > >> This variant is used for header files of your own program. It se= arches > > > >> for a file named file first in the directory containing the curr= ent > > > >> file, then in the quote directories and then the same directorie= s used > > > >> for . You can prepend directories to the list of quote dir= ectories > > > >> with the -iquote option. > > > >=20 > > > > Since we do not use -iquote, "" just adds the current directory. > > >=20 > > > So why don't we simply switch to use -iquote instead of -I for addi= ng > > > search paths for our own headers? We then would get a clean separat= ion > > > of QEMU headers from system headers. > > >=20 > > > Thomas > >=20 > > It still leaves us with a host of problems e.g. the problem of stale > > headers in the source directory. >=20 > We have a patch on list which effectively solves the problem of stale > generated files in source directory, so that's largely a non-issue at > this point IMHO. >=20 > Regards, > Daniel That was just one, and the solution is just to fail build. I think we can strive to address at least some of the following: - make sure that an incorrect use of a header fails to build - make it easier for new developers to understand the codebase - build correctly rather than fail in as many configurations as possible - actually support a mix of in and out of tree builds I think my patch under discussion does not address all issues here. I'll post a new proposal now. > --=20 > |: https://berrange.com -o- https://www.flickr.com/photos/dberr= ange :| > |: https://libvirt.org -o- https://fstop138.berrange= .com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberr= ange :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-ppc] [PATCH] qemu: include generated files with <> and not "" Date: Wed, 21 Mar 2018 15:42:22 +0200 Message-ID: <20180321153510-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320135548-mutt-send-email-mst@kernel.org> <459fa95d-8f0a-22fa-80fb-4af22ccf49b3@redhat.com> <20180321150543-mutt-send-email-mst@kernel.org> <20180321132953.GK8551@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eye0x-0001wp-6y for xen-devel@lists.xenproject.org; Wed, 21 Mar 2018 13:42:51 +0000 Content-Disposition: inline In-Reply-To: <20180321132953.GK8551@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Pavel Dovgalyuk , Li Zhijian , David Hildenbrand , Jeff Cody , Stefan Hajnoczi , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Hannes Reinecke , Gerd Hoffmann , Fam Zheng , Max Reitz , Eric Blake , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Stefan Berger , Yongbok Kim , Michael List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBNYXIgMjEsIDIwMTggYXQgMDE6Mjk6NTNQTSArMDAwMCwgRGFuaWVsIFAuIEJlcnJh bmfDqSB3cm90ZToKPiBPbiBXZWQsIE1hciAyMSwgMjAxOCBhdCAwMzowODozNlBNICswMjAwLCBN aWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gPiBPbiBXZWQsIE1hciAyMSwgMjAxOCBhdCAwODox NjowMEFNICswMTAwLCBUaG9tYXMgSHV0aCB3cm90ZToKPiA+ID4gT24gMjAuMDMuMjAxOCAxMzow NSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgTWFyIDIwLCAyMDE4 IGF0IDA5OjU4OjIzQU0gKzAxMDAsIExhdXJlbnQgVml2aWVyIHdyb3RlOgo+ID4gPiA+PiBMZSAy MC8wMy8yMDE4IMOgIDAyOjU0LCBNaWNoYWVsIFMuIFRzaXJraW4gYSDDqWNyaXTCoDoKPiA+ID4g Pj4+IFFFTVUgY29kaW5nIHN0eWxlIGF0IHRoZSBtb21lbnQgYXNrcyBmb3IgYWxsIG5vbi1zeXN0 ZW0KPiA+ID4gPj4+IGluY2x1ZGUgZmlsZXMgdG8gYmUgdXNlZCB3aXRoICNpbmNsdWRlICJmb28u aCIuCj4gPiA+ID4+PiBIb3dldmVyIHRoaXMgcnVsZSBhY3R1YWxseSBkb2VzIG5vdCBtYWtlIHNl bnNlIGFuZAo+ID4gPiA+Pj4gY3JlYXRlcyBpc3N1ZXMgZm9yIHdoZW4gdGhlIGluY2x1ZGVkIGZp bGUgaXMgZ2VuZXJhdGVkLgo+ID4gPiA+Pgo+ID4gPiA+PiBJZiB5b3UgY2hhbmdlIHRoYXQsIHdl IGNhbiBoYXZlIGlzc3VlIHdoZW4gYSBzeXN0ZW0gaW5jbHVkZSBoYXMgdGhlIHNhbWUKPiA+ID4g Pj4gbmFtZSBhcyBvdXIgbG9jYWwgaW5jbHVkZS4gV2l0aCAiPEZJTEU+Iiwgc3lzdGVtIGhlYWRl ciBhcmUgdGFrZW4gZmlyc3QuCj4gPiA+ID4gCj4gPiA+ID4gQXJlIHlvdSBzdXJlPyBJIGp1c3Qg dGVzdGVkIGFuZCB0aGF0IGlzIG5vdCB0aGUgY2FzZSB3aXRoCj4gPiA+ID4gZWl0aGVyIGdjYyBv ciBjbGFuZy4KPiA+ID4gPiAKPiA+ID4gPj4+IEluIEMsIGluY2x1ZGUgImZpbGUiIG1lYW5zIGxv b2sgaW4gY3VycmVudCBkaXJlY3RvcnksCj4gPiA+ID4+PiB0aGVuIG9uIGluY2x1ZGUgc2VhcmNo IHBhdGguIEN1cnJlbnQgZGlyZWN0b3J5IGhlcmUKPiA+ID4gPj4+IG1lYW5zIHRoZSBzb3VyY2Ug ZmlsZSBkaXJlY3RvcnkuCj4gPiA+ID4+PiBCeSBjb21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1l YW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiA+ID4gPj4KPiA+ID4gPj4gTm90IGV4 YWN0bHksIHRoZXJlIGlzIHRoZSBub3Rpb24gb2YgInN5c3RlbSBoZWFkZXIiIHRvby4KPiA+ID4g Pj4KPiA+ID4gPj4gaHR0cHM6Ly9nY2MuZ251Lm9yZy9vbmxpbmVkb2NzL2NwcC9JbmNsdWRlLVN5 bnRheC5odG1sCj4gPiA+ID4+Cj4gPiA+ID4+ICNpbmNsdWRlIDxmaWxlPgo+ID4gPiA+PiBUaGlz IHZhcmlhbnQgaXMgdXNlZCBmb3Igc3lzdGVtIGhlYWRlciBmaWxlcy4gSXQgc2VhcmNoZXMgZm9y IGEgZmlsZQo+ID4gPiA+PiBuYW1lZCBmaWxlIGluIGEgc3RhbmRhcmQgbGlzdCBvZiBzeXN0ZW0g ZGlyZWN0b3JpZXMuIFlvdSBjYW4gcHJlcGVuZAo+ID4gPiA+PiBkaXJlY3RvcmllcyB0byB0aGlz IGxpc3Qgd2l0aCB0aGUgLUkgb3B0aW9uIChzZWUgSW52b2NhdGlvbikuCj4gPiA+ID4gCj4gPiA+ ID4gVGhpcyBpcyBleGFjdGx5IHdoYXQgd2UgZG8uCj4gPiA+ID4gCj4gPiA+ID4+ICNpbmNsdWRl ICJmaWxlIgo+ID4gPiA+PiBUaGlzIHZhcmlhbnQgaXMgdXNlZCBmb3IgaGVhZGVyIGZpbGVzIG9m IHlvdXIgb3duIHByb2dyYW0uIEl0IHNlYXJjaGVzCj4gPiA+ID4+IGZvciBhIGZpbGUgbmFtZWQg ZmlsZSBmaXJzdCBpbiB0aGUgZGlyZWN0b3J5IGNvbnRhaW5pbmcgdGhlIGN1cnJlbnQKPiA+ID4g Pj4gZmlsZSwgdGhlbiBpbiB0aGUgcXVvdGUgZGlyZWN0b3JpZXMgYW5kIHRoZW4gdGhlIHNhbWUg ZGlyZWN0b3JpZXMgdXNlZAo+ID4gPiA+PiBmb3IgPGZpbGU+LiBZb3UgY2FuIHByZXBlbmQgZGly ZWN0b3JpZXMgdG8gdGhlIGxpc3Qgb2YgcXVvdGUgZGlyZWN0b3JpZXMKPiA+ID4gPj4gd2l0aCB0 aGUgLWlxdW90ZSBvcHRpb24uCj4gPiA+ID4gCj4gPiA+ID4gU2luY2Ugd2UgZG8gbm90IHVzZSAt aXF1b3RlLCAiIiBqdXN0IGFkZHMgdGhlIGN1cnJlbnQgZGlyZWN0b3J5Lgo+ID4gPiAKPiA+ID4g U28gd2h5IGRvbid0IHdlIHNpbXBseSBzd2l0Y2ggdG8gdXNlIC1pcXVvdGUgaW5zdGVhZCBvZiAt SSBmb3IgYWRkaW5nCj4gPiA+IHNlYXJjaCBwYXRocyBmb3Igb3VyIG93biBoZWFkZXJzPyBXZSB0 aGVuIHdvdWxkIGdldCBhIGNsZWFuIHNlcGFyYXRpb24KPiA+ID4gb2YgUUVNVSBoZWFkZXJzIGZy b20gc3lzdGVtIGhlYWRlcnMuCj4gPiA+IAo+ID4gPiAgVGhvbWFzCj4gPiAKPiA+IEl0IHN0aWxs IGxlYXZlcyB1cyB3aXRoIGEgaG9zdCBvZiBwcm9ibGVtcyBlLmcuIHRoZSBwcm9ibGVtIG9mIHN0 YWxlCj4gPiBoZWFkZXJzIGluIHRoZSBzb3VyY2UgZGlyZWN0b3J5Lgo+IAo+IFdlIGhhdmUgYSBw YXRjaCBvbiBsaXN0IHdoaWNoIGVmZmVjdGl2ZWx5IHNvbHZlcyB0aGUgcHJvYmxlbSBvZiBzdGFs ZQo+IGdlbmVyYXRlZCBmaWxlcyBpbiBzb3VyY2UgZGlyZWN0b3J5LCBzbyB0aGF0J3MgbGFyZ2Vs eSBhIG5vbi1pc3N1ZSBhdAo+IHRoaXMgcG9pbnQgSU1ITy4KPiAKPiBSZWdhcmRzLAo+IERhbmll bAoKVGhhdCB3YXMganVzdCBvbmUsIGFuZCB0aGUgc29sdXRpb24gaXMganVzdCB0byBmYWlsIGJ1 aWxkLgpJIHRoaW5rIHdlIGNhbiBzdHJpdmUgdG8gYWRkcmVzcyBhdCBsZWFzdCBzb21lIG9mIHRo ZSBmb2xsb3dpbmc6Ci0gbWFrZSBzdXJlIHRoYXQgYW4gaW5jb3JyZWN0IHVzZSBvZiBhIGhlYWRl ciBmYWlscyB0byBidWlsZAotIG1ha2UgaXQgZWFzaWVyIGZvciBuZXcgZGV2ZWxvcGVycyB0byB1 bmRlcnN0YW5kIHRoZSBjb2RlYmFzZQotIGJ1aWxkIGNvcnJlY3RseSByYXRoZXIgdGhhbiBmYWls IGluIGFzIG1hbnkgY29uZmlndXJhdGlvbnMgYXMgcG9zc2libGUKLSBhY3R1YWxseSBzdXBwb3J0 IGEgbWl4IG9mIGluIGFuZCBvdXQgb2YgdHJlZSBidWlsZHMKCkkgdGhpbmsgbXkgcGF0Y2ggdW5k ZXIgZGlzY3Vzc2lvbiBkb2VzIG5vdCBhZGRyZXNzIGFsbCBpc3N1ZXMgaGVyZS4KSSdsbCBwb3N0 IGEgbmV3IHByb3Bvc2FsIG5vdy4KCj4gLS0gCj4gfDogaHR0cHM6Ly9iZXJyYW5nZS5jb20gICAg ICAtby0gICAgaHR0cHM6Ly93d3cuZmxpY2tyLmNvbS9waG90b3MvZGJlcnJhbmdlIDp8Cj4gfDog aHR0cHM6Ly9saWJ2aXJ0Lm9yZyAgICAgICAgIC1vLSAgICAgICAgICAgIGh0dHBzOi8vZnN0b3Ax MzguYmVycmFuZ2UuY29tIDp8Cj4gfDogaHR0cHM6Ly9lbnRhbmdsZS1waG90by5vcmcgICAgLW8t ICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJhbmdlIDp8CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-ppc] [PATCH] qemu: include generated files with <> and not "" Date: Wed, 21 Mar 2018 15:42:22 +0200 Message-ID: <20180321153510-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320135548-mutt-send-email-mst@kernel.org> <459fa95d-8f0a-22fa-80fb-4af22ccf49b3@redhat.com> <20180321150543-mutt-send-email-mst@kernel.org> <20180321132953.GK8551@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Pavel Dovgalyuk , Li Zhijian , David Hildenbrand , Jeff Cody , Stefan Hajnoczi , qemu-devel@nongnu.org, BALATON Zoltan , Keith Busch , Max Filippov , Hannes Reinecke , Gerd Hoffmann , Fam Zheng , Max Reitz , Eric Blake , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Stefan Berger , Yongbok Kim , Michael R To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Return-path: Content-Disposition: inline In-Reply-To: <20180321132953.GK8551@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gV2VkLCBNYXIgMjEsIDIwMTggYXQgMDE6Mjk6NTNQTSArMDAwMCwgRGFuaWVsIFAuIEJlcnJh bmfDqSB3cm90ZToKPiBPbiBXZWQsIE1hciAyMSwgMjAxOCBhdCAwMzowODozNlBNICswMjAwLCBN aWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gPiBPbiBXZWQsIE1hciAyMSwgMjAxOCBhdCAwODox NjowMEFNICswMTAwLCBUaG9tYXMgSHV0aCB3cm90ZToKPiA+ID4gT24gMjAuMDMuMjAxOCAxMzow NSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgTWFyIDIwLCAyMDE4 IGF0IDA5OjU4OjIzQU0gKzAxMDAsIExhdXJlbnQgVml2aWVyIHdyb3RlOgo+ID4gPiA+PiBMZSAy MC8wMy8yMDE4IMOgIDAyOjU0LCBNaWNoYWVsIFMuIFRzaXJraW4gYSDDqWNyaXTCoDoKPiA+ID4g Pj4+IFFFTVUgY29kaW5nIHN0eWxlIGF0IHRoZSBtb21lbnQgYXNrcyBmb3IgYWxsIG5vbi1zeXN0 ZW0KPiA+ID4gPj4+IGluY2x1ZGUgZmlsZXMgdG8gYmUgdXNlZCB3aXRoICNpbmNsdWRlICJmb28u aCIuCj4gPiA+ID4+PiBIb3dldmVyIHRoaXMgcnVsZSBhY3R1YWxseSBkb2VzIG5vdCBtYWtlIHNl bnNlIGFuZAo+ID4gPiA+Pj4gY3JlYXRlcyBpc3N1ZXMgZm9yIHdoZW4gdGhlIGluY2x1ZGVkIGZp bGUgaXMgZ2VuZXJhdGVkLgo+ID4gPiA+Pgo+ID4gPiA+PiBJZiB5b3UgY2hhbmdlIHRoYXQsIHdl IGNhbiBoYXZlIGlzc3VlIHdoZW4gYSBzeXN0ZW0gaW5jbHVkZSBoYXMgdGhlIHNhbWUKPiA+ID4g Pj4gbmFtZSBhcyBvdXIgbG9jYWwgaW5jbHVkZS4gV2l0aCAiPEZJTEU+Iiwgc3lzdGVtIGhlYWRl ciBhcmUgdGFrZW4gZmlyc3QuCj4gPiA+ID4gCj4gPiA+ID4gQXJlIHlvdSBzdXJlPyBJIGp1c3Qg dGVzdGVkIGFuZCB0aGF0IGlzIG5vdCB0aGUgY2FzZSB3aXRoCj4gPiA+ID4gZWl0aGVyIGdjYyBv ciBjbGFuZy4KPiA+ID4gPiAKPiA+ID4gPj4+IEluIEMsIGluY2x1ZGUgImZpbGUiIG1lYW5zIGxv b2sgaW4gY3VycmVudCBkaXJlY3RvcnksCj4gPiA+ID4+PiB0aGVuIG9uIGluY2x1ZGUgc2VhcmNo IHBhdGguIEN1cnJlbnQgZGlyZWN0b3J5IGhlcmUKPiA+ID4gPj4+IG1lYW5zIHRoZSBzb3VyY2Ug ZmlsZSBkaXJlY3RvcnkuCj4gPiA+ID4+PiBCeSBjb21wYXJpc29uIGluY2x1ZGUgPGZpbGU+IG1l YW5zIGxvb2sgb24gaW5jbHVkZSBzZWFyY2ggcGF0aC4KPiA+ID4gPj4KPiA+ID4gPj4gTm90IGV4 YWN0bHksIHRoZXJlIGlzIHRoZSBub3Rpb24gb2YgInN5c3RlbSBoZWFkZXIiIHRvby4KPiA+ID4g Pj4KPiA+ID4gPj4gaHR0cHM6Ly9nY2MuZ251Lm9yZy9vbmxpbmVkb2NzL2NwcC9JbmNsdWRlLVN5 bnRheC5odG1sCj4gPiA+ID4+Cj4gPiA+ID4+ICNpbmNsdWRlIDxmaWxlPgo+ID4gPiA+PiBUaGlz IHZhcmlhbnQgaXMgdXNlZCBmb3Igc3lzdGVtIGhlYWRlciBmaWxlcy4gSXQgc2VhcmNoZXMgZm9y IGEgZmlsZQo+ID4gPiA+PiBuYW1lZCBmaWxlIGluIGEgc3RhbmRhcmQgbGlzdCBvZiBzeXN0ZW0g ZGlyZWN0b3JpZXMuIFlvdSBjYW4gcHJlcGVuZAo+ID4gPiA+PiBkaXJlY3RvcmllcyB0byB0aGlz IGxpc3Qgd2l0aCB0aGUgLUkgb3B0aW9uIChzZWUgSW52b2NhdGlvbikuCj4gPiA+ID4gCj4gPiA+ ID4gVGhpcyBpcyBleGFjdGx5IHdoYXQgd2UgZG8uCj4gPiA+ID4gCj4gPiA+ID4+ICNpbmNsdWRl ICJmaWxlIgo+ID4gPiA+PiBUaGlzIHZhcmlhbnQgaXMgdXNlZCBmb3IgaGVhZGVyIGZpbGVzIG9m IHlvdXIgb3duIHByb2dyYW0uIEl0IHNlYXJjaGVzCj4gPiA+ID4+IGZvciBhIGZpbGUgbmFtZWQg ZmlsZSBmaXJzdCBpbiB0aGUgZGlyZWN0b3J5IGNvbnRhaW5pbmcgdGhlIGN1cnJlbnQKPiA+ID4g Pj4gZmlsZSwgdGhlbiBpbiB0aGUgcXVvdGUgZGlyZWN0b3JpZXMgYW5kIHRoZW4gdGhlIHNhbWUg ZGlyZWN0b3JpZXMgdXNlZAo+ID4gPiA+PiBmb3IgPGZpbGU+LiBZb3UgY2FuIHByZXBlbmQgZGly ZWN0b3JpZXMgdG8gdGhlIGxpc3Qgb2YgcXVvdGUgZGlyZWN0b3JpZXMKPiA+ID4gPj4gd2l0aCB0 aGUgLWlxdW90ZSBvcHRpb24uCj4gPiA+ID4gCj4gPiA+ID4gU2luY2Ugd2UgZG8gbm90IHVzZSAt aXF1b3RlLCAiIiBqdXN0IGFkZHMgdGhlIGN1cnJlbnQgZGlyZWN0b3J5Lgo+ID4gPiAKPiA+ID4g U28gd2h5IGRvbid0IHdlIHNpbXBseSBzd2l0Y2ggdG8gdXNlIC1pcXVvdGUgaW5zdGVhZCBvZiAt SSBmb3IgYWRkaW5nCj4gPiA+IHNlYXJjaCBwYXRocyBmb3Igb3VyIG93biBoZWFkZXJzPyBXZSB0 aGVuIHdvdWxkIGdldCBhIGNsZWFuIHNlcGFyYXRpb24KPiA+ID4gb2YgUUVNVSBoZWFkZXJzIGZy b20gc3lzdGVtIGhlYWRlcnMuCj4gPiA+IAo+ID4gPiAgVGhvbWFzCj4gPiAKPiA+IEl0IHN0aWxs IGxlYXZlcyB1cyB3aXRoIGEgaG9zdCBvZiBwcm9ibGVtcyBlLmcuIHRoZSBwcm9ibGVtIG9mIHN0 YWxlCj4gPiBoZWFkZXJzIGluIHRoZSBzb3VyY2UgZGlyZWN0b3J5Lgo+IAo+IFdlIGhhdmUgYSBw YXRjaCBvbiBsaXN0IHdoaWNoIGVmZmVjdGl2ZWx5IHNvbHZlcyB0aGUgcHJvYmxlbSBvZiBzdGFs ZQo+IGdlbmVyYXRlZCBmaWxlcyBpbiBzb3VyY2UgZGlyZWN0b3J5LCBzbyB0aGF0J3MgbGFyZ2Vs eSBhIG5vbi1pc3N1ZSBhdAo+IHRoaXMgcG9pbnQgSU1ITy4KPiAKPiBSZWdhcmRzLAo+IERhbmll bAoKVGhhdCB3YXMganVzdCBvbmUsIGFuZCB0aGUgc29sdXRpb24gaXMganVzdCB0byBmYWlsIGJ1 aWxkLgpJIHRoaW5rIHdlIGNhbiBzdHJpdmUgdG8gYWRkcmVzcyBhdCBsZWFzdCBzb21lIG9mIHRo ZSBmb2xsb3dpbmc6Ci0gbWFrZSBzdXJlIHRoYXQgYW4gaW5jb3JyZWN0IHVzZSBvZiBhIGhlYWRl ciBmYWlscyB0byBidWlsZAotIG1ha2UgaXQgZWFzaWVyIGZvciBuZXcgZGV2ZWxvcGVycyB0byB1 bmRlcnN0YW5kIHRoZSBjb2RlYmFzZQotIGJ1aWxkIGNvcnJlY3RseSByYXRoZXIgdGhhbiBmYWls IGluIGFzIG1hbnkgY29uZmlndXJhdGlvbnMgYXMgcG9zc2libGUKLSBhY3R1YWxseSBzdXBwb3J0 IGEgbWl4IG9mIGluIGFuZCBvdXQgb2YgdHJlZSBidWlsZHMKCkkgdGhpbmsgbXkgcGF0Y2ggdW5k ZXIgZGlzY3Vzc2lvbiBkb2VzIG5vdCBhZGRyZXNzIGFsbCBpc3N1ZXMgaGVyZS4KSSdsbCBwb3N0 IGEgbmV3IHByb3Bvc2FsIG5vdy4KCj4gLS0gCj4gfDogaHR0cHM6Ly9iZXJyYW5nZS5jb20gICAg ICAtby0gICAgaHR0cHM6Ly93d3cuZmxpY2tyLmNvbS9waG90b3MvZGJlcnJhbmdlIDp8Cj4gfDog aHR0cHM6Ly9saWJ2aXJ0Lm9yZyAgICAgICAgIC1vLSAgICAgICAgICAgIGh0dHBzOi8vZnN0b3Ax MzguYmVycmFuZ2UuY29tIDp8Cj4gfDogaHR0cHM6Ly9lbnRhbmdsZS1waG90by5vcmcgICAgLW8t ICAgIGh0dHBzOi8vd3d3Lmluc3RhZ3JhbS5jb20vZGJlcnJhbmdlIDp8CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs