From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
Yuval Shaia <yuval.shaia@oracle.com>
Subject: Re: [Qemu-devel] [PATCH for-2.12 1/2] rdma: fix up include directives
Date: Wed, 21 Mar 2018 15:38:09 +0000 [thread overview]
Message-ID: <20180321153809.GT8551@redhat.com> (raw)
In-Reply-To: <1521645545-247351-1-git-send-email-mst@redhat.com>
On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote:
> Our rule right now is to use <> for external headers only.
> RDMA code violates that, fix it up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/rdma/rdma_backend.h | 2 +-
> hw/rdma/rdma_backend_defs.h | 2 +-
> hw/rdma/rdma_rm.h | 2 +-
> hw/rdma/rdma_utils.h | 6 +++---
> hw/rdma/vmw/pvrdma.h | 8 ++++----
> hw/rdma/vmw/pvrdma_dev_ring.h | 2 +-
> hw/rdma/rdma_backend.c | 6 +++---
> hw/rdma/rdma_rm.c | 6 +++---
> hw/rdma/vmw/pvrdma_cmd.c | 8 ++++----
> hw/rdma/vmw/pvrdma_dev_ring.c | 8 ++++----
> hw/rdma/vmw/pvrdma_main.c | 24 ++++++++++++------------
> hw/rdma/vmw/pvrdma_qp_ops.c | 4 ++--
> 12 files changed, 39 insertions(+), 39 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
I'm assuming these were detected by build failures caused by the 2nd
patch in this series, so other areas of the codebase are all correct
already.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-03-21 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 15:22 [Qemu-devel] [PATCH for-2.12 1/2] rdma: fix up include directives Michael S. Tsirkin
2018-03-21 15:22 ` [Qemu-devel] [PATCH for-2.12 2/2] make: switch from -I to -iquote Michael S. Tsirkin
2018-03-21 15:36 ` Daniel P. Berrangé
2018-03-21 16:02 ` Michael S. Tsirkin
2018-03-21 16:40 ` Marcel Apfelbaum
2018-03-21 19:13 ` Michael S. Tsirkin
2018-03-22 21:20 ` Stefan Hajnoczi
2018-03-21 15:38 ` Daniel P. Berrangé [this message]
2018-03-21 16:35 ` [Qemu-devel] [PATCH for-2.12 1/2] rdma: fix up include directives Marcel Apfelbaum
2018-03-21 21:15 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321153809.GT8551@redhat.com \
--to=berrange@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.