From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Jin, Yao" <yao.jin@linux.intel.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs
Date: Wed, 21 Mar 2018 17:04:46 +0100 [thread overview]
Message-ID: <20180321160446.GB2707@krava> (raw)
In-Reply-To: <20180321154315.GD24312@kernel.org>
On Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu:
> > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote:
> > > > Hi Jiri,
> > > >
> > > > I'm still thinking it's worth displaying the warning when perf missing some
> > > > libraries.
> > > >
> > > > Somebody just told me that perf didn't work well. While after some
> > > > investigations, I found it's just missing some libraries when building the
> > > > perf.
> > > >
> > > > But I have spent some time on getting the root cause. If with this patch, it
> > > > should be very easily to know that.
> > >
> > > true.. Arnaldo, any feedback on this one?
> >
> > Lemme re-read the thread...
>
> Well, how about we make it harder to build without key libraries? I.e.
> if we detect that what we consider a core set of libraries isn't found
> in the system, then we stop the build, warn about it and ask the user to
> confirm that the build should proceed by passing some explicit
> -DI_KNOW_WHAT_I_AM_DOING___PROCEED=doit
hum, not sure we want to complicate the build even more than it
is now :-\ and IMO it still won't help much in Jin's problem,
if user forces the build anyway
jirka
next prev parent reply other threads:[~2018-03-21 16:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 11:03 [PATCH] perf util: Display warning when perf report/annotate is missing some libs Jin Yao
2018-01-11 15:30 ` Jiri Olsa
2018-01-12 2:22 ` Jin, Yao
2018-03-21 2:11 ` Jin, Yao
2018-03-21 15:38 ` Jiri Olsa
2018-03-21 15:40 ` Arnaldo Carvalho de Melo
2018-03-21 15:43 ` Arnaldo Carvalho de Melo
2018-03-21 15:45 ` Arnaldo Carvalho de Melo
2018-03-21 16:04 ` Jiri Olsa [this message]
2018-03-21 18:52 ` Arnaldo Carvalho de Melo
2018-03-21 19:02 ` Jiri Olsa
2018-03-22 1:31 ` Jin, Yao
2018-03-22 1:04 ` Jin, Yao
2018-03-22 8:51 ` Jiri Olsa
2018-03-23 3:09 ` Jin, Yao
2018-03-23 14:50 ` Arnaldo Carvalho de Melo
2018-03-23 15:17 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321160446.GB2707@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.