From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Thomas Hellstrom <thomas@shipmail.org>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
intel-gfx@lists.freedesktop.org,
Keith Packard <keithp@keithp.com>,
dri-devel@lists.freedesktop.org
Subject: Re: drm-next xf86-video-vmware breakage Was [PATCH 02/10] drm/uapi: Validate the mode flags/type
Date: Wed, 21 Mar 2018 22:51:02 +0200 [thread overview]
Message-ID: <20180321205102.GE5453@intel.com> (raw)
In-Reply-To: <2d0b9762-60ab-f51b-cbac-a163ec6dc830@shipmail.org>
On Wed, Mar 21, 2018 at 09:45:09PM +0100, Thomas Hellstrom wrote:
> Hi, Ville,
>
> On 11/14/2017 07:32 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Currently userspace is allowed to feed in any king of garbage in the
> > high bits of the mode flags/type, as are drivers when probing modes.
> > Reject any mode with bogus flags/type.
> >
> > Hopefully this won't break any current userspace...
>
> Unfortunately this breaks xf86-video-vmware which currently leaves the
> mode->type uninitialized :(.
> That code is inherited from the old gallium xorg state tracker. I don't
> know whether it has spread elsewhere but the symptoms are that the X
> server frequently dies failing to set screen resources, a very
> uninformative error.
>
> I'll fix the xf86-video-vmware driver, but I guess we need to back out
> the mode->type check.
Dang. So the flags check is fine but type check is not?
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-21 20:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 18:32 [PATCH 00/10] drm/uapi: Validate mode flags/type, and deprecate some of them Ville Syrjala
2017-11-14 18:32 ` [PATCH 01/10] drm/modes: Move 3D stereo flag check into drm_mode_validate_basic() Ville Syrjala
2017-11-14 19:22 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 02/10] drm/uapi: Validate the mode flags/type Ville Syrjala
2017-11-14 18:42 ` [Intel-gfx] " Chris Wilson
2017-11-14 18:46 ` Ville Syrjälä
2017-11-15 15:49 ` [PATCH v2 " Ville Syrjala
2017-11-15 17:38 ` Alex Deucher
2017-11-15 18:02 ` Jose Abreu
2017-11-15 18:11 ` Ville Syrjälä
2018-03-21 20:45 ` drm-next xf86-video-vmware breakage Was [PATCH " Thomas Hellstrom
2018-03-21 20:51 ` Ville Syrjälä [this message]
2018-03-21 21:06 ` Thomas Hellstrom
2017-11-14 18:32 ` [PATCH 03/10] drm/uapi: Deprecate DRM_MODE_FLAG_PIXMUX Ville Syrjala
2017-11-14 19:12 ` Alex Deucher
2017-11-15 18:05 ` Jose Abreu
2017-11-14 18:32 ` [PATCH 04/10] drm/uapi: Deprecate DRM_MODE_FLAG_BCAST Ville Syrjala
2017-11-14 19:13 ` Alex Deucher
2017-11-15 18:05 ` Jose Abreu
2017-11-14 18:32 ` [PATCH 05/10] drm/modes: Fix description of DRM_MODE_TYPE_USERDEF Ville Syrjala
2017-11-14 19:32 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 06/10] drm/modes: Kill off the oddball DRM_MODE_TYPE_CRTC_C vs. DRM_MODE_TYPE_BUILTIN handling Ville Syrjala
2017-11-14 18:43 ` Chris Wilson
2017-11-14 19:16 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 07/10] drm/modes: Kill DRM_MODE_TYPE_CLOCK_CRTC_C define Ville Syrjala
2017-11-14 19:17 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 08/10] drm/uapi: Deprecate nonsense kms mode types Ville Syrjala
2017-11-14 19:19 ` Alex Deucher
2017-11-14 20:43 ` Adam Jackson
[not found] ` <20171115154504.14338-1-ville.syrjala@linux.intel.com>
2017-11-15 18:04 ` [PATCH v2 " Jose Abreu
2017-11-14 18:32 ` [PATCH 09/10] drm/modes: Provide global mode_valid hook Ville Syrjala
2017-11-20 8:00 ` Daniel Vetter
2017-11-14 18:32 ` [PATCH 10/10] drm/i915: Provide a device level .mode_valid() hook Ville Syrjala
2017-11-20 8:01 ` Daniel Vetter
2017-11-20 8:02 ` Daniel Vetter
2017-11-14 19:13 ` ✓ Fi.CI.BAT: success for drm/uapi: Validate mode flags/type, and deprecate some of them Patchwork
2017-11-14 21:41 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-11-15 16:11 ` ✓ Fi.CI.BAT: success for drm/uapi: Validate mode flags/type, and deprecate some of them (rev2) Patchwork
2017-11-15 17:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-29 20:12 ` [PATCH 00/10] drm/uapi: Validate mode flags/type, and deprecate some of them Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321205102.GE5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Jose.Abreu@synopsys.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=thomas@shipmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.