Re: [PATCH] ASoC: nau8824: user configuration of key detection

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 810 bytes --]

On Wed, Mar 21, 2018 at 03:30:23PM +0800, John Hsu wrote:
> The SAR ADC of key press detection varies depending on headset.
> We can't make a set of common threshold values for every case.
> Therefore, the driver provides configuration for user and
> they can set up values by UCM configuration.

It's more normal for this configuration to be done as part of the
platform bindings for the device, with the values being tuned based on
the in box headset and the tastes of the system integrator, seeing this
exposed as a userspace control is a bit surprising - what motivated
that?

If we are going to have this tunable from userspace we probably want a
standard interface for it so that the userspace software can work more
generally.  However that's a bit tricky as the tunable parameters are
going to vary...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]