From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Thu, 22 Mar 2018 08:45:11 +0000 Subject: Re: [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses Message-Id: <20180322084511.GA6211@kroah.com> List-Id: References: <1520993825-8605-1-git-send-email-y.k.oh@samsung.com> <20180314135804.GA21350@kroah.com> <2f2dcf3c-2432-3dc7-5fd4-f9326ef48455@samsung.com> In-Reply-To: <2f2dcf3c-2432-3dc7-5fd4-f9326ef48455@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "y.k.oh" Cc: jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Mar 22, 2018 at 01:37:45PM +0900, y.k.oh wrote: > > > On 03/14/2018 10:58 PM, Greg KH wrote: > > On Wed, Mar 14, 2018 at 11:17:05AM +0900, YOUNGKEUN OH wrote: > >> Cleanup checkpatch error: > >> ERROR: Macros with complex values should be enclosed in parentheses > >> > >> Signed-off-by: YOUNGKEUN OH > >> --- > >> drivers/tty/serial/samsung.c | 16 ++++++++-------- > >> 1 file changed, 8 insertions(+), 8 deletions(-) > >> > >> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > >> index 3f2f8c1..da9bddb1 100644 > >> --- a/drivers/tty/serial/samsung.c > >> +++ b/drivers/tty/serial/samsung.c > >> @@ -1455,7 +1455,7 @@ static int __init s3c24xx_serial_console_init(void) > >> } > >> console_initcall(s3c24xx_serial_console_init); > >> > >> -#define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console > >> +#define S3C24XX_SERIAL_CONSOLE (&s3c24xx_serial_console) > > > > That's not a complex macro! > > > > Please use checkpatch as a hint, not the "truth". > > > > thanks, > > > > greg k-h > > > Dear Greg. > > Yes! Of course that's not a pretty complex macro. However, I think it is > important to make a small effort to modify the minimum standard, > Checkpatch ERROR, to ensure consistency in the Linux code. > Starting with this Checkpatch error of samsung.c, I would like to start > my efforts on contribution from a small point. Please review it again. Why would I review something again that is not correct? If you wish to start out in kernel development, please start in drivers/staging/*/TODO, not in "core" kernel code. That is what the drivers/staging/ code is there for. good luck! greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses Date: Thu, 22 Mar 2018 09:45:11 +0100 Message-ID: <20180322084511.GA6211@kroah.com> References: <1520993825-8605-1-git-send-email-y.k.oh@samsung.com> <20180314135804.GA21350@kroah.com> <2f2dcf3c-2432-3dc7-5fd4-f9326ef48455@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2f2dcf3c-2432-3dc7-5fd4-f9326ef48455@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: "y.k.oh" Cc: jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Thu, Mar 22, 2018 at 01:37:45PM +0900, y.k.oh wrote: > > > On 03/14/2018 10:58 PM, Greg KH wrote: > > On Wed, Mar 14, 2018 at 11:17:05AM +0900, YOUNGKEUN OH wrote: > >> Cleanup checkpatch error: > >> ERROR: Macros with complex values should be enclosed in parentheses > >> > >> Signed-off-by: YOUNGKEUN OH > >> --- > >> drivers/tty/serial/samsung.c | 16 ++++++++-------- > >> 1 file changed, 8 insertions(+), 8 deletions(-) > >> > >> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > >> index 3f2f8c1..da9bddb1 100644 > >> --- a/drivers/tty/serial/samsung.c > >> +++ b/drivers/tty/serial/samsung.c > >> @@ -1455,7 +1455,7 @@ static int __init s3c24xx_serial_console_init(void) > >> } > >> console_initcall(s3c24xx_serial_console_init); > >> > >> -#define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console > >> +#define S3C24XX_SERIAL_CONSOLE (&s3c24xx_serial_console) > > > > That's not a complex macro! > > > > Please use checkpatch as a hint, not the "truth". > > > > thanks, > > > > greg k-h > > > Dear Greg. > > Yes! Of course that's not a pretty complex macro. However, I think it is > important to make a small effort to modify the minimum standard, > Checkpatch ERROR, to ensure consistency in the Linux code. > Starting with this Checkpatch error of samsung.c, I would like to start > my efforts on contribution from a small point. Please review it again. Why would I review something again that is not correct? If you wish to start out in kernel development, please start in drivers/staging/*/TODO, not in "core" kernel code. That is what the drivers/staging/ code is there for. good luck! greg k-h