From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbeCVJO7 (ORCPT ); Thu, 22 Mar 2018 05:14:59 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48756 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752935AbeCVJOv (ORCPT ); Thu, 22 Mar 2018 05:14:51 -0400 Date: Thu, 22 Mar 2018 10:14:48 +0100 From: Jiri Olsa To: Petr Machata Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim Subject: Re: [PATCH] perf: python: Reference Py_None before returning it Message-ID: <20180322091448.GA2972@krava> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 22, 2018 at 12:57:32AM +0100, Petr Machata wrote: > Python None objects are handled just like all the other objects with > respect to their reference counting. Before returning Py_None, its > reference count thus needs to be bumped. > > Signed-off-by: Petr Machata Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/util/python.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c > index b1e999b..762d429 100644 > --- a/tools/perf/util/python.c > +++ b/tools/perf/util/python.c > @@ -967,8 +967,10 @@ static PyObject *pyrf_evlist__read_on_cpu(struct pyrf_evlist *pevlist, > return PyErr_NoMemory(); > > evsel = perf_evlist__event2evsel(evlist, event); > - if (!evsel) > + if (!evsel) { > + Py_INCREF(Py_None); > return Py_None; > + } > > pevent->evsel = evsel; > > -- > 2.4.3 >