From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd Date: Thu, 22 Mar 2018 13:00:21 +0100 Message-ID: <20180322120021.GA3304@kroah.com> References: <643701fef843f91931e3a68779afe053c63c96f6.1521707846.git.chunfeng.yun@mediatek.com> <20180322090127.GA12048@kroah.com> <1521710486.3717.146.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1521710486.3717.146.camel@mhfsdcap03> Sender: linux-kernel-owner@vger.kernel.org To: Chunfeng Yun Cc: Martin Blumenstingl , Mathias Nyman , Matthias Brugger , Roger Quadros , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Thu, Mar 22, 2018 at 05:21:26PM +0800, Chunfeng Yun wrote: > hi, > On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote: > > > The phys has already been initialized when add primary hcd, > > > including usb2 phys and usb3 phys also if exist, so needn't > > > re-parse "phys" property again. > > > > > > Signed-off-by: Chunfeng Yun > > > --- > > > drivers/usb/core/hcd.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > What changed from version 1? > V1: skip phys initialization when add shared HCD by setting > xhci->shared_hcd->skip_phy_initialization=1; > for both xhci-plat.c & xhci-mtk.c files. > > V2: fix it in hcd.c suggested by Roger Please put it in the patch itself, resend v3 with this info. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [usb-next,v2] usb: xhci: skip phys initialization of shared hcd From: Greg Kroah-Hartman Message-Id: <20180322120021.GA3304@kroah.com> Date: Thu, 22 Mar 2018 13:00:21 +0100 To: Chunfeng Yun Cc: Martin Blumenstingl , Mathias Nyman , Matthias Brugger , Roger Quadros , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org List-ID: T24gVGh1LCBNYXIgMjIsIDIwMTggYXQgMDU6MjE6MjZQTSArMDgwMCwgQ2h1bmZlbmcgWXVuIHdy b3RlOgo+IGhpLCAKPiBPbiBUaHUsIDIwMTgtMDMtMjIgYXQgMTA6MDEgKzAxMDAsIEdyZWcgS3Jv YWgtSGFydG1hbiB3cm90ZToKPiA+IE9uIFRodSwgTWFyIDIyLCAyMDE4IGF0IDA0OjM5OjIwUE0g KzA4MDAsIENodW5mZW5nIFl1biB3cm90ZToKPiA+ID4gVGhlIHBoeXMgaGFzIGFscmVhZHkgYmVl biBpbml0aWFsaXplZCB3aGVuIGFkZCBwcmltYXJ5IGhjZCwKPiA+ID4gaW5jbHVkaW5nIHVzYjIg cGh5cyBhbmQgdXNiMyBwaHlzIGFsc28gaWYgZXhpc3QsIHNvIG5lZWRuJ3QKPiA+ID4gcmUtcGFy c2UgInBoeXMiIHByb3BlcnR5IGFnYWluLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2h1 bmZlbmcgWXVuIDxjaHVuZmVuZy55dW5AbWVkaWF0ZWsuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRy aXZlcnMvdXNiL2NvcmUvaGNkLmMgfCAyICstCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gV2hhdCBjaGFuZ2VkIGZyb20gdmVyc2lv biAxPwo+IFYxOiBza2lwIHBoeXMgaW5pdGlhbGl6YXRpb24gd2hlbiBhZGQgc2hhcmVkIEhDRCBi eSBzZXR0aW5nCj4geGhjaS0+c2hhcmVkX2hjZC0+c2tpcF9waHlfaW5pdGlhbGl6YXRpb249MTsK PiBmb3IgYm90aCB4aGNpLXBsYXQuYyAmIHhoY2ktbXRrLmMgZmlsZXMuCj4gCj4gVjI6IGZpeCBp dCBpbiBoY2QuYyBzdWdnZXN0ZWQgYnkgUm9nZXIKClBsZWFzZSBwdXQgaXQgaW4gdGhlIHBhdGNo IGl0c2VsZiwgcmVzZW5kIHYzIHdpdGggdGhpcyBpbmZvLgoKdGhhbmtzLAoKZ3JlZyBrLWgKLS0t ClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmli ZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5r ZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcv bWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Thu, 22 Mar 2018 13:00:21 +0100 Subject: [usb-next, v2 PATCH] usb: xhci: skip phys initialization of shared hcd In-Reply-To: <1521710486.3717.146.camel@mhfsdcap03> References: <643701fef843f91931e3a68779afe053c63c96f6.1521707846.git.chunfeng.yun@mediatek.com> <20180322090127.GA12048@kroah.com> <1521710486.3717.146.camel@mhfsdcap03> Message-ID: <20180322120021.GA3304@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 22, 2018 at 05:21:26PM +0800, Chunfeng Yun wrote: > hi, > On Thu, 2018-03-22 at 10:01 +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 22, 2018 at 04:39:20PM +0800, Chunfeng Yun wrote: > > > The phys has already been initialized when add primary hcd, > > > including usb2 phys and usb3 phys also if exist, so needn't > > > re-parse "phys" property again. > > > > > > Signed-off-by: Chunfeng Yun > > > --- > > > drivers/usb/core/hcd.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > What changed from version 1? > V1: skip phys initialization when add shared HCD by setting > xhci->shared_hcd->skip_phy_initialization=1; > for both xhci-plat.c & xhci-mtk.c files. > > V2: fix it in hcd.c suggested by Roger Please put it in the patch itself, resend v3 with this info. thanks, greg k-h