All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Giuseppe Lippolis <giu.lippolis@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: net-usb: add lte modem wistron neweb d18q1
Date: Thu, 22 Mar 2018 15:55:05 +0100	[thread overview]
Message-ID: <20180322145505.GC8272@localhost> (raw)

On Thu, Mar 22, 2018 at 03:40:40PM +0100, Giuseppe Lippolis wrote:
> This modem is embedded on dlink dwr-921 router.
> The oem configuration states:

> Signed-off-by: Giuseppe Lippolis <giu.lippolis@gmail.com>
> ---
>  drivers/net/usb/qmi_wwan.c  |  3 +++
>  drivers/usb/serial/option.c | 11 +++++++++++
>  2 files changed, 14 insertions(+)

Please split this up in two patches; one for qmi_wwan and one for
option.

Note that the option blacklist-implementation has just been updated, so
please respin that part against the usb-next branch of

	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/

(or simply against linux-next). Some more details can be found here:

	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=c3a65808f04a8426481b63a4fbd9392f009f6330

> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 5894e3c..b1f9b0a 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1100,6 +1100,9 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x0846, 0x68a2, 8)},
>  	{QMI_FIXED_INTF(0x12d1, 0x140c, 1)},	/* Huawei E173 */
>  	{QMI_FIXED_INTF(0x12d1, 0x14ac, 1)},	/* Huawei E1820 */
> +	{QMI_FIXED_INTF(0x1435, 0xd181, 3)},	/* Wistron NeWeb D18Q1 */
> +	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
> +	{QMI_FIXED_INTF(0x1435, 0xd181, 5)},	/* Wistron NeWeb D18Q1 */
>  	{QMI_FIXED_INTF(0x16d8, 0x6003, 0)},	/* CMOTech 6003 */
>  	{QMI_FIXED_INTF(0x16d8, 0x6007, 0)},	/* CMOTech CHE-628S */
>  	{QMI_FIXED_INTF(0x16d8, 0x6008, 0)},	/* CMOTech CMU-301 */
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index ebe51f11..5aea146 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -542,6 +542,10 @@ static void option_instat_callback(struct urb *urb);
>  #define WETELECOM_PRODUCT_6802			0x6802
>  #define WETELECOM_PRODUCT_WMD300		0x6803
>  
> +/* Wistron NeWeb products */
> +#define WISTRON_NEWEB_VENDOR_ID			0x1435
> +#define WISTRON_NEWEB_PRODUCT_D18Q1		0xd181

Also please drop these defines and use and the numerical ids directly (with
a comment after the entry) as you do for qmi_wwan.

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-03-22 14:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 14:55 Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-22 14:40 net-usb: add lte modem wistron neweb d18q1 Giuseppe Lippolis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322145505.GC8272@localhost \
    --to=johan@kernel.org \
    --cc=giu.lippolis@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.