From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 7/7] ext4: don't update checksum of new initialized bitmaps
Date: Thu, 22 Mar 2018 11:29:52 -0400 [thread overview]
Message-ID: <20180322152952.GF2852@thunk.org> (raw)
In-Reply-To: <20180307090607.wfkplsuvigaoie5o@quack2.suse.cz>
On Wed, Mar 07, 2018 at 10:06:07AM +0100, Jan Kara wrote:
>
> Probably you should remove the bad checksum handling in
> ext4_init_block_bitmap() the same way as you did in
> ext4_init_inode_bitmap()? Otherwise the patch looks good.
There isn't an ext4_init_inode_bitmap() --- the functionality is
inlined ext4_read_inode_bitmap(), and it's already doing it that way
(it doesn't set the checksum; it just sets the verified bit).
- Ted
prev parent reply other threads:[~2018-03-22 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180220023038.19883-1-tytso@mit.edu>
2018-02-20 2:30 ` [PATCH 3/7] ext4: shutdown should not prevent get_write_access Theodore Ts'o
2018-03-07 9:42 ` Jan Kara
2018-03-22 15:38 ` Theodore Y. Ts'o
2018-02-20 2:30 ` [PATCH 4/7] ext4: eliminate sleep from shutdown ioctl Theodore Ts'o
2018-03-07 9:07 ` Jan Kara
2018-02-20 2:30 ` [PATCH 5/7] ext4: pass -ESHUTDOWN code to jbd2 layer Theodore Ts'o
2018-03-06 17:10 ` Jan Kara
2018-03-22 15:26 ` Theodore Y. Ts'o
2018-05-17 15:18 ` Jan Kara
2018-02-20 2:30 ` [PATCH 6/7] jbd2: if the journal is aborted then don't allow update of the log tail Theodore Ts'o
2018-03-07 8:55 ` Jan Kara
2018-02-20 2:30 ` [PATCH 7/7] ext4: don't update checksum of new initialized bitmaps Theodore Ts'o
2018-03-07 9:06 ` Jan Kara
2018-03-22 15:29 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322152952.GF2852@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.