From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff McGee Subject: Re: [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted Date: Thu, 22 Mar 2018 08:34:45 -0700 Message-ID: <20180322153445.GL19343@jeffdesk> References: <20180322073533.5313-1-chris@chris-wilson.co.uk> <20180322073533.5313-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACBD16EC88 for ; Thu, 22 Mar 2018 15:49:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180322073533.5313-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMjIsIDIwMTggYXQgMDc6MzU6MzJBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFVzaW5nIGVuZ2luZS0+aXJxX3Bvc3RlZCBmb3IgZXhlY2xpc3RzLCB3ZSBhcmUgbm90 IGFsd2F5cyBzZXJpYWxpc2VkIGJ5Cj4gdGhlIHRhc2tsZXQgYXMgd2Ugc3VwcG9zZWQuIE9uIHRo ZSByZXNldCBwYXRocywgdGhlIHRhc2tsZXQgaXMgZGlzYWJsZWQKPiBhbmQgaWdub3JlZC4gSW5z dGVhZCwgd2UgbWFuaXB1bGF0ZSB0aGUgZW5naW5lLT5pcnFfcG9zdGVkIGRpcmVjdGx5IHRvCj4g YWNjb3VudCBmb3IgdGhlIHJlc2V0LCBidXQgaWYgYW4gaW50ZXJydXB0IGZpcmVkIGJlZm9yZSB0 aGUgcmVzZXQgYW5kIHNvCj4gd3JvdGUgdG8gZW5naW5lLT5pcnFfcG9zdGVkLCB0aGF0IHdyaXRl IG1heSBub3QgYmUgZmx1c2hlZCBmcm9tIHRoZQo+IGxvY2FsIENQVSdzIGNhY2hlbGluZSB1bnRp bCBtdWNoIGxhdGVyIGFzIHRoZSB0YXNrbGV0IGlzIGFscmVhZHkgYWN0aXZlCj4gYW5kIHNvIGRv ZXMgbm90IGdlbmVyYXRlIGEgbWIoKS4gVG8gY29ycmVjdGx5IHNlcmlhbGlzZSB0aGUgaW50ZXJy dXB0Cj4gd2l0aCByZXNldCwgd2UgbmVlZCBzZXJpYWxpc2F0aW9uIG9uIHRoZSBzZXRfYml0KCkg aXRzZWxmLgo+IAo+IEFuZCBhdCBsYXN0IE1pa2EgY2FuIGJlIGhhcHB5Lgo+IAo+IFNpZ25lZC1v ZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWth IEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWljaGHFgiBX aW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+IENDOiBNaWNoZWwgVGhpZXJy eSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IENjOiBKZWZmIE1jR2VlIDxqZWZmLm1jZ2Vl QGludGVsLmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDcgKysrLS0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4IGZhNzMxMDc2NjIxNy4uMjdhZWUyNTQyOWI3IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTE0MDUsMTAgKzE0MDUsOSBAQCBnZW44 X2NzX2lycV9oYW5kbGVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgdTMyIGlpcikK PiAgCWJvb2wgdGFza2xldCA9IGZhbHNlOwo+ICAKPiAgCWlmIChpaXIgJiBHVF9DT05URVhUX1NX SVRDSF9JTlRFUlJVUFQpIHsKPiAtCQlpZiAoUkVBRF9PTkNFKGVuZ2luZS0+ZXhlY2xpc3RzLmFj dGl2ZSkpIHsKPiAtCQkJX19zZXRfYml0KEVOR0lORV9JUlFfRVhFQ0xJU1QsICZlbmdpbmUtPmly cV9wb3N0ZWQpOwo+IC0JCQl0YXNrbGV0ID0gdHJ1ZTsKPiAtCQl9Cj4gKwkJaWYgKFJFQURfT05D RShlbmdpbmUtPmV4ZWNsaXN0cy5hY3RpdmUpKQo+ICsJCQl0YXNrbGV0ID0gIXRlc3RfYW5kX3Nl dF9iaXQoRU5HSU5FX0lSUV9FWEVDTElTVCwKPiArCQkJCQkJICAgICZlbmdpbmUtPmlycV9wb3N0 ZWQpOwo+ICAJfQo+ICAKPiAgCWlmIChpaXIgJiBHVF9SRU5ERVJfVVNFUl9JTlRFUlJVUFQpIHsK PiAtLSAKPiAyLjE2LjIKPiAKCkNvbmZpcm1lZCB0aGF0IHRoaXMgYWxvbmcgd2l0aCB0aGUgaW50 ZXJydXB0IGZsdXNoIGVsaW1pbmF0ZXMgdGhlIGNhc2VzCm9mIGZpbmRpbmcgQ1NCIHRhaWwgYXQg aXRzIHJlc2V0IHZhbHVlICgweDcpIGluIHRoZSB0YXNrbGV0IGluIG15IGZvcmNlCnByZWVtcHRp b24gdGVzdHMuCgpSZXZpZXdlZC1ieTogSmVmZiBNY0dlZSA8amVmZi5tY2dlZUBpbnRlbC5jb20+ Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=