From: Jiri Olsa <jolsa@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Quentin Monnet <quentin.monnet@netronome.com>,
Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn
Date: Fri, 23 Mar 2018 10:09:27 +0100 [thread overview]
Message-ID: <20180323090927.GA4096@krava> (raw)
In-Reply-To: <96093da6-9e0f-5d6b-59a4-91a744ad64cb@iogearbox.net>
On Thu, Mar 22, 2018 at 05:07:48PM +0100, Daniel Borkmann wrote:
SNIP
> >>> + va_end(args);
> >>> +}
> >>> EXPORT_SYMBOL_GPL(bpf_verifier_log_write);
> >>> +
> >>> +__printf(2, 3) static void print_ins(void *private_data,
> >>> + const char *fmt, ...)
> >>
> >> Unless I am mistaken, you could just call this one "verbose()" and
> >> simply remove the function alias?
> >
> > right you are ;-) I haven't realized that struct bpf_verifier_env *env
> > will cleanly cast to void *
> >
> > new version attached.. I'll make some tests and send full patch
>
> When you do so, please make sure to send a full fresh series with the two
> patches and also cover letter included, otherwise it's more fragile wrt
> potentially applying the wrong patch from one of the replies. :-)
will do, thanks
jirka
next prev parent reply other threads:[~2018-03-23 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 15:02 [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn Jiri Olsa
2018-03-21 15:02 ` [PATCH 2/2] bpftool: Adjust to new print_bpf_insn interface Jiri Olsa
2018-03-21 16:39 ` Quentin Monnet
2018-03-21 16:43 ` Jiri Olsa
2018-03-21 16:44 ` Daniel Borkmann
2018-03-21 17:00 ` [PATCHv2 " Jiri Olsa
2018-03-21 17:30 ` Quentin Monnet
2018-03-21 17:25 ` [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn Quentin Monnet
2018-03-21 18:37 ` Jiri Olsa
2018-03-22 9:34 ` Daniel Borkmann
2018-03-22 13:32 ` Jiri Olsa
2018-03-22 15:35 ` Quentin Monnet
2018-03-22 15:57 ` Jiri Olsa
2018-03-22 16:07 ` Daniel Borkmann
2018-03-23 9:09 ` Jiri Olsa [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-23 10:41 [PATCH 0/2] bpf: Change print_bpf_insn interface Jiri Olsa
2018-03-23 10:41 ` [PATCH 1/2] bpf: Remove struct bpf_verifier_env argument from print_bpf_insn Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323090927.GA4096@krava \
--to=jolsa@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.